Error page "details" string is confusing. |
|||
Issue descriptionSo, it appears we have IDS_ERROR_PAGES_DETAILS_FOO which is not what's under the "Details" button in the UI. That's now a bitmap of "suggestions". The IDS_ERROR_PAGES_DETAILS_FOO strings themselves, while defined, are completely unused save for iframe network error pages where they appear on hover. It doesn't make much sense to have iframe network error pages use a completely different set of strings than the rest. Can we unwind the details strings and get them out of the binary so we aren't wasting space with them and generally being confusing? Have iframes use the IDS_ERROR_PAGES_SUMMARY strings or so?
,
Jun 16 2016
I was actually thinking we could get rid of them altogether. I figure the iframes should show the summary strings or something.
,
Jun 16 2016
+1 for getting rid of them and using summaries. Multiple strings is just more effort to maintain for very little potential benefit. I can't even remember the last time the mouse over text for a failed iframe load was useful, or even mentioned, in a bug report.
,
Jun 27 2016
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/863b125313682291e0f5f061563004216f54f852 commit 863b125313682291e0f5f061563004216f54f852 Author: edwardjung <edwardjung@chromium.org> Date: Tue Jun 28 13:19:18 2016 Remove details strings used by iframes on network error pages + Switch the string used by iframes from the the 'details' to 'summary'. + Switch iframe icon to a div, so consistent with the main frame icon implementation. It removes the icon border applied to images with no src which shows up before the JS is executed. + LocalizedError::GetErrorDetails switched to returned the 'summary' string. BUG= 620113 Review-Url: https://codereview.chromium.org/2094733002 Cr-Commit-Position: refs/heads/master@{#402451} [modify] https://crrev.com/863b125313682291e0f5f061563004216f54f852/components/error_page/common/localized_error.cc [modify] https://crrev.com/863b125313682291e0f5f061563004216f54f852/components/error_page_strings.grdp [modify] https://crrev.com/863b125313682291e0f5f061563004216f54f852/components/neterror/resources/neterror.css [modify] https://crrev.com/863b125313682291e0f5f061563004216f54f852/components/neterror/resources/neterror.html
,
Jun 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b8c4b47acfae1445908f0fec62c217e25b53c48 commit 2b8c4b47acfae1445908f0fec62c217e25b53c48 Author: edwardjung <edwardjung@chromium.org> Date: Thu Jun 30 11:54:09 2016 Remove unused iOS network error strings BUG= 620113 Review-Url: https://codereview.chromium.org/2105743003 Cr-Commit-Position: refs/heads/master@{#403145} [modify] https://crrev.com/2b8c4b47acfae1445908f0fec62c217e25b53c48/components/error_page_strings.grdp
,
Jul 1 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by edwardjung@chromium.org
, Jun 16 2016