New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620106 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 643081
issue 654814



Sign in to add a comment

flashrom support for raiden_spi serial number

Project Member Reported by nsanders@chromium.org, Jun 14 2016

Issue description

Currently the raiden_spi endpoint for flashrom uses the first matched device. Could it be modified to have a serial number commandline option and  select the correct USB device?
 
Cc: souvikghosh@google.com
Status: Started (was: Untriaged)
Yes, that should be pretty simple to implement. I took a stab at it here: https://chromium-review.googlesource.com/#/c/352820/

I don't have hardware to test it with. Try adding serial=<serial_num> to your programmer arguments, ie "-p raiden_spi:serial=<serial num>" and let me know how it goes.

Souvik might also be able to help.
Blocking: 643081
This looks like it will require a refactor of the usb init code to remove a bunch of hardcoded assumptions. Maybe better if dhendrix@ does it.
Labels: -Pri-3 Pri-2
Blocking: 654814
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/5c79a49c0fe6fec3474678c4846e74532cf7a1f1

commit 5c79a49c0fe6fec3474678c4846e74532cf7a1f1
Author: David Hendricks <dhendrix@chromium.org>
Date: Wed Jun 15 03:56:36 2016

usb_device: Add serial number to command-line parameters

This adds support for specifying serial number for programmers
which use the usb_device library, such as raiden_spi.

BUG= chromium:620106 
BRANCH=none
TEST=needs testing

Change-Id: I895bc08a3e2c14ba1c1e1a81f8dbf2073d0d8f3a
Signed-off-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/352820
Tested-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>

[modify] https://crrev.com/5c79a49c0fe6fec3474678c4846e74532cf7a1f1/raiden_debug_spi.c
[modify] https://crrev.com/5c79a49c0fe6fec3474678c4846e74532cf7a1f1/usb_device.h

Cc: martinroth@chromium.org
Status: Fixed (was: Started)

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Status: Verified (was: Archived)

Sign in to add a comment