Issue metadata
Sign in to add a comment
|
css3/filters/effect-brightness-hw.html failing after autorebaselining |
||||||||||||||||||||||
Issue descriptionFailing on these bots: WebKit Linux (dbg) rev 399718 ... 399727 WebKit Linux rev 399733 ... 399737 WebKit Linux Leak rev 399672 ... 399675 commit 25b80cbe4c4641df95aabd1b6cac2bdbaa8d1c64 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Mon Jun 13 16:00:16 2016 -0700 Auto-rebaseline for r399532 https://chromium.googlesource.com/chromium/src/+/4fd93e539 BUG= 254639 TBR=enne@chromium.org Review URL: https://codereview.chromium.org/2060753003 . Cr-Commit-Position: refs/heads/master@{#399591} commit 4fd93e539bd8fdc3a42d1ba5f5bfe9acd9bbd949 Author: enne <enne@chromium.org> Date: Mon Jun 13 14:00:03 2016 -0700 Optimize render passes with single quads Many effects (masks, replicas, filters) generate render passes for simplicity in the code. However, in the cases where the pass contains a single quad with a texture, that resulting texture could just be used as the input texture instead of the render pass itself. The complication is mostly that render passes and tile textures are flipped relative to each other (oops) and so some knowledge of this has to leak into drawing render passes. This is done by detecting such render passes inside of DirectRenderer, storing the TileQuad that would have been drawn, skipping allocating the pass and rendering it, and then calling a slightly modified version of DrawRenderPassQuad with the TileQuad's resource. The check for which render passes can be supported is conservative to start. This optimization usually will not be supported on mac because skia does not support textures with texture rectangle targets as input. BUG= 254639 , 606672 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ff3dc65b0f7845184458fb25b3d566fa079cd232 Review-Url: https://codereview.chromium.org/1960543002 Cr-Original-Commit-Position: refs/heads/master@{#399060} Cr-Commit-Position: refs/heads/master@{#399532}
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13a1859ee7af2ca08927cb510fa4faef973a5c5d commit 13a1859ee7af2ca08927cb510fa4faef973a5c5d Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Jun 14 21:34:08 2016 Disabling test that may need new Linux baselines BUG= 620097 TBR=hcarmona@chromium.org,enne@chromium.org Review URL: https://codereview.chromium.org/2067773003 . Cr-Commit-Position: refs/heads/master@{#399781} [modify] https://crrev.com/13a1859ee7af2ca08927cb510fa4faef973a5c5d/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 15 2016
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/034c827e46a5067e29eb5da50ab29a98168225cd commit 034c827e46a5067e29eb5da50ab29a98168225cd Author: enne <enne@chromium.org> Date: Thu Jun 16 21:09:17 2016 Manually rebaseline test on precise The rebaseline bot isn't doing the right thing, so rebaseline css3/filters/effect-brightness-hw.html manually using try bot results. BUG= 620097 TBR=senorblanco@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2074783002 Cr-Commit-Position: refs/heads/master@{#400256} [modify] https://crrev.com/034c827e46a5067e29eb5da50ab29a98168225cd/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/034c827e46a5067e29eb5da50ab29a98168225cd/third_party/WebKit/LayoutTests/platform/linux-precise/css3/filters/effect-brightness-hw-expected.png
,
May 8 2017
,
Jan 24 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 14 2016