Touchbot tweaks for Allion
Reported by
charliemooney@chromium.org,
Jun 14 2016
|
||||||||||||
Issue descriptionWe've just set up a touchbot for Allion Labs. When setting it up there were a few tweaks needed to get it running in tip-top shape. This bug can be sued to track them.
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touch_firmware_test/+/f94830332af4188d6d84f4349d1d773bc55fb973 commit f94830332af4188d6d84f4349d1d773bc55fb973 Author: Charlie Mooney <charliemooney@chromium.org> Date: Tue Jun 14 22:35:53 2016 Add timestamps to test results This CL adds a timestamp to each gesture that appears in the report. This can be useful for knowing when some anomolus event occured during a test run (such as the network failing, power loss, etc) so you can differentiate which tests occured before the issue and which happened after/during. Especially for the noise test where the order is randomized, this can be useful information. BUG= chromium:620090 TEST=manually tested, the reports look good and the timestamps appear to be accurate Change-Id: I9f4c6bb538b77d09e4b85fb0d0d50681c751a3d7 Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/352593 Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> [modify] https://crrev.com/f94830332af4188d6d84f4349d1d773bc55fb973/report/report.css [modify] https://crrev.com/f94830332af4188d6d84f4349d1d773bc55fb973/report/report.py [modify] https://crrev.com/f94830332af4188d6d84f4349d1d773bc55fb973/tests/test_result.py
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touch_firmware_test/+/ff8b3328789b3a5769fea0069e906c2ef2562c70 commit ff8b3328789b3a5769fea0069e906c2ef2562c70 Author: Charlie Mooney <charliemooney@chromium.org> Date: Tue Jun 14 21:58:12 2016 Add report type to the filename to stop clobbering This CL adds a feature requested by Allion -- instead of simply generating a report that is always called report.html, now the touch firmware test will prepend the "mode" to the filename, generating "full_report.html" "noise_report.html" or "performance_report.html" This way if the operator runs a performance tests, and starts a noise test before copying the report off the disk, it won't be clobbered on accident. Using timestamps/etc could easily end up consuming the entire harddrive if they are not deleted which might result in wasted test runs, so this way they will only clobber the last run of the same MODE, which is a more reasonable thing to clobber. BUG= chromium:620090 TEST=manually tested, the code ran fine and the report filename was as expected. Change-Id: Id02eca7142d827c20c82616fcd41d1ded911f5a9 Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/352631 Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> [modify] https://crrev.com/ff8b3328789b3a5769fea0069e906c2ef2562c70/quickstep_gesture.py [modify] https://crrev.com/ff8b3328789b3a5769fea0069e906c2ef2562c70/main.py
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touch_firmware_test/+/6bde2bb604e85dd6937afc9a004413a5358e028a commit 6bde2bb604e85dd6937afc9a004413a5358e028a Author: Charlie Mooney <charliemooney@chromium.org> Date: Tue Jun 14 21:21:58 2016 Decrease extension speed for Line gestures For some reason the Allion robot was struggling to extend both finger at the same time when using a dual-finger tip. In the brief pause between issuing the commands to extend each finger (has to send them one at a time) the first finger was getting too far ahead of the second, causing them to jam because they need to remain parallel since they're connected by a shared fingertip. This CL reduces the speed at which they extend. This means the first finger can't get so far ahead in the brief period of time before the second finger starts moving. This prevents the jamming from happening, and really only slows down the gestures a negligible amount. BUG= chromium:620090 TEST=We used this new speed for all of our testing at Allion and it cleared up the issue just fine. Change-Id: I190a919707fdd61e3a52043fdc04b5cb55ec699e Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/352640 Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> [modify] https://crrev.com/6bde2bb604e85dd6937afc9a004413a5358e028a/touchbot/touchbot.py
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touch_firmware_test/+/8e1335aa321f11a6b9a9eb67c0b055cc1b1d166e commit 8e1335aa321f11a6b9a9eb67c0b055cc1b1d166e Author: Charlie Mooney <charliemooney@chromium.org> Date: Fri Jun 24 15:58:43 2016 Change touch FW noise test to 10Vpp Our spec only requires touch devices to pass for electrical noise <= 10Vpp, but we've been testing it at 20Vpp for good measure. For the sake of simplicity and so we don't have to keep explaining why what's going on to people, we should just change it to 10Vpp. It more obviously tests our spec that way. BUG= chromium:620090 TEST=manually tested Change-Id: I192ba874f83b2f2dcf0caea8b6281942198cc382 Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/356010 Reviewed-by: Shyh-In Hwang <josephsih@chromium.org> [modify] https://crrev.com/8e1335aa321f11a6b9a9eb67c0b055cc1b1d166e/tests/constants.py
,
Jun 29 2016
This is the last of the tweaks we had lined up for Allion. I'll go let them know there's a new version availible with their updates. Closing this bug now.
,
Jul 1 2016
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/touch_firmware_test/+/1973ced7b023bdb4d095dff3e779bb4afacfe4f4 commit 1973ced7b023bdb4d095dff3e779bb4afacfe4f4 Author: Charlie Mooney <charliemooney@chromium.org> Date: Thu Jun 30 15:00:50 2016 Restore GV.NOISE_AMPLITUDES Previously the list GV.NOISE_AMPLITUDES was accidentally removed. This is a required constant, so we need to add it back in. BUG= chromium:620090 TEST=manually tested Change-Id: I6496574c65889843719da72d3bc461f73c00790a Signed-off-by: Charlie Mooney <charliemooney@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/357810 [modify] https://crrev.com/1973ced7b023bdb4d095dff3e779bb4afacfe4f4/tests/constants.py
,
Aug 29 2016
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 15 2016