New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 620067 link

Starred by 2 users
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Nov 2016
Cc:
█ kbr@chromium.org
geoffl...@chromium.org
zmo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 295792
issue 617249



Sign in to add a comment

WebglConformance.conformance2_textures_misc_texture_npot failing on mac GPU FYI bots.

Project Member Reported by jbau...@chromium.org, Jun 14 2016 
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%20%28Intel%29/builds/13588 and later builds are failing. It seems to be on all macs. Probably caused by https://codereview.chromium.org/2063803002 (or possibly by https://codereview.chromium.org/2062813003 ).



[ RUN      ] WebglConformance.conformance2_textures_misc_texture_npot
(INFO) 2016-06-13 18:38:57,183 cache_temperature.EnsurePageCacheTemperature:55  PageCacheTemperature: any
[26385:1299:0613/183857:FATAL:gles2_cmd_decoder.cc(12441)] Check failed: !requires_luma_blit. 
0   Chromium Framework                  0x00000001095c95e3 _ZN4base5debug10StackTraceC1Ev + 19
1   Chromium Framework                  0x00000001095e8047 _ZN7logging10LogMessageD2Ev + 71
2   Chromium Framework                  0x000000010a660e3b _ZN3gpu5gles216GLES2DecoderImpl16DoCopyTexImage2DEjijiiiii + 1531
3   Chromium Framework                  0x000000010a62be01 _ZN3gpu5gles216GLES2DecoderImpl20HandleCopyTexImage2DEjPKv + 337
4   Chromium Framework                  0x000000010a64d54c _ZN3gpu5gles216GLES2DecoderImpl14DoCommandsImplILb0EEENS_5error5ErrorEjPKviPi + 252
5   Chromium Framework                  0x000000010a60c835 _ZN3gpu13CommandParser15ProcessCommandsEi + 53
6   Chromium Framework                  0x000000010a60d659 _ZN3gpu15CommandExecutor10PutChangedEv + 297
7   Chromium Framework                  0x000000010a7d9517 _ZN3gpu20GpuCommandBufferStub12OnAsyncFlushEijRKNSt3__16vectorIN2ui11LatencyInfoENS1_9allocatorIS4_EEEE + 327
8   Chromium Framework                  0x000000010a7d92b0 _ZN3IPC8MessageTI35GpuCommandBufferMsg_AsyncFlush_MetaNSt3__15tupleIJijNS2_6vectorIN2ui11LatencyInfoENS2_9allocatorIS6_EEEEEEEvE8DispatchIN3gpu20GpuCommandBufferStubESE_vMSE_FvijRKS9_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ + 128
9   Chromium Framework                  0x000000010a7d7837 _ZN3gpu20GpuCommandBufferStub17OnMessageReceivedERKN3IPC7MessageE + 1287
10  Chromium Framework                  0x000000010a7c17ac _ZN3IPC13MessageRouter12RouteMessageERKNS_7MessageE + 140
11  Chromium Framework                  0x000000010a7d0b24 _ZN3gpu10GpuChannel19HandleMessageHelperERKN3IPC7MessageE + 148
12  Chromium Framework                  0x000000010a7d08f4 _ZN3gpu10GpuChannel13HandleMessageERK13scoped_refptrINS_22GpuChannelMessageQueueEE + 708
13  Chromium Framework                  0x000000010a7d34a5 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN3gpu10GpuChannelEFvRK13scoped_refptrINS6_22GpuChannelMessageQueueEEEEEFvPS7_SC_EJNS_7WeakPtrIS7_EESC_EEELb1EFvvEE3RunEPNS0_13BindStateBaseE + 101
14  Chromium Framework                  0x00000001095c9b0b _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 187
15  Chromium Framework                  0x00000001095f8abc _ZN4base11MessageLoop7RunTaskERKNS_11PendingTaskE + 572
16  Chromium Framework                  0x00000001095f8dbc _ZN4base11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE + 44
17  Chromium Framework                  0x00000001095f910b _ZN4base11MessageLoop6DoWorkEv + 299
18  Chromium Framework                  0x00000001095bb253 _ZN4base24MessagePumpCFRunLoopBase7RunWorkEv + 51
19  Chromium Framework                  0x00000001095e927a _ZN4base3mac15CallWithEHFrameEU13block_pointerFvvE + 10
20  Chromium Framework                  0x00000001095bac04 _ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv + 68
21  CoreFoundation                      0x00007fff8f430a01 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
22  CoreFoundation                      0x00007fff8f422b8d __CFRunLoopDoSources0 + 269
23  CoreFoundation                      0x00007fff8f4221bf __CFRunLoopRun + 927
24  CoreFoundation                      0x00007fff8f421bd8 CFRunLoopRunSpecific + 296
25  Chromium Framework                  0x00000001095bb67f _ZN4base20MessagePumpCFRunLoop5DoRunEPNS_11MessagePump8DelegateE + 79
26  Chromium Framework                  0x00000001095bb08f _ZN4base24MessagePumpCFRunLoopBase3RunEPNS_11MessagePump8DelegateE + 127
27  Chromium Framework                  0x00000001095f8617 _ZN4base11MessageLoop10RunHandlerEv + 215
28  Chromium Framework                  0x0000000109618a83 _ZN4base7RunLoop3RunEv + 51
29  Chromium Framework                  0x00000001095f78a7 _ZN4base11MessageLoop3RunEv + 103
30  Chromium Framework                  0x0000000109565287 _ZN7content7GpuMainERKNS_18MainFunctionParamsE + 3815
31  Chromium Framework                  0x0000000109572cf2 _ZN7content21ContentMainRunnerImpl3RunEv + 802
32  Chromium Framework                  0x0000000109571d36 _ZN7content11ContentMainERKNS_17ContentMainParamsE + 54
33  Chromium Framework                  0x0000000108f52b6a ChromeMain + 58
34  Chromium Helper                     0x0000000108eebd62 main + 530
35  Chromium Helper                     0x0000000108eebb44 start + 52
36  ???                                 0x000000000000001a 0x0 + 26

Comment 1 by erikc...@chromium.org, Jun 14 2016

Cc: kbr@chromium.org zmo@chromium.org geoffl...@chromium.org
It looks like this DCHECK was newly added by:
https://codereview.chromium.org/2027703003

I think that if requires_luma_blit is true, we shouldn't even bother trying to use the workaround, which is for a bug in copyTexImage2D, but instead use the blit logic.

Comment 2 by kbr@chromium.org, Jun 14 2016

Blocking: 581777 617249

Comment 3 by erikc...@chromium.org, Jun 15 2016 

Hm. My patch is failing on the bots. I'll have to dig more when I get back:

"""
[ RUN      ] WebglConformance.deqp_functional_gles3_texturespecification_basic_copyteximage2d
(INFO) 2016-06-14 17:43:05,982 cache_temperature.EnsurePageCacheTemperature:55  PageCacheTemperature: any
[7997:1287:0614/174311:INFO:CONSOLE(11)] "specification.basic_copyteximage2d.cube_rgb: Image comparison failed", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.2d_alpha", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.2d_luminance", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.2d_luminance_alpha", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.2d_rgb", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.2d_rgba", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.cube_alpha", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.cube_luminance", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.cube_luminance_alpha", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.cube_rgb", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "FAIL specification.basic_copyteximage2d.cube_rgb: Image comparison failed", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "specification.basic_copyteximage2d.cube_rgb: Verification failed", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "FAIL specification.basic_copyteximage2d.cube_rgb: Verification failed", source:  (11)
[7997:1287:0614/174311:INFO:CONSOLE(11)] "Init testcase: specification.basic_copyteximage2d.cube_rgba", source:  (11)
[7997:1287:0614/174312:INFO:CONSOLE(11)] "specification.basic_copyteximage2d.cube_rgba: Image comparison failed", source:  (11)
[7997:1287:0614/174312:INFO:CONSOLE(11)] "FAIL specification.basic_copyteximage2d.cube_rgba: Image comparison failed", source:  (11)
[7997:1287:0614/174312:INFO:CONSOLE(11)] "specification.basic_copyteximage2d.cube_rgba: Verification failed", source:  (11)
[7997:1287:0614/174312:INFO:CONSOLE(11)] "FAIL specification.basic_copyteximage2d.cube_rgba: Verification failed", source:  (11)
Traceback (most recent call last):
  File "/b/swarm_slave/work/isolated/isolated_run5bye40/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 84, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/swarm_slave/work/isolated/isolated_run5bye40/content/test/gpu/gpu_tests/gpu_test_base.py", line 122, in RunStory
    RunStoryWithRetries(DesktopGpuSharedPageState, self, results)
  File "/b/swarm_slave/work/isolated/isolated_run5bye40/content/test/gpu/gpu_tests/gpu_test_base.py", line 72, in RunStoryWithRetries
    super(cls, shared_page_state).RunStory(results)
  File "/b/swarm_slave/work/isolated/isolated_run5bye40/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 308, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/swarm_slave/work/isolated/isolated_run5bye40/content/test/gpu/gpu_tests/webgl_conformance.py", line 87, in ValidateAndMeasurePage
    raise page_test.Failure(_WebGLTestMessages(tab))
Failure: specification.basic_copyteximage2d.cube_rgb: Image comparison failed
Init testcase: specification
Init testcase: specification.basic_copyteximage2d.2d_alpha
Init testcase: specification.basic_copyteximage2d.2d_luminance
Init testcase: specification.basic_copyteximage2d.2d_luminance_alpha
Init testcase: specification.basic_copyteximage2d.2d_rgb
Init testcase: specification.basic_copyteximage2d.2d_rgba
Init testcase: specification.basic_copyteximage2d.cube_alpha
Init testcase: specification.basic_copyteximage2d.cube_luminance
Init testcase: specification.basic_copyteximage2d.cube_luminance_alpha
Init testcase: specification.basic_copyteximage2d.cube_rgb
FAIL specification.basic_copyteximage2d.cube_rgb: Image comparison failed
specification.basic_copyteximage2d.cube_rgb: Verification failed
FAIL specification.basic_copyteximage2d.cube_rgb: Verification failed
Init testcase: specification.basic_copyteximage2d.cube_rgba
specification.basic_copyteximage2d.cube_rgba: Image comparison failed
FAIL specification.basic_copyteximage2d.cube_rgba: Image comparison failed
specification.basic_copyteximage2d.cube_rgba: Verification failed
FAIL specification.basic_copyteximage2d.cube_rgba: Verification failed
"""
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1474859b3ba1100e4a80802f5a47bdd3934cb0f2

commit 1474859b3ba1100e4a80802f5a47bdd3934cb0f2
Author: erikchen <erikchen@chromium.org>
Date: Wed Jun 15 02:54:18 2016

Do not use IOSurface copyTexImage2D workaround for LUMA formats.

copyTexImage is implemented for LUMA formats using a blit. Thus, there's no need
to use the copyTexImage2D workaround for IOSurfaces.

BUG= 577144 ,  620067 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2068033002
Cr-Commit-Position: refs/heads/master@{#399825}

[modify] https://crrev.com/1474859b3ba1100e4a80802f5a47bdd3934cb0f2/gpu/command_buffer/service/gles2_cmd_decoder.cc

Comment 5 by erikc...@chromium.org, Jun 20 2016

Status: Fixed (was: Assigned)

Comment 6 by erikc...@chromium.org, Jun 20 2016

Status: Assigned (was: Fixed)
The test is still failing on the bots, although I can't repro on 2 different local machines:

WebglConformance.deqp_functional_gles3_texturespecification_basic_copyteximage2d
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%2010.10%20Release%20%28Intel%29/builds/13730

Comment 7 by erikc...@chromium.org, Jun 20 2016 

I was able to repro this problem on a 10.11.5 device using both the Intel and Nvidia GPUs. On the waterfall, the device is 10.10.5, with Intel GPU. 

I'm going to re-enable WebGL Image Chromium, with the WebGL2 test disabled.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dae6cd8ca35eedb1c50d5b209c39a99d7fade48

commit 8dae6cd8ca35eedb1c50d5b209c39a99d7fade48
Author: erikchen <erikchen@chromium.org>
Date: Mon Jun 20 23:03:46 2016

Disable the WebGL2 test basic_copyteximage2d.

It fails when combined with the Image CHROMIUM logic.

BUG= 620067 
TBR=kbr@chromium.org

Review-Url: https://codereview.chromium.org/2087463003
Cr-Commit-Position: refs/heads/master@{#400822}

[modify] https://crrev.com/8dae6cd8ca35eedb1c50d5b209c39a99d7fade48/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 9 by erikc...@chromium.org, Jun 22 2016

Blocking: -581777 295792
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c0d5217753a50181061e61ffb10d61dc3e46c2e

commit 7c0d5217753a50181061e61ffb10d61dc3e46c2e
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Fri Jun 24 04:09:06 2016

Update WebGL2 conformance test expectations

BUG= 483282 ,  620067 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2096533002
Cr-Commit-Position: refs/heads/master@{#401812}

[modify] https://crrev.com/7c0d5217753a50181061e61ffb10d61dc3e46c2e/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/7c0d5217753a50181061e61ffb10d61dc3e46c2e/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Comment 11 by zmo@chromium.org, Nov 5 2016

Status: Fixed (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cfbf38c25339ad797887ab8e5a4f497db9e2da3

commit 4cfbf38c25339ad797887ab8e5a4f497db9e2da3
Author: zmo <zmo@chromium.org>
Date: Sat Nov 12 00:52:16 2016

WebGL2 test expectations update.

BUG=641129, 620067 , 618464 
TEST=webgl2_conformance on mac bots
NOTRY=true
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2492293003
Cr-Commit-Position: refs/heads/master@{#431716}

[modify] https://crrev.com/4cfbf38c25339ad797887ab8e5a4f497db9e2da3/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 13 by lafo...@chromium.org, Jun 20 2017

Components: -Internals>GPU>WebGL Blink>WebGL
►

Sign in to add a comment