New issue
Advanced search Search tips

Issue 620066 link

Starred by 1 user
Status: Fixed
Owner:
caseq@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

DevTools Timeline Trace Provider API Umbrella Bug

Project Member Reported by fgao@google.com, Jun 14 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36

Steps to reproduce the problem:
Feature Request: Adding Timeline Trace Provider API
/**
 * @param {string} categoryName
 * @param {string} categoryTooltip
 * @return {TraceProvider} 
 * @typedef {{onRecordingStarted: Event, onRecordingStopped: Event }} TraceProvider
 */

var traceProvider = chrome.devtools.timeline.addTraceProvider(categoryName, categoryTooltip)

traceProvider.onRecordingStarted.addListener(function() {});
traceProvider.onRecordingStopped.addListener(callback(threadName, eventsArray));

What is the expected behavior?

What went wrong?
Enable new API in Chrome Extension.

Did this work before? N/A 

Chrome version: 51.0.2704.79  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 21.0 r0
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 14 2016

Labels: Hotlist-Google

Comment 2 by pfeldman@chromium.org, Jun 20 2016

Components: -Platform>DevTools Platform>DevTools>Performance
Owner: caseq@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e522b2df678437a318b75c2be936e66fa0e1b827

commit e522b2df678437a318b75c2be936e66fa0e1b827
Author: caseq <caseq@chromium.org>
Date: Sat Jul 16 01:27:18 2016

Timeline: rearrange trace completion logic for better extensibility

This generalize the way we finialize timeline recording so that it's
easier to plug in extension trace providers.

BUG= 620066 

Review-Url: https://codereview.chromium.org/2137213004
Cr-Commit-Position: refs/heads/master@{#405918}

[modify] https://crrev.com/e522b2df678437a318b75c2be936e66fa0e1b827/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html
[modify] https://crrev.com/e522b2df678437a318b75c2be936e66fa0e1b827/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d

commit 22a2fc81054f4a32279ba3bd1ce6feab5e06c70d
Author: caseq <caseq@chromium.org>
Date: Wed Sep 28 03:08:27 2016

DevTools: add an API for extension-supplied trace providers

Original CL by: Michael Gao < fgao@google.com >,
see https://codereview.chromium.org/2128133002/ for history/details.

BUG= 620066 

Review-Url: https://codereview.chromium.org/2375653003
Cr-Commit-Position: refs/heads/master@{#421433}

[modify] https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d/third_party/WebKit/LayoutTests/inspector/extensions/extensions-api-expected.txt
[add] https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d/third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api-expected.txt
[add] https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d/third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api.html
[modify] https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
[modify] https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[add] https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionTraceProvider.js
[modify] https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d/third_party/WebKit/Source/devtools/front_end/extensions/module.json
[modify] https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d/third_party/WebKit/Source/devtools/front_end/externs.js
[modify] https://crrev.com/22a2fc81054f4a32279ba3bd1ce6feab5e06c70d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbcdc87dd794c67cc5dd809e08986ed364681d5c

commit fbcdc87dd794c67cc5dd809e08986ed364681d5c
Author: caseq <caseq@chromium.org>
Date: Thu Dec 15 04:20:42 2016

DevTools: add extension API to contribute trace events to timeline

This introduced a notion of tracing session to chrome.devtools.timeline API
and lets API client to supply a URL of the trace data to append to the flame
chart.

This also includes:

- exposing a check-box for each extension in Timeline toolbar to
    selectively enable extensions;
- extracting Timeline.LoaderClient from TimelineLifecycleDelegate
    so that loader can be re-used outside of the panel;
- create a temp file in TimelineBackingStorage lazily, only when
    data are actually written there;
- changing TimelineController.startRecording() to accept options
    as a struct rather than a bunch of boolean parameters;
- support for dumping a FlameChartDataProvider in tests;
- a new type of events in TimelineFlameChart to support extensions;

BUG= 620066 

Review-Url: https://codereview.chromium.org/2563383003
Cr-Commit-Position: refs/heads/master@{#438734}

[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api-expected.txt
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api.html
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionTraceProvider.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js
[add] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/ExtensionTracingSession.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/module.json
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbcdc87dd794c67cc5dd809e08986ed364681d5c

commit fbcdc87dd794c67cc5dd809e08986ed364681d5c
Author: caseq <caseq@chromium.org>
Date: Thu Dec 15 04:20:42 2016

DevTools: add extension API to contribute trace events to timeline

This introduced a notion of tracing session to chrome.devtools.timeline API
and lets API client to supply a URL of the trace data to append to the flame
chart.

This also includes:

- exposing a check-box for each extension in Timeline toolbar to
    selectively enable extensions;
- extracting Timeline.LoaderClient from TimelineLifecycleDelegate
    so that loader can be re-used outside of the panel;
- create a temp file in TimelineBackingStorage lazily, only when
    data are actually written there;
- changing TimelineController.startRecording() to accept options
    as a struct rather than a bunch of boolean parameters;
- support for dumping a FlameChartDataProvider in tests;
- a new type of events in TimelineFlameChart to support extensions;

BUG= 620066 

Review-Url: https://codereview.chromium.org/2563383003
Cr-Commit-Position: refs/heads/master@{#438734}

[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api-expected.txt
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/LayoutTests/inspector/extensions/extensions-timeline-api.html
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/bindings/TempFile.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionTraceProvider.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/sdk/TracingModel.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/CountersGraph.js
[add] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/ExtensionTracingSession.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/MemoryCountersGraph.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/fbcdc87dd794c67cc5dd809e08986ed364681d5c/third_party/WebKit/Source/devtools/front_end/timeline/module.json

Comment 7 by pfeldman@chromium.org, Oct 4 2017

Status: Archived (was: Assigned)
Bulk DevTools triage, closing low priority issues with no action plan.

Comment 8 by caseq@chromium.org, Sep 2

Status: Fixed (was: Archived)
►

Sign in to add a comment