New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620049 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2016-12-19
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Bottom corners of window are not rounded

Project Member Reported by bettes@chromium.org, Jun 14 2016

Issue description

Ideally, we can mimic the OS corner radius for the two bottom corners. Currently, they are right-angles. 


 
crner.png
13.2 KB View Download
Labels: signin-active-bug

Comment 2 by ew...@chromium.org, Sep 7 2016

Labels: M-55
Cc: rpop@chromium.org
Rachel, This doesn't seem to be a WebUI problem. Could one of Chrome Desktop engineers possibly comment on this?
Rachel, gentle ping on whether one of Chrome Desktop engineers could look into this. Thank you.

Comment 5 by ew...@chromium.org, Nov 16 2016

Labels: -signin-active-bug
Cc: msarda@chromium.org
Owner: ----
Status: Available (was: Assigned)
Marking as available as handing off the User Manager work.

Comment 7 by rpop@chromium.org, Dec 8 2016

Cc: pkasting@chromium.org shrike@chromium.org bsep@chromium.org
Sorry for the slow reply. cc'ing desktop UI folks
This sounds Mac-specific, as at least on Windows, being squared off is native.
Owner: sdy@chromium.org
Status: Assigned (was: Available)
sdy@ - can you take a look at this and see what it will take to round off the window corners on the Mac?

Comment 10 by sdy@chromium.org, Dec 9 2016

Sure thing!

Comment 11 by sdy@chromium.org, Dec 16 2016

Status: Started (was: Assigned)
CL is up:
https://crrev.com/2582793003
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8e923ba5144dd54cf7967c53682741854e0d7cc

commit e8e923ba5144dd54cf7967c53682741854e0d7cc
Author: sdy <sdy@chromium.org>
Date: Fri Dec 16 20:54:27 2016

Fix user manager window's rounded corners by ensuring its content view is layer backed.

BUG= 620049 

Review-Url: https://codereview.chromium.org/2582793003
Cr-Commit-Position: refs/heads/master@{#439184}

[modify] https://crrev.com/e8e923ba5144dd54cf7967c53682741854e0d7cc/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm

Comment 13 by sdy@chromium.org, Dec 16 2016

NextAction: 2016-12-19

Comment 14 by sdy@chromium.org, Jan 5 2017

Status: Fixed (was: Started)

Sign in to add a comment