New issue
Advanced search Search tips

Issue 620045 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature

Blocking:
issue 616244



Sign in to add a comment

Do not use CRWSessionController and WebStateImpl in SessionWindowIOS

Project Member Reported by eugene...@chromium.org, Jun 14 2016

Issue description

These classes are private for web. WebState and NavigationManager should be used instead.
 
Blocking: 616244
Cc: -kkhorimoto@chromium.org
Components: UI>Browser>Sessions
Labels: -Restrict-View-Google -Type-Bug -Pri-2 Pri-3 Type-Feature
Owner: kkhorimoto@chromium.org
Status: Assigned (was: Available)
Kurt is cleaning this up here:
https://codereview.chromium.org/2755823002/diff/40001/ios/chrome/browser/sessions/session_window.h
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8ee9decef09022c19cab0238a80487e96f408d4

commit a8ee9decef09022c19cab0238a80487e96f408d4
Author: kkhorimoto <kkhorimoto@chromium.org>
Date: Tue Mar 21 01:53:58 2017

Moved |openedByDOM| to WebState's CreateParams and public interface.

WebContents::CreateParams also includes opened by DOM information.  Our
interface diverges slightly because web// requires that information to
be exposed, while content// handles that logic internally via render
view hosts.

BUG=454984,  620045 ,  620045 

Review-Url: https://codereview.chromium.org/2755823002
Cr-Commit-Position: refs/heads/master@{#458274}

[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/chrome/browser/sessions/DEPS
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/chrome/browser/sessions/session_window.h
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/chrome/browser/sessions/session_window.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/chrome/browser/sessions/session_window_unittest.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/chrome/browser/sessions/tab_restore_service_delegate_impl_ios.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/chrome/browser/tabs/tab.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/chrome/browser/tabs/tab_unittest.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/navigation/crw_session_controller+private_constructors.h
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/navigation/crw_session_controller.h
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/navigation/crw_session_controller.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/navigation/crw_session_controller_unittest.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/navigation/crw_session_storage_unittest.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/navigation/navigation_manager_impl.h
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/navigation/navigation_manager_impl.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/navigation/navigation_manager_impl_unittest.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/navigation/session_storage_builder.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/public/crw_session_storage.h
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/public/crw_session_storage.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/public/test/fakes/test_web_state.h
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/public/test/fakes/test_web_state.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/public/test/fakes/test_web_state_delegate.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/public/test/web_test_with_web_state.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/public/web_state/web_state.h
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/web_state/ui/crw_web_controller_unittest.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/web_state/web_state.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/web_state/web_state_impl.h
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/web_state/web_state_impl.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/web_state/web_state_impl_unittest.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/webui/crw_web_ui_manager_unittest.mm
[modify] https://crrev.com/a8ee9decef09022c19cab0238a80487e96f408d4/ios/web/webui/web_ui_mojo_inttest.mm

Status: Fixed (was: Started)
This is fixed now

Sign in to add a comment