New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620043 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

blink_perf.canvas failure on Android, Win, Mac Perf bots

Project Member Reported by zh...@chromium.org, Jun 14 2016

Issue description

Android:
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20(2)
https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf%20(2)

Win:
https://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20(4)

Mac:
https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf%20(4)
https://build.chromium.org/p/chromium.perf/builders/Mac%2010.10%20Perf%20(4)
https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf%20(4)
https://build.chromium.org/p/chromium.perf/builders/Mac%20HDD%20Perf%20(4)

Log:

(INFO) 2016-06-14 04:02:29,576 util.WaitFor:97  Continuing to wait 600s for IsJavaScriptExpressionTrue. Elapsed: 303s.
Traceback (most recent call last):
  File "/b/build/slave/Mac_10_10_Perf__4_/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 84, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/build/slave/Mac_10_10_Perf__4_/build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 308, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/build/slave/Mac_10_10_Perf__4_/build/src/tools/perf/benchmarks/blink_perf.py", line 100, in ValidateAndMeasurePage
    tab.WaitForJavaScriptExpression('testRunner.isDone', 600)
  File "/b/build/slave/Mac_10_10_Perf__4_/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 136, in WaitForJavaScriptExpression
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 600s for IsJavaScriptExpressionTrue.
Console output:

 

Comment 2 by zh...@chromium.org, Jun 14 2016

Cc: sigbjo...@opera.com
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b70b7547d75b6e121972c99cc6eaab6e116f2e88

commit b70b7547d75b6e121972c99cc6eaab6e116f2e88
Author: zhenw <zhenw@chromium.org>
Date: Tue Jun 14 20:20:20 2016

Revert of Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also. (patchset #1 id:1 of https://codereview.chromium.org/2069533002/ )

Reason for revert:
This CL makes blink_perf.canvas fail on perf bots. See the bug for details.

BUG= 620043 

Original issue's description:
> Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also.
>
> Followup r399445 and dually have the delayed task that's
> posted to check if the idle task has gone ahead, also keep
> a weak |this| reference. The non-winning CanvasAsyncBlobCreator
> posted main thread tasks can safely be cancelled & dropped if
> a GC happens to go ahead.
>
> R=
> BUG=
>
> Committed: https://crrev.com/c0db5076c1c2b626aec53e2c8023b79e27820959
> Cr-Commit-Position: refs/heads/master@{#399675}

TBR=haraken@chromium.org,sigbjornf@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2062243003
Cr-Commit-Position: refs/heads/master@{#399775}

[modify] https://crrev.com/b70b7547d75b6e121972c99cc6eaab6e116f2e88/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b70b7547d75b6e121972c99cc6eaab6e116f2e88

commit b70b7547d75b6e121972c99cc6eaab6e116f2e88
Author: zhenw <zhenw@chromium.org>
Date: Tue Jun 14 20:20:20 2016

Revert of Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also. (patchset #1 id:1 of https://codereview.chromium.org/2069533002/ )

Reason for revert:
This CL makes blink_perf.canvas fail on perf bots. See the bug for details.

BUG= 620043 

Original issue's description:
> Have CanvasAsyncBlobCreator's delayed task keep a weak |this| also.
>
> Followup r399445 and dually have the delayed task that's
> posted to check if the idle task has gone ahead, also keep
> a weak |this| reference. The non-winning CanvasAsyncBlobCreator
> posted main thread tasks can safely be cancelled & dropped if
> a GC happens to go ahead.
>
> R=
> BUG=
>
> Committed: https://crrev.com/c0db5076c1c2b626aec53e2c8023b79e27820959
> Cr-Commit-Position: refs/heads/master@{#399675}

TBR=haraken@chromium.org,sigbjornf@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2062243003
Cr-Commit-Position: refs/heads/master@{#399775}

[modify] https://crrev.com/b70b7547d75b6e121972c99cc6eaab6e116f2e88/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp

Comment 5 by zh...@chromium.org, Jun 15 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment