[a11y] opening any vertical dot menu loses focus position in page |
|||||
Issue descriptionbugs: repro steps (I did X and expected Y but Z happened!) 1. open a more actions (i.e. vertical dot) menu at the end of a visit 2. close the menu (with copious Esc presses) what do you expect? well, I expected only 1 Esc to close the menu (like a context menu), but otherwise I also expected my focus position to return to where i was what happened instead? seems like document.body was made the active element instead?
,
Jun 20 2016
,
Jun 22 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9 commit 9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9 Author: tsergeant <tsergeant@chromium.org> Date: Wed Jul 13 05:55:57 2016 MD WebUI: Reimplement cr-shared-menu using iron-dropdown. This change brings the implementation much closer to that of paper-menu-button, and fixes a number of longstanding bugs. In particular, * Focus is correctly restored to the element which opened the menu after the menu is closed. * It is only necessary to press escape once to close the menu. * It is possible to close the menu by clicking anywhere else on the page. * Tab focusing is trapped inside the menu, rather than allowing tab to go to a different part of the page. * Bold text is no longer applied the menu item which was last clicked. The main trade-off of this approach is that we now have to use neon-animation to animate the menu out, and due to the way that the menu is positioned it will animate in from the top-left corner (the same as paper-menu-button). BUG= 589362 , 603454 , 616074 , 619839 , 620038 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2104013004 Cr-Commit-Position: refs/heads/master@{#405048} [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [add] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/md_history/history_overflow_menu_test.js [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/compiled_resources2.gyp [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.html [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9 commit 9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9 Author: tsergeant <tsergeant@chromium.org> Date: Wed Jul 13 05:55:57 2016 MD WebUI: Reimplement cr-shared-menu using iron-dropdown. This change brings the implementation much closer to that of paper-menu-button, and fixes a number of longstanding bugs. In particular, * Focus is correctly restored to the element which opened the menu after the menu is closed. * It is only necessary to press escape once to close the menu. * It is possible to close the menu by clicking anywhere else on the page. * Tab focusing is trapped inside the menu, rather than allowing tab to go to a different part of the page. * Bold text is no longer applied the menu item which was last clicked. The main trade-off of this approach is that we now have to use neon-animation to animate the menu out, and due to the way that the menu is positioned it will animate in from the top-left corner (the same as paper-menu-button). BUG= 589362 , 603454 , 616074 , 619839 , 620038 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2104013004 Cr-Commit-Position: refs/heads/master@{#405048} [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [add] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/md_history/history_overflow_menu_test.js [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/compiled_resources2.gyp [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.html [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
,
Jul 14 2016
Closing the menu will now return focus to the menu button which opened it.
,
Oct 31 2016
verified on 56.0.2903.0 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dbeam@chromium.org
, Jun 14 2016