Old text-decoration isn't erased when animated using CSS |
|||||
Issue descriptionVersion: Observed in 51.0.2704.84 OS: Linux What steps will reproduce the problem? (1) See https://jsfiddle.net/ericwilligers/tgt9nde6/ (2) When text-decoration is animated using CSS, the earlier text-decoration remains visible. (3) Note this doesn't happen with SMIL. What is the expected output? Only one text-decoration per text element. What do you see instead? The text-decoration from the presentation attribute value supplied in the DOM remains visible, even though text-decoration is animated using CSS.
,
Jun 17 2016
,
Jun 28 2016
,
Jul 28 2016
,
Aug 9 2016
Both text decorations are being drawn each frame. (To make this clear, I have updated the example to animate the font size.) In SVGInlineTextBoxPainter::paintTextFragments, unsigned decorations = style.textDecorationsInEffect(); decorations has more than one of the following bits set: TextDecorationOverline, TextDecorationLineThrough, TextDecorationUnderline
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5243763790094312f18657ffa69c21ba4f613566 commit 5243763790094312f18657ffa69c21ba4f613566 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Aug 10 05:27:48 2016 CSS: animated text-decoration-line overrides inline style The text-decoration-line of an element can add to the inherited text-decoration-line. However, StyleAdjuster::adjustComputedStyle is called both before and after animations are applied, and the text-decoration-line from the inline style (or SVG attribute) was being combined with the text-decoration-line from the CSS or Web Animation. BUG= 620037 Review-Url: https://codereview.chromium.org/2227003002 Cr-Commit-Position: refs/heads/master@{#410966} [add] https://crrev.com/5243763790094312f18657ffa69c21ba4f613566/third_party/WebKit/LayoutTests/animations/text-decoration-expected.html [add] https://crrev.com/5243763790094312f18657ffa69c21ba4f613566/third_party/WebKit/LayoutTests/animations/text-decoration.html [modify] https://crrev.com/5243763790094312f18657ffa69c21ba4f613566/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp [modify] https://crrev.com/5243763790094312f18657ffa69c21ba4f613566/third_party/WebKit/Source/core/style/ComputedStyle.cpp [modify] https://crrev.com/5243763790094312f18657ffa69c21ba4f613566/third_party/WebKit/Source/core/style/ComputedStyle.h
,
Aug 10 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by schenney@chromium.org
, Jun 14 2016