[content/touch] tapping in blank space (i.e. not URL, not controls) should toggle checkbox |
|||||
Issue descriptionbugs: repro steps (I did X and expected Y but Z happened!) 1. click on a visit's time (i.e. 11:59am) or the empty space after the domain what do you expect? well, I don't really know what I expect but I do know that: a) the old history page explicitly takes actions to toggle the checkbox b) probably for touch (cuz otherwise multi-edit may suck there)? what happens instead? nada
,
Jun 15 2016
let's just enable and see who cares about this
,
Oct 6 2016
,
Oct 6 2016
Increasing this to P2. It's a little confusing that since we added keyboard nav, clicking in the empty space highlights the checkbox but doesn't actually check it.
,
Oct 12 2016
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c48ea42d17c96882f244e047cf2e600ba14ec8f5 commit c48ea42d17c96882f244e047cf2e600ba14ec8f5 Author: tsergeant <tsergeant@chromium.org> Date: Wed Nov 02 05:42:39 2016 MD History: Select items when tapping anywhere inside the item This brings the selection/deselection behavior in line with the old History page, which allows selection to be toggled when clicking on any non-interactive part of the item. BUG= 620036 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2409063003 Cr-Commit-Position: refs/heads/master@{#429216} [modify] https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5/chrome/browser/resources/md_history/history_item.html [modify] https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5/chrome/browser/resources/md_history/history_item.js [modify] https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5/chrome/test/data/webui/md_history/history_item_test.js
,
Nov 15 2016
is this fixed now?
,
Nov 15 2016
There's one more small thing to fix, which is that we need to focus the checkbox when this happens.
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b514db4465c955d81bcd26bae62e2062909fa6a commit 1b514db4465c955d81bcd26bae62e2062909fa6a Author: tsergeant <tsergeant@chromium.org> Date: Thu Nov 17 07:03:36 2016 MD History: Focus item checkbox when selecting/deselecting on click Previously, tapping an item would select or deselect item, and would move focus to that item without changing which button or link was focused. This could mean that the checkbox could select while the menu button was focused. This CL ensures that the menu button is always focused after tapping an item. BUG= 620036 Review-Url: https://codereview.chromium.org/2503983002 Cr-Commit-Position: refs/heads/master@{#432794} [modify] https://crrev.com/1b514db4465c955d81bcd26bae62e2062909fa6a/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/1b514db4465c955d81bcd26bae62e2062909fa6a/chrome/browser/resources/md_history/history_item.js [modify] https://crrev.com/1b514db4465c955d81bcd26bae62e2062909fa6a/chrome/test/data/webui/md_history/history_item_test.js
,
Nov 18 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dbeam@chromium.org
, Jun 14 2016