[search/menus] should we show "More from this site" after a user has already clicked it? |
||||
Issue descriptionbugs: repro steps (I did X and expected Y but Z happened!) 1. click "More from this site" to find more things from bacolicio.us 2. view all my delicious bacolicio.us visits 3. click on vertical ... (more actions) button what do you expect? useful options what do you get instead? a "More from this site" option in the menu that doesn't seem to do much (as I'm already viewing "this site") note: this is a feature request because apparently the old history page doesn't do this either. double note: and yes, I get that this menu option could, in theory, be used to re-trigger a search of the same origins and get newer, updated results, but that seems super duper rare.
,
Jun 22 2016
,
Jun 22 2016
I agree that it makes sense to remove the option once you've already filtered to a site (but am happy with it being a P3 for now).
,
Sep 8 2017
,
Oct 30 2017
I'm interested in making a patch for this. Can I start this issue?
,
Oct 30 2017
Please do!
,
Nov 2 2017
Submitted patch https://chromium-review.googlesource.com/c/chromium/src/+/746493 for review. Could you tell me if this is the right direction? Thanks in advance.
,
Nov 3 2017
I leave a comment here for photo attachment. @calamity > I think this is too heavy a hammer. If you search for 'dog', then the 'More from this > site' button should still exist. How about hiding it if searchedTerm is equal to the > domain (which is what gets used as the search term)? As you can see from the attached photo, the result of clicking the "More from this site" option is not only the domain but the whole search result. Is it necessary to searchedTerm is equal to the domain?
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e39a73c2dc635b99b063ef0494bc73bf478eed2 commit 4e39a73c2dc635b99b063ef0494bc73bf478eed2 Author: Kyoungdeok Kwon <kkd927@gmail.com> Date: Wed Nov 08 05:40:05 2017 [MD History] Remove "More from this site" after a user has already clicked it In history page, a "More from this site" option in the menu continues to be displayed even though the option is clicked. It makes sense to hidden the option when once user have already filtered to a site. Bug: 620033 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I76fa44ea49576b0b3467ea90dbea451c79d63d37 Reviewed-on: https://chromium-review.googlesource.com/746493 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#514763} [modify] https://crrev.com/4e39a73c2dc635b99b063ef0494bc73bf478eed2/chrome/browser/resources/md_history/history_list.html [modify] https://crrev.com/4e39a73c2dc635b99b063ef0494bc73bf478eed2/chrome/browser/resources/md_history/history_list.js [modify] https://crrev.com/4e39a73c2dc635b99b063ef0494bc73bf478eed2/chrome/test/data/webui/md_history/history_list_test.js
,
Nov 8 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tsergeant@chromium.org
, Jun 22 2016Status: Assigned (was: Available)