New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 620030 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

[a11y] sidenav tab order is inconsistent

Project Member Reported by dbeam@chromium.org, Jun 14 2016

Issue description

bugs: repro steps (I did X and expected Y but Z happened!)

1. focus "Search history"
2. press Tab (should go to "History" in side nav)
3. press Tab (should (?) go to "CLEAR BROWSING DATA")
4. press shift+Tab

what do you expect?
focus should go back to step 3: "History" (i.e. the previous place it was)

what happens instead?
focus skips to step 2: the "Search history" searchbox
 

Comment 1 by dbeam@chromium.org, Jun 14 2016

Status: Available (was: Untriaged)
Owner: tsergeant@chromium.org
Status: Started (was: Available)
Cc: nyerramilli@chromium.org tkonch...@chromium.org
 Issue 621875  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/105cabbb6d80245ba69e9097013594a03069f8cc

commit 105cabbb6d80245ba69e9097013594a03069f8cc
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jun 30 06:15:10 2016

MD History: Hide sidebar behind toolbar menu button

This hides the sidebar and displays a menu button in the toolbar which
opens it in an overlay drawer on the left side of the screen. Also
updates the sidebar menu to have better tab focusing behavior.

This causes the search field in the toolbar to appear slightly
off-center, this will be fixed in a follow-up patch.

BUG= 608968 , 620030 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2020963002
Cr-Commit-Position: refs/heads/master@{#403098}

[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/chrome/browser/resources/md_history/shared_style.html
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/chrome/browser/resources/md_history/side_bar.html
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/chrome/browser/resources/md_history/side_bar.js
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.js
[modify] https://crrev.com/105cabbb6d80245ba69e9097013594a03069f8cc/ui/webui/resources/cr_elements/icons.html

Status: Fixed (was: Started)
Labels: TE-Verified-53.0.2785.8 TE-Verified-M53
Verified this issue on Windows 7 Ubuntu 14.04 and Mac OS 10.11.5 using chrome latest Dev #53.0.2785.8 by following steps mentioned below.

1. Enabled chrome flag chrome://flags/#enable-md-history
2. Navigated to chrome://history
3. Observed toolbar menu button which hides History, Synced tabs and Clear browsing data menus in the left side of the screen.

Hence adding TE-Verified label
 
MD-HistoryUI.JPG
87.4 KB View Download

Sign in to add a comment