Issue 620014 link

Starred by 1 user

Issue metadata

Status:	Assigned
Owner:	dtrainor@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Android , Chrome
Pri:	3
Type:	Bug
Test-Flaky Test-Disabled

Participants' hotlists:
Flaky-Tests

UndoTabModelTest.testTwoTabs is flaky on Marshmallow Tablet Tester

Project Member Reported by mariakho...@chromium.org, Jun 14 2016

Issue description

Dave, can you triage? Not sure who else knows about undo tab stuff.

https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/4271/steps/Instrumentation%20test%20chrome_public_test_apk/logs/stdio


C 1367.679s Main  [FAIL] org.chromium.chrome.browser.tabmodel.UndoTabModelTest#testTwoTabs:
C 1367.679s Main  java.lang.ClassCastException: android.widget.FrameLayout$LayoutParams cannot be cast to android.support.design.widget.CoordinatorLayout$LayoutParams
C 1367.679s Main  	at android.support.design.widget.CoordinatorLayout.dispatchDependentViewRemoved(CoordinatorLayout.java:1210)
C 1367.679s Main  	at android.support.design.widget.CoordinatorLayout$HierarchyChangeListener.onChildViewRemoved(CoordinatorLayout.java:2599)
C 1367.679s Main  	at android.view.ViewGroup.dispatchViewRemoved(ViewGroup.java:4220)
C 1367.679s Main  	at android.view.ViewGroup.removeViewInternal(ViewGroup.java:4621)
C 1367.679s Main  	at android.view.ViewGroup.removeViewInternal(ViewGroup.java:4576)
C 1367.679s Main  	at android.view.ViewGroup.removeView(ViewGroup.java:4507)
C 1367.679s Main  	at org.chromium.chrome.browser.snackbar.SnackbarView$4.onAnimationEnd(SnackbarView.java:146)
C 1367.679s Main  	at android.animation.AnimatorSet$AnimatorSetListener.onAnimationEnd(AnimatorSet.java:855)
C 1367.679s Main  	at android.animation.ValueAnimator.endAnimation(ValueAnimator.java:1239)
C 1367.679s Main  	at android.animation.ValueAnimator$AnimationHandler.doAnimationFrame(ValueAnimator.java:766)
C 1367.679s Main  	at android.animation.ValueAnimator$AnimationHandler$1.run(ValueAnimator.java:801)
C 1367.679s Main  	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:858)
C 1367.680s Main  	at android.view.Choreographer.doCallbacks(Choreographer.java:670)
C 1367.680s Main  	at android.view.Choreographer.doFrame(Choreographer.java:603)
C 1367.680s Main  	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:844)
C 1367.680s Main  	at android.os.Handler.handleCallback(Handler.java:739)
C 1367.680s Main  	at android.os.Handler.dispatchMessage(Handler.java:95)
C 1367.680s Main  	at android.os.Looper.loop(Looper.java:148)
C 1367.680s Main  	at android.app.ActivityThread.main(ActivityThread.java:5417)
C 1367.680s Main  	at java.lang.reflect.Method.invoke(Native Method)
C 1367.680s Main  	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
C 1367.680s Main  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2675c11e7f3c94ef3468a548e1161c48dff35f69

commit 2675c11e7f3c94ef3468a548e1161c48dff35f69
Author: mariakhomenko <mariakhomenko@chromium.org>
Date: Wed Jun 15 04:02:35 2016

Disable UndoTabModelTest#testTwoTabs on tablets.

The test is flaking.

BUG=620014

Review-Url: https://codereview.chromium.org/2064953003
Cr-Commit-Position: refs/heads/master@{#399831}

[modify] https://crrev.com/2675c11e7f3c94ef3468a548e1161c48dff35f69/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

Comment 2 by donnd@google.com, Nov 16

Cc: dtrainor@chromium.org
Labels: Test-Flaky
Owner: donnd@chromium.org

Pretty flaky on many Android configurations:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testTwoTabs

I'm inclined to try to investigate fixes or workarounds and maybe just limit this to just run on fewer configurations.  I'm sheriff, will work on it a bit.

Comment 3 by donnd@google.com, Nov 17

Looks like this could just be a timeout problem, especially since it's not at all flaky on Android N5 and N5X Swarm configurations.

From the log of a recent failure:
I  589.675s run_tests_on_device(00a2408e0bc440a2)    Error in testTwoTabs(org.chromium.chrome.browser.tabmodel.UndoTabModelTest):
I  589.675s run_tests_on_device(00a2408e0bc440a2)    java.util.concurrent.TimeoutException: waitForCallback timed out!
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:191)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:227)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.chrome.browser.tabmodel.UndoTabModelTest.cancelTabClosureOnUiThread(UndoTabModelTest.java:198)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.chrome.browser.tabmodel.UndoTabModelTest.testTwoTabs(UndoTabModelTest.java:500)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at java.lang.reflect.Method.invoke(Method.java)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
I  589.675s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:124)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.Suite.runChild(Suite.java:128)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.Suite.runChild(Suite.java:27)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:127)
I  589.676s run_tests_on_device(00a2408e0bc440a2)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
I  589.676s run_tests_on_device(00a2408e0bc440a2)

Comment 4 by donnd@google.com, Nov 17

Cc: -dtrainor@chromium.org
Labels: OS-Chrome
Owner: dtrainor@chromium.org

Couldn't figure out a good way to conditionally disable or change the timeout so just sent a CL to completely disable.  https://chromium-review.googlesource.com/c/chromium/src/+/1341151

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b836c828cb5a0f1656076cc874dab603245261b

commit 5b836c828cb5a0f1656076cc874dab603245261b
Author: Donn Denman <donnd@chromium.org>
Date: Mon Nov 19 19:46:35 2018

Disable UndoTabModelTest#testTwoTabs due to flakes

This test is now flaking a lot on all configurations of Android.

BUG=620014

TBR=tdrainer@

Change-Id: Ib32eda48f964ddca7a05cc0ae6de7cf4ec9078b3
Reviewed-on: https://chromium-review.googlesource.com/c/1341151
Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609402}
[modify] https://crrev.com/5b836c828cb5a0f1656076cc874dab603245261b/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/UndoTabModelTest.java

Comment 6 by donnd@google.com, Nov 19

Labels: -Pri-1 Test-Disabled Pri-3

►

Issue 620014 link

Issue metadata

UndoTabModelTest.testTwoTabs is flaky on Marshmallow Tablet Tester

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 15 2016

Comment 1 Deleted

Comment 2 by donnd@google.com, Nov 16

Comment 2 Deleted

Comment 3 by donnd@google.com, Nov 17

Comment 3 Deleted

Comment 4 by donnd@google.com, Nov 17

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Nov 19

Comment 5 Deleted

Comment 6 by donnd@google.com, Nov 19

Comment 6 Deleted

Sign in to add a comment