battor_agent crashes if it receives input immediately after it begins execution |
||||
Issue descriptionOn windows in a cygwin terminal the following command will cause a segfault. echo "StartTracing | ./battor_agent.exe --battor-path=COM4 This is important to fix because it is the same bug that is preventing us from running stable battor_agent runs on the FYI bot https://github.com/catapult-project/catapult/issues/2381.
,
Jun 14 2016
,
Jun 15 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52328d3bf192548208dd14181f76dc63ba2b7512 commit 52328d3bf192548208dd14181f76dc63ba2b7512 Author: charliea <charliea@chromium.org> Date: Wed Jun 15 15:55:34 2016 [battor agent] Make BattOr agent block until the BattOrAgent is created This fixes a crash that would be triggered when a command was sent to the agent very quickly after it started. In this case, battor_agent_bin would try to use the BattOrAgent before it was initialized, resulting in a segfault. BUG= 620010 Review-Url: https://codereview.chromium.org/2062393002 Cr-Commit-Position: refs/heads/master@{#399906} [modify] https://crrev.com/52328d3bf192548208dd14181f76dc63ba2b7512/tools/battor_agent/battor_agent_bin.cc
,
Jun 15 2016
,
Jun 20 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by aschulman@chromium.org
, Jun 14 2016