New issue
Advanced search Search tips

Issue 620004 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 595538



Sign in to add a comment

[Passwords] Cancel and Save buttons on dialog

Project Member Reported by hcarmona@chromium.org, Jun 14 2016

Issue description

Conversation:

hcarmona@:
There is no edit functionality for passwords, we want to remove the "Cancel" and "Save" buttons from the "Edit Passwords" dialog. Yes? Concerns?

bettes@:
I don't agree. As long as there is a dialog, we need to present call to action buttons that allow the user to close the dialog. I'm sure im misunderstanding but If there is no edit functionality, why is there a dialog?

hcarmona@:
Quick reply for removing "save" and "cancel": this functionality doesn't exist right now. The functionality this dialog provides is the ability to show the saved password. If that's not enough to justify the existence of the dialog, then maybe he should remove it and replace "edit" with "show password". WDYT?

vabr@:
Note that this is how passwords.google.com do it. However, it tends to be clumsy due to the tight space: b/29199406.
My understanding of what is now called "Edit" dialogue was that it presents detailed information (full URL, password value, in the near future also, e.g., activity log) about the credential, whereas the list view is just a quick overview (human-readable origin + username).

 
How about we:
1) Rename the "Edit" menu item to "View details"
2) Replace "Save"/"Cancel" buttons with "Done"
3) Make the fields uneditable

Thoughts?
That sounds reasonable to me. We would also need to update the title on the dialog.

Comment 3 by kolos@chromium.org, Jun 15 2016

#1 SGTM as well.

Comment 4 by vabr@chromium.org, Jun 15 2016

Components: UI>Browser>Passwords
Labels: Hotlist-Polish OS-Chrome OS-Linux OS-Mac OS-Windows
I like #1, thanks for filing this bug!
Labels: Hotlist-MD-Settings-PasswordsForms
 Issue 619785  has been merged into this issue.
Owner: hcarmona@chromium.org
Status: Started (was: Available)
Added screenshots for change.

All fields in the dialog are read-only. Copying them still works.
view-password-details.png
14.6 KB View Download
view-passwords-menu.png
3.0 KB View Download

Comment 9 by kolos@chromium.org, Jul 18 2016

Thanks, Hector.  
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20

Cc: -vabr@chromium.org

Sign in to add a comment