[Passwords] Cancel and Save buttons on dialog |
|||||||
Issue descriptionConversation: hcarmona@: There is no edit functionality for passwords, we want to remove the "Cancel" and "Save" buttons from the "Edit Passwords" dialog. Yes? Concerns? bettes@: I don't agree. As long as there is a dialog, we need to present call to action buttons that allow the user to close the dialog. I'm sure im misunderstanding but If there is no edit functionality, why is there a dialog? hcarmona@: Quick reply for removing "save" and "cancel": this functionality doesn't exist right now. The functionality this dialog provides is the ability to show the saved password. If that's not enough to justify the existence of the dialog, then maybe he should remove it and replace "edit" with "show password". WDYT? vabr@: Note that this is how passwords.google.com do it. However, it tends to be clumsy due to the tight space: b/29199406. My understanding of what is now called "Edit" dialogue was that it presents detailed information (full URL, password value, in the near future also, e.g., activity log) about the credential, whereas the list view is just a quick overview (human-readable origin + username).
,
Jun 14 2016
That sounds reasonable to me. We would also need to update the title on the dialog.
,
Jun 15 2016
#1 SGTM as well.
,
Jun 15 2016
I like #1, thanks for filing this bug!
,
Jun 23 2016
,
Jul 13 2016
Issue 619785 has been merged into this issue.
,
Jul 13 2016
,
Jul 15 2016
Added screenshots for change. All fields in the dialog are read-only. Copying them still works.
,
Jul 18 2016
Thanks, Hector.
,
Jul 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d3d99d91597627eb5b2bd6f13d4c89b2bb4352a commit 4d3d99d91597627eb5b2bd6f13d4c89b2bb4352a Author: hcarmona <hcarmona@chromium.org> Date: Mon Jul 18 20:12:49 2016 Fix password detail dialog so it doesn't imply save functionality. Added screenshots in bug. BUG= 620004 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2147933004 Cr-Commit-Position: refs/heads/master@{#406079} [modify] https://crrev.com/4d3d99d91597627eb5b2bd6f13d4c89b2bb4352a/chrome/app/settings_strings.grdp [modify] https://crrev.com/4d3d99d91597627eb5b2bd6f13d4c89b2bb4352a/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html [modify] https://crrev.com/4d3d99d91597627eb5b2bd6f13d4c89b2bb4352a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/4d3d99d91597627eb5b2bd6f13d4c89b2bb4352a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Jul 18 2016
,
Oct 20 2016
Verified on ChromeOS 8872.18.0, 55.0.2883.20
,
Nov 29
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tbuck...@chromium.org
, Jun 14 2016