New issue
Advanced search Search tips

Issue 620002 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 595538
issue 671375



Sign in to add a comment

[Passwords] Auto sign in checkbox

Project Member Reported by hcarmona@chromium.org, Jun 14 2016

Issue description

from bettes@:
auto sign in checkbox goes at the very top, above "access your passwords from any device..." string
 

Comment 1 by vabr@chromium.org, Jun 15 2016

Cc: -vabr@chromium.org
Components: UI>Browser>Passwords
Labels: Hotlist-Polish OS-Chrome OS-Linux OS-Mac OS-Windows
Labels: Hotlist-MD-Settings-PasswordsForms
Issue 631193 has been merged into this issue.
Labels: -Pri-2 Pri-1
Owner: hcarmona@chromium.org
Up'd priority to match the dup'd issue.

Text on checkbox will be the same, unless there are objections:

[ ] Auto Sign-in
Automatically sign in to websites using stored credentials. When the feature is disabled, you will be asked for confirmation every time before signing in to a website.
Yep, text should stay the same!
Screenshot of checkbox.
auto-signin-checkbox.png
44.4 KB View Download
Owner: bettes@chromium.org
Status: Assigned (was: Started)
+bettes for feedback

It's unfortunate how long the line is. I think there should also be more padding on the right side, but let's have Alan confirm.

Comment 8 by bettes@chromium.org, Aug 12 2016

Hey Hector, 

I know this is against pattern, but given how long the string is, can we align the first line of text to the checkbox?

Aside from that, we should
1. allow the text to span full-width
2. As Tom noted, the 20px padding on the RHS isn't being respected on this page. Is this an isolated case or true for other pages as well? 


Untitled-3.png
38.1 KB View Download
Untitled-3.gif
29.5 KB View Download
Owner: hcarmona@chromium.org
Re-assigning to @hcarmona for fixes from #8.

Hector, is there an easy way to check if any other pages are not respecting the 20px padding on the right of the card?
The checkbox label spilling out is an issue that affects all checkboxes whose label gets too long. I've been looking for a good fix.

https://github.com/PolymerElements/paper-checkbox/issues/103

Comment 12 by dbeam@chromium.org, Sep 20 2016

Status: ExternalDependency (was: Assigned)
Blockedon: 671375
Blockedon: -671375
Blocking: 671375
Status: Fixed (was: ExternalDependency)
No longer a check box. No more external dependency. Please file new bug for other layout issues. Attached screenshot.
No Checkbox.png
70.4 KB View Download
Status: Verified (was: Fixed)

Sign in to add a comment