[Passwords] Auto sign in checkbox |
|||||||||
Issue descriptionfrom bettes@: auto sign in checkbox goes at the very top, above "access your passwords from any device..." string
,
Jun 23 2016
,
Jul 25 2016
Issue 631193 has been merged into this issue.
,
Jul 25 2016
Up'd priority to match the dup'd issue. Text on checkbox will be the same, unless there are objections: [ ] Auto Sign-in Automatically sign in to websites using stored credentials. When the feature is disabled, you will be asked for confirmation every time before signing in to a website.
,
Jul 28 2016
Yep, text should stay the same!
,
Aug 9 2016
Screenshot of checkbox.
,
Aug 10 2016
+bettes for feedback It's unfortunate how long the line is. I think there should also be more padding on the right side, but let's have Alan confirm.
,
Aug 12 2016
Hey Hector, I know this is against pattern, but given how long the string is, can we align the first line of text to the checkbox? Aside from that, we should 1. allow the text to span full-width 2. As Tom noted, the 20px padding on the RHS isn't being respected on this page. Is this an isolated case or true for other pages as well?
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/671bc0128ed34a0c7c0095bcbf21fd6759c66275 commit 671bc0128ed34a0c7c0095bcbf21fd6759c66275 Author: hcarmona <hcarmona@chromium.org> Date: Wed Aug 17 19:36:45 2016 Add checkbox to allow auto signing in with a saved password. Screenshot attached to bug. BUG= 620002 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2237533002 Cr-Commit-Position: refs/heads/master@{#412614} [modify] https://crrev.com/671bc0128ed34a0c7c0095bcbf21fd6759c66275/chrome/app/settings_strings.grdp [modify] https://crrev.com/671bc0128ed34a0c7c0095bcbf21fd6759c66275/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/671bc0128ed34a0c7c0095bcbf21fd6759c66275/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html [modify] https://crrev.com/671bc0128ed34a0c7c0095bcbf21fd6759c66275/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html [modify] https://crrev.com/671bc0128ed34a0c7c0095bcbf21fd6759c66275/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js [modify] https://crrev.com/671bc0128ed34a0c7c0095bcbf21fd6759c66275/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Aug 22 2016
Re-assigning to @hcarmona for fixes from #8. Hector, is there an easy way to check if any other pages are not respecting the 20px padding on the right of the card?
,
Aug 22 2016
The checkbox label spilling out is an issue that affects all checkboxes whose label gets too long. I've been looking for a good fix. https://github.com/PolymerElements/paper-checkbox/issues/103
,
Sep 20 2016
,
Jan 6 2017
,
Jan 12 2017
No longer a check box. No more external dependency. Please file new bug for other layout issues. Attached screenshot.
,
Jan 23 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by vabr@chromium.org
, Jun 15 2016Components: UI>Browser>Passwords
Labels: Hotlist-Polish OS-Chrome OS-Linux OS-Mac OS-Windows