New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 620001 link

Starred by 1 user
Status: Fixed
Owner:
amaralp@chromium.org
Closed: Jun 2016
Cc:
█ aelias@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Pressing back when floating popup is active leaves chrome

Project Member Reported by amaralp@chromium.org, Jun 14 2016 
OS: Android M
What steps will reproduce the problem?
(1) Long press on a word (to get the floating popup)
(2) Press the system back button

What is the expected output?
Floating popup disappears along with selection

What do you see instead?
Chrome is hidden (we are taken away from the app and to the home screen)
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e4f3880b0bdbceaed247827240701fe5fde1551

commit 5e4f3880b0bdbceaed247827240701fe5fde1551
Author: amaralp <amaralp@chromium.org>
Date: Wed Jun 15 18:09:32 2016

Press back when floating popup is active backgrounds chrome

Added logic to allow the WebActionMode to know if it is currently visible on the screen.

Changed back press code to check if there is a visible menu and if so clearing it instead of backgrounding chrome.

BUG= 620001 

Review-Url: https://codereview.chromium.org/2064163003
Cr-Commit-Position: refs/heads/master@{#399955}

[modify] https://crrev.com/5e4f3880b0bdbceaed247827240701fe5fde1551/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/5e4f3880b0bdbceaed247827240701fe5fde1551/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Comment 2 by amaralp@chromium.org, Jun 18 2016

Status: Fixed (was: Started)
►

Sign in to add a comment