New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619987 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

LayoutTest failures on Win after libpng upgrade: fast/images/drag-image.html, etc.

Project Member Reported by dmazz...@chromium.org, Jun 14 2016

Issue description

The following LayoutTests are failing on Win7, Win7 (dbg):

fast/images/drag-image.html
fast/images/paint-subrect-grid.html
fast/images/png-color-profile-ignore-gamma.html
fast/images/png-suite/test.html
fast/images/repaint-subrect-grid.html
paint/selection/selection-drag-image-in-iframe.html
svg/dynamic-updates/SVGFEBlendElement-dom-in-attr.html
svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr.html
svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop.html
svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html
virtual/gpu-rasterization/fast/images/drag-image.html
virtual/gpu-rasterization/fast/images/paint-subrect-grid.html
virtual/gpu-rasterization/fast/images/png-color-profile-ignore-gamma.html
virtual/gpu-rasterization/fast/images/png-suite/test.html
virtual/gpu-rasterization/fast/images/repaint-subrect-grid.html

Revision range: 399483 ... 399495

Suspecting r399485:

commit ffdedd97ebaf2df7537a66eb53ac94a2299de6e9
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date:   Mon Jun 13 11:10:40 2016 -0700

    Auto-rebaseline for r399464
    
    https://chromium.googlesource.com/chromium/src/+/8c0ac8d88
    
    BUG= 599917 
    TBR=msarett@google.com
    
    Review URL: https://codereview.chromium.org/2066483003 .
    
    Cr-Commit-Position: refs/heads/master@{#399485}

...which updates libpng:

commit 8c0ac8d882561cca77d5184248708b0ce9c851d4
Author: msarett <msarett@google.com>
Date:   Mon Jun 13 09:17:33 2016 -0700

    Update libpng to 1.6.22
    
    BUG= 599917 
    BUG= 618061 
    
    Review-Url: https://codereview.chromium.org/2021403002
    Cr-Commit-Position: refs/heads/master@{#399464}

 

Comment 1 by msar...@google.com, Jun 14 2016

I've viewed these and they are as expected, just trying to land a rebaseline.
https://codereview.chromium.org/2063873002/

Rebaseline bot seems to be down.

Comment 2 by msar...@google.com, Jun 14 2016

Is there a way to reset these tests?

Comment 3 by msar...@google.com, Jun 14 2016

One the rebaseline bot is running again, I'll mark as NeedsRebaseline.
It looks like the rebaseline bot did update them, but the new expectations didn't match on some Windows bots. I don't really understand much about the rebaseline bot.

Comment 5 by msar...@google.com, Jun 14 2016

Ahh ok I understand.  So it probably makes sense to rebaseline, specifically for Win7.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d880525431ce8b61e12b458f29d81f5978c0d683

commit d880525431ce8b61e12b458f29d81f5978c0d683
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Jun 14 17:57:00 2016

Disabling some LayoutTests on Win after libpng upgrade

BUG= 619987 
TBR=hcarmona@chromium.org,msarett@chromium.org

Review URL: https://codereview.chromium.org/2061263002 .

Cr-Commit-Position: refs/heads/master@{#399745}

[modify] https://crrev.com/d880525431ce8b61e12b458f29d81f5978c0d683/third_party/WebKit/LayoutTests/TestExpectations

I'm seeing a couple more:

WebKit Win7 rev 399483 ... 399495
WebKit Win7 (dbg) rev 399475 ... 399505

svg/W3C-SVG-1.1/masking-path-04-b.svg
svg/W3C-SVG-1.1/filters-blend-01-b.svg

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc0aa04f9667b3ed7dc53ef340e6f19889c87c4

commit 2fc0aa04f9667b3ed7dc53ef340e6f19889c87c4
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Jun 14 21:55:29 2016

Disabling more LayoutTests on Win after libpng upgrade

BUG= 619987 
TBR=hcarmona@chromium.org,msarett@chromium.org

Review URL: https://codereview.chromium.org/2062253002 .

Cr-Commit-Position: refs/heads/master@{#399795}

[modify] https://crrev.com/2fc0aa04f9667b3ed7dc53ef340e6f19889c87c4/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d880525431ce8b61e12b458f29d81f5978c0d683

commit d880525431ce8b61e12b458f29d81f5978c0d683
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Jun 14 17:57:00 2016

Disabling some LayoutTests on Win after libpng upgrade

BUG= 619987 
TBR=hcarmona@chromium.org,msarett@chromium.org

Review URL: https://codereview.chromium.org/2061263002 .

Cr-Commit-Position: refs/heads/master@{#399745}

[modify] https://crrev.com/d880525431ce8b61e12b458f29d81f5978c0d683/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fc0aa04f9667b3ed7dc53ef340e6f19889c87c4

commit 2fc0aa04f9667b3ed7dc53ef340e6f19889c87c4
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Jun 14 21:55:29 2016

Disabling more LayoutTests on Win after libpng upgrade

BUG= 619987 
TBR=hcarmona@chromium.org,msarett@chromium.org

Review URL: https://codereview.chromium.org/2062253002 .

Cr-Commit-Position: refs/heads/master@{#399795}

[modify] https://crrev.com/2fc0aa04f9667b3ed7dc53ef340e6f19889c87c4/third_party/WebKit/LayoutTests/TestExpectations

Components: -Blink Blink>Image
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb7a92cc401f84284843a385de71ec75e306ea1

commit cfb7a92cc401f84284843a385de71ec75e306ea1
Author: msarett <msarett@google.com>
Date: Wed Jun 15 19:30:35 2016

Rebaseline after libpng update

BUG= 599917 
BUG= 619987 

Review-Url: https://codereview.chromium.org/2065413003
Cr-Commit-Position: refs/heads/master@{#399987}

[modify] https://crrev.com/cfb7a92cc401f84284843a385de71ec75e306ea1/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 17 2016

Status: Fixed (was: Assigned)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment