Remove all ios/web exceptions from ios/chrome/browser/native_app_launcher/DEPS file |
||||||
Issue descriptionnative_app_navigation_controller should not use private web// API and should use Navigation Manager instead.
,
Jun 14 2016
,
Jan 26 2017
Moved the used of NavigationManagerImpl from native_app_navigation_controller to native_app_navigation_util*
,
Jan 31 2017
native_app_navigation_controller.mm calls -removeObserver on CRWWebController*, so it needs to include the file. Found by converting to ARC. Updated the DEPS in https://codereview.chromium.org/2664993003
,
Jan 31 2017
,
Mar 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4736030020471fa4dca4eb223925cfdac92267df commit 4736030020471fa4dca4eb223925cfdac92267df Author: eugenebut <eugenebut@chromium.org> Date: Sat Mar 04 02:33:58 2017 Removed CRWWebController dependency from NativeAppNavigationController. Conform NativeAppNavigationController to CRWWebStateObserver instead of CRWWebControllerObserver. BUG= 675005 , 619984 Review-Url: https://codereview.chromium.org/2731443003 Cr-Commit-Position: refs/heads/master@{#454751} [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/BUILD.gn [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/DEPS [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/native_app_launcher/native_app_navigation_controller_unittest.mm [modify] https://crrev.com/4736030020471fa4dca4eb223925cfdac92267df/ios/chrome/browser/tabs/tab.mm
,
Mar 11 2017
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d9e8afb33950f06b047aab296e143e45ab576ce commit 3d9e8afb33950f06b047aab296e143e45ab576ce Author: pkl <pkl@chromium.org> Date: Tue Mar 14 22:48:28 2017 Removed use of CRWSessionController from NativeAppNavigationUtilsTest. Previous implementation uses WebStateImpl, NavigationManagerImpl, and CRWSessionController which are all private. This new version uses a TestNavigationManager that is all "faked". BUG= 619984 Review-Url: https://codereview.chromium.org/2742173002 Cr-Commit-Position: refs/heads/master@{#456873} [delete] https://crrev.com/2221ed2f0b0419b80f184e580ee37b25812ec139/ios/chrome/browser/native_app_launcher/DEPS [modify] https://crrev.com/3d9e8afb33950f06b047aab296e143e45ab576ce/ios/chrome/browser/native_app_launcher/native_app_navigation_util_unittest.mm [modify] https://crrev.com/3d9e8afb33950f06b047aab296e143e45ab576ce/ios/web/public/test/fakes/test_navigation_manager.h [modify] https://crrev.com/3d9e8afb33950f06b047aab296e143e45ab576ce/ios/web/public/test/fakes/test_navigation_manager.mm
,
Mar 14 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by eugene...@chromium.org
, Jun 14 2016