New issue
Advanced search Search tips

Issue 619973 link

Starred by 1 user
Status: Fixed
Owner:
bsep@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 614297



Sign in to add a comment

LayoutTest failures: fast/forms/select/listbox-appearance-basic.html, etc.

Project Member Reported by dmazz...@chromium.org, Jun 14 2016 
The following LayoutTests are failing on multiple bots:
fast/forms/select/listbox-appearance-basic.html
fast/forms/number/number-appearance-spinbutton-disabled-readonly.html
fast/forms/select/menulist-appearance-basic.html

Example failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43252

Revision ranges:
Win7:  (rev 399650 ... 399650)
Win7 (dbg):  (rev 399650 ... 399650)
Linux leak: (rev 399650 ... 399650)
Win10: (rev 399614 ... 399627)
Linux: (rev 399626 ... 399631)
Linux Trusty: (rev 399623 ... 399630)

Suspected change:

commit 91cbc6d7c2f02771ee3640a4b2f3376029b3bab0
Author: bsep <bsep@chromium.org>
Date:   Mon Jun 13 17:51:51 2016 -0700

    Draw nicer arrows when the scrollbar buttons are not square.
    
    Before they would look squished or messed up, but with this patch
    their bounding box is always square so we'll get the nice pixel pyramids
    that we want. This shouldn't change anything visually for the normal
    square scrollbar buttons.
    
    BUG= 614297 
    
    Review-Url: https://codereview.chromium.org/2009733002
    Cr-Commit-Position: refs/heads/master@{#399626}

Comment 1 by bsep@chromium.org, Jun 14 2016 

I'll take a look.

Comment 3 by bsep@chromium.org, Jun 14 2016

Status: Fixed (was: Assigned)
They just need to be rebaselined. Not sure why the CQ didn't catch that. The rebaseline bot is broken (see  crbug.com/574272 ) so I manually rebaselined Windows, and marked Linux for later (since I don't have a Linux machine).
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e52c57c45bbbba429f1c1040097ad21df5646ed9

commit e52c57c45bbbba429f1c1040097ad21df5646ed9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jun 17 05:30:46 2016

NeedsRebaseline for  crbug.com/619973 

BUG= 619973 

Review URL: https://codereview.chromium.org/2076873002 .

Cr-Commit-Position: refs/heads/master@{#400366}

[modify] https://crrev.com/e52c57c45bbbba429f1c1040097ad21df5646ed9/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 17 2016

Labels: merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b79201794b2b69c96e42b7275785f6d4c9d5ca2

commit 5b79201794b2b69c96e42b7275785f6d4c9d5ca2
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Jun 17 19:08:12 2016

Rebaseline non-square scrollbar button tests on Windows. Add NeedsManualRebaseline for Linux since the rebaseline bot is currently broken.

BUG= 619973 
TBR=dmazzoni

Review-Url: https://codereview.chromium.org/2063253002
Cr-Commit-Position: refs/heads/master@{#399770}
(cherry picked from commit dd64c13101faffeb0094dbd5a5bd6dd79f34515c)

Review URL: https://codereview.chromium.org/2078013002 .

Cr-Commit-Position: refs/branch-heads/2743@{#380}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/5b79201794b2b69c96e42b7275785f6d4c9d5ca2/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/5b79201794b2b69c96e42b7275785f6d4c9d5ca2/third_party/WebKit/LayoutTests/platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/5b79201794b2b69c96e42b7275785f6d4c9d5ca2/third_party/WebKit/LayoutTests/platform/win/fast/forms/select/listbox-appearance-basic-expected.png
[modify] https://crrev.com/5b79201794b2b69c96e42b7275785f6d4c9d5ca2/third_party/WebKit/LayoutTests/platform/win/fast/forms/select/menulist-appearance-basic-expected.png
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/419182c2ac6e6c46a6659a428c99aee8954d8f39

commit 419182c2ac6e6c46a6659a428c99aee8954d8f39
Author: Bret Sepulveda <bsep@chromium.org>
Date: Fri Jun 17 19:21:05 2016

Auto-rebaseline for r400366

https://chromium.googlesource.com/chromium/src/+/e52c57c45

BUG= 619973 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2073073002 .

Cr-Commit-Position: refs/heads/master@{#400388}
(cherry picked from commit 757686ec13f667253c9ecc47597e4a8502f720be)

Review URL: https://codereview.chromium.org/2078903003 .

Cr-Commit-Position: refs/branch-heads/2743@{#381}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[delete] https://crrev.com/5b79201794b2b69c96e42b7275785f6d4c9d5ca2/third_party/WebKit/LayoutTests/platform/android/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/419182c2ac6e6c46a6659a428c99aee8954d8f39/third_party/WebKit/LayoutTests/platform/linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png
[modify] https://crrev.com/419182c2ac6e6c46a6659a428c99aee8954d8f39/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/listbox-appearance-basic-expected.png
[modify] https://crrev.com/419182c2ac6e6c46a6659a428c99aee8954d8f39/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select/menulist-appearance-basic-expected.png

Comment 9 by dpranke@chromium.org, Jan 24 2018

Components: Tests>Disabled
Labels: Test-Disabled
►

Sign in to add a comment