New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619967 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Looping vp8 video freezes with Spitzer upon completion of first play through.

Project Member Reported by dalecur...@chromium.org, Jun 14 2016

Issue description

https://i.imgur.com/AvpCJyl.webm

Play/pause become ineffective. Suspend/Resume does nothing. Seen on 53.0.2763.0, haven't tried it on beta yet.
 
render_id: 9
player_id: 0
pipeline_state: kSeeking
event: PLAY
url: http://i.imgur.com/AvpCJyl.webm
total_bytes: 3275319
streaming: false
single_origin: true
passed_cors_access_check: false
range_header_supported: true
info: FFmpegDemuxer: created video stream, config codec: vp8 format: 2 profile: vp8 coded size: [720,404] visible rect: [0,0,720,404] natural size: [720,404] has extra data? false encrypted? false
duration: 15
bitrate: 1746836
coded_height: 0
coded_width: 0
found_audio_stream: false
found_video_stream: true
height: 404
max_duration: 15
start_time: 0
time_base: 1/1000
video_codec_name: vp8
video_format: PIXEL_FORMAT_YV12
video_is_encrypted: false
width: 720
video_dds: false
video_decoder: GpuVideoDecoder

N5X, https://i.imgur.com/AvpCJyl.gifv is another option.
Cc: w...@chromium.org liber...@chromium.org
This is a bug with AVDA I think, it doesn't happen with software decoding path.
Cc: ti...@chromium.org
Summary: Looping vp8 video freezes with Spitzer upon completion of first play through. (was: Looping video freezes with Spitzer upon completion of first play through.)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eec6e9013286349a66ace2ec0858c99e96132f46

commit eec6e9013286349a66ace2ec0858c99e96132f46
Author: dalecurtis <dalecurtis@chromium.org>
Date: Fri Jun 17 03:13:26 2016

Immediately reset for vp8 when there's nothing to flush.

If we finish playback of a clip up to end-of-stream, the codec is
already Flush()'d so when we later recieve a Reset(), if we try
to start another Flush() there is no event-pump driving the flush
and we'll hang forever waiting for the flush that never was.

The fix is to instead only flush when there are actually buffers in
the decoder. If there are no buffers, there is nothing to flush.

BUG= 619967 
TEST=looping video plays

Review-Url: https://codereview.chromium.org/2074983002
Cr-Commit-Position: refs/heads/master@{#400338}

[modify] https://crrev.com/eec6e9013286349a66ace2ec0858c99e96132f46/media/gpu/android_video_decode_accelerator.cc

Labels: -M-53 ReleaseBlock-Stable M-52
Will merge-request to m-52 after soaking.
Labels: Merge-Request-52

Comment 9 by tin...@google.com, Jun 22 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4424a3253f9b1a13799b53e60eb346b3e06c4104

commit 4424a3253f9b1a13799b53e60eb346b3e06c4104
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Jun 22 01:33:02 2016

Merge M52: "Immediately reset for vp8 when there's nothing to flush."

If we finish playback of a clip up to end-of-stream, the codec is
already Flush()'d so when we later recieve a Reset(), if we try
to start another Flush() there is no event-pump driving the flush
and we'll hang forever waiting for the flush that never was.

The fix is to instead only flush when there are actually buffers in
the decoder. If there are no buffers, there is nothing to flush.

BUG= 619967 
TEST=looping video plays

Review-Url: https://codereview.chromium.org/2074983002
Cr-Commit-Position: refs/heads/master@{#400338}
(cherry picked from commit eec6e9013286349a66ace2ec0858c99e96132f46)

Review URL: https://codereview.chromium.org/2084063003 .

Cr-Commit-Position: refs/branch-heads/2743@{#444}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/4424a3253f9b1a13799b53e60eb346b3e06c4104/media/gpu/android_video_decode_accelerator.cc

Status: Fixed (was: Assigned)

Sign in to add a comment