Post git upgrade, this test keeps failing in depot_tools blocking CQ |
|||
Issue description
FAIL: testMove (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tests/checkout_test.py", line 321, in testMove
self.assertEquals(expected, out)
AssertionError: Lists differ: ['A\tchromeos/views/webui_menu... != ['R067\tchromeos/views/DOMui_m...
First differing element 0:
A chromeos/views/webui_menu_widget.h
R067 chromeos/views/DOMui_menu_widget.h chromeos/views/webui_menu_widget.h
First list contains 1 additional elements.
First extra element 1:
D chromeos/views/DOMui_menu_widget.h
+ ['R067\tchromeos/views/DOMui_menu_widget.h\tchromeos/views/webui_menu_widget.h']
- ['A\tchromeos/views/webui_menu_widget.h',
- 'D\tchromeos/views/DOMui_menu_widget.h']
----------------------------------------------------------------------
Ran 4 tests in 2.603s
FAILED (failures=1, skipped=1)
Found unpatched files: ['chromeos/views/DOMui_menu_widget.h']
,
Jun 15 2016
Who did the git upgrade?
,
Jun 16 2016
I believe it's because of https://github.com/blog/2188-git-2-9-has-been-released """ Rename detection is now enabled by default for diffs. You may have heard that Git doesn't record renames. It's true! Git infers on the fly when a file has been renamed by looking for similarities between the contents of the old and new files. This feature, which has existed since the early days of Git, is now enabled by default. [source] """ What used to be D+A in the test has turned into a detected rename. I guess it's fine to just update the test?
,
Jun 16 2016
Yes or add a flag to disable the detection. Whatever that works for everyone.
,
Jun 16 2016
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/f3c688bf2ccbd54a302f69846b97e51c3e2fcc82 commit f3c688bf2ccbd54a302f69846b97e51c3e2fcc82 Author: scottmg <scottmg@chromium.org> Date: Thu Jun 16 00:16:44 2016 Fix presubmit checkout test after git 2.9.0 Quoting https://github.com/blog/2188-git-2-9-has-been-released """Rename detection is now enabled by default for diffs..." which broke this test. R=tandrii@chromium.org, iannucci@chromium.org BUG= 619959 Review-Url: https://codereview.chromium.org/2073553003 [modify] https://crrev.com/f3c688bf2ccbd54a302f69846b97e51c3e2fcc82/tests/checkout_test.py
,
Jun 16 2016
https://codereview.chromium.org/2067653002/ made it through cq.
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/a54265971ed8380214881f80b8d44942b99a2ec4 commit a54265971ed8380214881f80b8d44942b99a2ec4 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Jun 16 00:25:30 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/f3c688bf2ccbd54a302f69846b97e51c3e2fcc82 Fix presubmit checkout test after git 2.9.0 (scottmg@chromium.org) https://crrev.com/0205656321a66c2d2af5b71fad0caaa0f6391c27 drover win: Use --stdin so update-index doesn't fail on long cmdline (scottmg@chromium.org) R=tandrii@chromium.org,iannucci@chromium.org,scottmg@chromium.org BUG= 598808 , 619959 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2073653002 [modify] https://crrev.com/a54265971ed8380214881f80b8d44942b99a2ec4/infra/config/recipes.cfg
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/b3af2b14e935491432f01f9625be093994c77af6 commit b3af2b14e935491432f01f9625be093994c77af6 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Jun 16 00:46:03 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/a54265971ed8380214881f80b8d44942b99a2ec4 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/f3c688bf2ccbd54a302f69846b97e51c3e2fcc82 Fix presubmit checkout test after git 2.9.0 (scottmg@chromium.org) https://crrev.com/0205656321a66c2d2af5b71fad0caaa0f6391c27 drover win: Use --stdin so update-index doesn't fail on long cmdline (scottmg@chromium.org) R=tandrii@chromium.org,iannucci@chromium.org,scottmg@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org,recipe-roller@chromium.org BUG= 598808 , 619959 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2068073003 [modify] https://crrev.com/b3af2b14e935491432f01f9625be093994c77af6/infra/config/recipes.cfg
,
Jun 17 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/f372357a8eadf462ca07a546a8e0793db6a177d9 commit f372357a8eadf462ca07a546a8e0793db6a177d9 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Jun 16 00:28:39 2016 |
|||
►
Sign in to add a comment |
|||
Comment 1 by scottmg@chromium.org
, Jun 15 2016