New issue
Advanced search Search tips

Issue 619942 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

components_unittests no longer links in component+Release

Project Member Reported by gab@chromium.org, Jun 14 2016

Issue description

[1/1] LINK components_unittests.exe
FAILED: components_unittests.exe
D:/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:components_unittests.exe /PDB:components_unittests.exe.pdb @components_unittests.exe.rsp
LINK : fatal error LNK1210: exceeded internal ILK size limit; link with /INCREMENTAL:NO
ninja: build stopped: cannot make progress due to previous errors.
 
Is this gyp or gn? Either way, the exact settings would be useful to make sure we fix the right problem. So, please share the GYP_DEFINES or args.gn.

Previously this type of error would be impossible because we didn't use incremental linking on release builds (IIRC). I know that there was discussion about using incremental linking on all component builds - did that happen? If so then I suspect that the fix is to forcibly disable incremental linking on large targets - this probably includes all of the large test binaries.

Comment 2 by gab@chromium.org, Jun 15 2016

Hmm, weird, it linked today after I synced...

FTR this was with GN:
   is_component_build = true
   is_debug = false
   is_chrome_branded = true
   dcheck_always_on = true
   is_win_fastlink = true
   enable_nacl = false

I'll close for now. It might mean that we're getting close to some threshold and I went back under it after rebuilding all?

Comment 3 by gab@chromium.org, Jun 15 2016

Status: WontFix (was: Assigned)
There has been some churn in this area. Specifically crrev.com/2060983002, crrev.com/2043873004, crrev.com/2063483002, etc.

The basic problem is that source sets tend to lead to unnecessarily long link times on targets that need very few of the .obj file, but .lib files tend to hit file size limits. I suspect that these ILK size limits are being affected by the changes back and forth between source sets and libs.

Sign in to add a comment