components_unittests no longer links in component+Release |
||
Issue description[1/1] LINK components_unittests.exe FAILED: components_unittests.exe D:/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:components_unittests.exe /PDB:components_unittests.exe.pdb @components_unittests.exe.rsp LINK : fatal error LNK1210: exceeded internal ILK size limit; link with /INCREMENTAL:NO ninja: build stopped: cannot make progress due to previous errors.
,
Jun 15 2016
Hmm, weird, it linked today after I synced... FTR this was with GN: is_component_build = true is_debug = false is_chrome_branded = true dcheck_always_on = true is_win_fastlink = true enable_nacl = false I'll close for now. It might mean that we're getting close to some threshold and I went back under it after rebuilding all?
,
Jun 15 2016
,
Jun 16 2016
There has been some churn in this area. Specifically crrev.com/2060983002, crrev.com/2043873004, crrev.com/2063483002, etc. The basic problem is that source sets tend to lead to unnecessarily long link times on targets that need very few of the .obj file, but .lib files tend to hit file size limits. I suspect that these ILK size limits are being affected by the changes back and forth between source sets and libs. |
||
►
Sign in to add a comment |
||
Comment 1 by brucedaw...@chromium.org
, Jun 14 2016