MemoryInfra: support queuing of RequestGlobalDump |
|||||
Issue descriptionBackground context:go/memory-infra: memory profiling in chrome://tracing Today MemoryDumpManager just rejects dump requests if they happen when another request is in progress. This is a blocker for telemetry tests where we want to have periodic dumps + triggered dumps. Petr and I had a quick brainstorming and it seems that the best way around this is just to queue the dumps in tracing_controller_impl and child_memory_dump_manager_delegate_impl.cc Should be a straightforward change. Petr do you have time to try to have give a shoot at this?
,
Jun 15 2016
,
Jun 15 2016
,
Jun 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2868e10408e7fc7d3dba27e813e0ff237869bdee commit 2868e10408e7fc7d3dba27e813e0ff237869bdee Author: petrcermak <petrcermak@chromium.org> Date: Fri Jun 24 15:56:14 2016 [memory-infra] Add support for queueing memory dump requests in the browser process This patch changes TracingControllerImpl to queue global memory dump requests if another dump is in progress (instead of rejecting the requests). The requests are processed in a simple FIFO order. To avoid choking the controller, periodic dump requests are skipped if the queue already contains a (possibly non-periodic) dump request with the same level of detail. Rationale: This is necessary for Telemetry tests which combine periodic and triggered memory dumps. Note: Support for queueing global memory dump requests in child processes will be added in a separate patch. BUG= 619935 Review-Url: https://codereview.chromium.org/2067793004 Cr-Commit-Position: refs/heads/master@{#401865} [modify] https://crrev.com/2868e10408e7fc7d3dba27e813e0ff237869bdee/content/browser/tracing/memory_tracing_browsertest.cc [modify] https://crrev.com/2868e10408e7fc7d3dba27e813e0ff237869bdee/content/browser/tracing/tracing_controller_impl.cc [modify] https://crrev.com/2868e10408e7fc7d3dba27e813e0ff237869bdee/content/browser/tracing/tracing_controller_impl.h
,
Jun 24 2016
,
Jan 4 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by primiano@chromium.org
, Jun 14 2016