New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 619932 link

Starred by 3 users
Status: Fixed
Owner:
█ pe...@opera.com
Email to this user bounced
Closed: Feb 2017
Cc:
dougt@chromium.org
█ pe...@opera.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 510287



Sign in to add a comment

bluetooth: Improve NotFoundError for Services & Characteristics

Project Member Reported by fbeaufort@chromium.org, Jun 14 2016 
When using getPrimaryServices() and getCharacteristics(), it it less clear which service/characteristic can fail to be found. That's why I'm proposing add the UUID in the NotFoundError messages.

SERVICE_NOT_FOUND: "No Services matching 0000fff8-0000-1000-8000-00805f9b34fb UUID found in Device."

CHARACTERISTIC_NOT_FOUND: "No Characteristics matching 0000fff8-0000-1000-8000-00805f9b34fb UUID found in Service with UUID 0000ff02-0000-1000-8000-00805f9b34fb");

Comment 1 by pe...@opera.com, Dec 12 2016

Owner: pe...@opera.com
Status: Started (was: Available)
Something like this? https://codereview.chromium.org/2564283004

Comment 2 by dougt@chromium.org, Jan 29 2017 

It looks like this cl has bitrotted a bunch.  Perja, do you want to update your cl?

Comment 3 by pe...@opera.com, Jan 30 2017 

Whoops, yes, looking into it.

Comment 4 by dougt@chromium.org, Feb 1 2017

Cc: dougt@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b120052928a9adbea3433c206ad659a6197c8600

commit b120052928a9adbea3433c206ad659a6197c8600
Author: perja <perja@opera.com>
Date: Tue Feb 28 13:49:25 2017

bluetooth: show better error messages for services, characteristics and descriptors.

The error message now contains the UUID of the respective service, characteristic or descriptor.

BUG= 619932 

Review-Url: https://codereview.chromium.org/2680783002
Cr-Commit-Position: refs/heads/master@{#453590}

[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/descriptor-not-found.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/device-disconnects-invalidates-objects.js
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/script-tests/server/disconnect-invalidates-objects.js
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/device-disconnects-invalidates-objects.js
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/script-tests/service/disconnect-invalidates-objects.js
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/delayed-discovery-service-not-found.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-device-disconnects-invalidates-objects.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-disconnect-invalidates-objects.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/service-not-found.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/delayed-discovery-service-with-uuid-not-found.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-device-disconnects-invalidates-objects-with-uuid.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-device-disconnects-invalidates-objects.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-disconnect-invalidates-objects-with-uuid.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-disconnect-invalidates-objects.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/services-not-found-with-uuid.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/characteristic-not-found.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-device-disconnects-invalidates-objects.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristic/gen-disconnect-invalidates-objects.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/characteristics-not-found-with-uuid.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-device-disconnects-invalidates-objects-with-uuid.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-device-disconnects-invalidates-objects.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-disconnect-invalidates-objects-with-uuid.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/bluetooth/service/getCharacteristics/gen-disconnect-invalidates-objects.html
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothError.h
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.cpp
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTDescriptor.h
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.h
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.cpp
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTUtils.h
[modify] https://crrev.com/b120052928a9adbea3433c206ad659a6197c8600/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

Comment 6 by pe...@opera.com, Feb 28 2017

Status: Fixed (was: Started)

Comment 7 by pe...@opera.com, Feb 28 2017

Cc: pe...@opera.com
 Issue 676720  has been merged into this issue.
►

Sign in to add a comment