New issue
Advanced search Search tips

Issue 619930 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 79180



Sign in to add a comment

[css-grid] Allow multiple tracks on repeat()

Project Member Reported by r...@igalia.com, Jun 14 2016

Issue description


Now it's possible to have multiple tracks on repeat() function too:
https://github.com/w3c/csswg-drafts/commit/68f08134

We've to implement the new syntax. See: https://drafts.csswg.org/css-grid/#repeat-syntax

 

Comment 1 by svil...@igalia.com, Jun 14 2016

Status: Assigned (was: Available)
I'll take this as I implemented it first in a generic way, back then when I was coding auto-repeat.

Comment 2 by r...@igalia.com, Jun 17 2016

It seems repeat(3, 100px 50px) is already working. :-)

So we would just need to implement this for auto-repeat probaly.

Comment 3 by r...@igalia.com, Jul 20 2016

Owner: svil...@igalia.com
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e06bcde925d051ebdcb42243dc15084d762e17b

commit 5e06bcde925d051ebdcb42243dc15084d762e17b
Author: svillar <svillar@igalia.com>
Date: Wed Jul 20 13:05:48 2016

[css-grid] repeat() syntax should take a <track-list> argument

The repeat() notation used to allow just 1 <track-size> as second argument.
It was recently changed to support <track-list> instead, meaning that we can
pass an arbitrary number of track sizes and line numbers.

It has been working for some time for repeat() if the first argument was
a positive integer, but it requires some changes for the auto repeat cases
(auto-fill and auto-fit).

BUG= 619930 

Review-Url: https://codereview.chromium.org/2161003003
Cr-Commit-Position: refs/heads/master@{#406540}

[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-columns.html
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fit-columns.html
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fit-rows.html
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set.html
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set-expected.txt
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp
[modify] https://crrev.com/5e06bcde925d051ebdcb42243dc15084d762e17b/third_party/WebKit/Source/core/style/GridPositionsResolver.h

Comment 5 by svil...@igalia.com, Jul 21 2016

Status: Fixed (was: Started)

Sign in to add a comment