New issue
Advanced search Search tips

Issue 619923 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 268984



Sign in to add a comment

Refactor EnumerateModulesModel to not use NotificationService

Project Member Reported by chrisha@chromium.org, Jun 14 2016

Issue description

EnumerateModulesModel still uses the deprecated NotificationService. It has exactly one observer, and would be better served with an observer model.
 
Looking at this further, it turns out various bits of the plumbing and blacklist are broken, and other bits simply don't run unless on XP.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8645b5898bbcb15d7886daf5399c923af20b08dc

commit 8645b5898bbcb15d7886daf5399c923af20b08dc
Author: chrisha <chrisha@chromium.org>
Date: Tue Aug 30 18:50:26 2016

[Win] Add reporting of total number of modules loaded in browser process.

BUG=617176, 619923 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2037883004
Cr-Commit-Position: refs/heads/master@{#415375}

[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/chrome_notification_types.h
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/diagnostics/diagnostics_model.cc
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/diagnostics/recon_diagnostics.cc
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/diagnostics/recon_diagnostics.h
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/ui/toolbar/app_menu_icon_controller.cc
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/ui/toolbar/app_menu_icon_controller.h
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/ui/views/conflicting_module_view_win.cc
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/ui/views/conflicting_module_view_win.h
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/ui/webui/conflicts_ui.cc
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/win/enumerate_modules_model.cc
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/win/enumerate_modules_model.h
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/chrome/browser/win/enumerate_modules_model_unittest.cc
[modify] https://crrev.com/8645b5898bbcb15d7886daf5399c923af20b08dc/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment