More menu list of chrome://history page doesn't close on pressing the 'Tab' key.
Reported by
dchau...@etouch.net,
Jun 14 2016
|
|||||
Issue descriptionChrome Version: 53.0.2766.0 (Official Build)e40502b71c9bd4f548118550952afd5d6a158bc4-refs/heads/master@{#399363} 32/64-bit. OS: Windows(7,8,10), Mac (10.10.5)(10.11.4), Linux(Ubuntu 14.04 LTS) Precondition: Enable Material Design history flag from chrome://flags. What steps will reproduce the problem? 1. Launch chrome and go to chrome://history page. 2. Click on More menu icon (three dots) to open menu list. 3. Now, press 'Tab' key from keyboard and observe. Menu list doesn't close on pressing the 'Tab' key from keyboard. Menu list should get closed on pressing the 'Tab' key from keyboard. This is a non-regression issue seen from M-50 series, as this is a new feature introduced from build # 50.0.2638.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/50.0.2637.0..50.0.2638.0?pretty=fuller&n=100 Suspecting: r372589 ? Kindly review the attached screen-cast for reference.
,
Jun 22 2016
,
Jul 5 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9 commit 9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9 Author: tsergeant <tsergeant@chromium.org> Date: Wed Jul 13 05:55:57 2016 MD WebUI: Reimplement cr-shared-menu using iron-dropdown. This change brings the implementation much closer to that of paper-menu-button, and fixes a number of longstanding bugs. In particular, * Focus is correctly restored to the element which opened the menu after the menu is closed. * It is only necessary to press escape once to close the menu. * It is possible to close the menu by clicking anywhere else on the page. * Tab focusing is trapped inside the menu, rather than allowing tab to go to a different part of the page. * Bold text is no longer applied the menu item which was last clicked. The main trade-off of this approach is that we now have to use neon-animation to animate the menu out, and due to the way that the menu is positioned it will animate in from the top-left corner (the same as paper-menu-button). BUG= 589362 , 603454 , 616074 , 619839 , 620038 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2104013004 Cr-Commit-Position: refs/heads/master@{#405048} [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [add] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/md_history/history_overflow_menu_test.js [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/compiled_resources2.gyp [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.html [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9 commit 9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9 Author: tsergeant <tsergeant@chromium.org> Date: Wed Jul 13 05:55:57 2016 MD WebUI: Reimplement cr-shared-menu using iron-dropdown. This change brings the implementation much closer to that of paper-menu-button, and fixes a number of longstanding bugs. In particular, * Focus is correctly restored to the element which opened the menu after the menu is closed. * It is only necessary to press escape once to close the menu. * It is possible to close the menu by clicking anywhere else on the page. * Tab focusing is trapped inside the menu, rather than allowing tab to go to a different part of the page. * Bold text is no longer applied the menu item which was last clicked. The main trade-off of this approach is that we now have to use neon-animation to animate the menu out, and due to the way that the menu is positioned it will animate in from the top-left corner (the same as paper-menu-button). BUG= 589362 , 603454 , 616074 , 619839 , 620038 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2104013004 Cr-Commit-Position: refs/heads/master@{#405048} [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js [add] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/chrome/test/data/webui/md_history/history_overflow_menu_test.js [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/compiled_resources2.gyp [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.html [modify] https://crrev.com/9aecdea1b2386028f8b3ad5e47fd6d98a6add2d9/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js
,
Jul 14 2016
Pressing tab inside the menu now tabs through the menu items, and traps focus inside the menu. Not quite what was mentioned in the original bug, but I'm marking this as Fixed for now. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tkonch...@chromium.org
, Jun 14 2016