Regression: Drop down option doesn't get deselected on toggling checkbox in Gmail
Reported by
lpa...@etouch.net,
Jun 14 2016
|
||||||||||||||
Issue descriptionChrome Version:53.0.2766.0 (Official Build)Revision e40502b71c9bd4f548118550952afd5d6a158bc4-refs/heads/master@{#399363} (32/64-bit) OS: Windows(7,8,8.1,10), Linux (14.04 LTS), Mac(10.10.5, 10.11.4) Test URL: https://mail.google.com/mail/u/0/#inbox Steps: 1. Launch chrome, go to above URL and sign in with valid credentials 2. Select Compose >> More options >> Label >> Create new label. 3. Toggle the checkbox before "Nest label under" and observe the drop down. Actual: On toggling the checkbox the drop down option doesn't get deselected. Expected: On toggling the checkbox the drop down option should perform as per toggle. This is a regression issue seen from 'M-50' and below is the manual regression range. Good build: 50.0.2646.2 Bad build : 50.0.2647.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/a2d73bc7e3205decb9c6dd9732bd102a732b484e..6969673edc422ff98080a1e6ff1fa798425954c6?pretty=fuller&n=1000 Suspecting: r374628? Kindly help to re-assign if your change is not the cause of this issue. Note: Issue is not seen on IE and Firefox.
,
Jun 14 2016
Attached test-case which shows this is an issue with updating the rendering of a selected option when its textContent is set to the empty string. I think it's more likely this is r374629, but that the removed SubtreeStyleChange in that CL revealed this bug.
,
Jun 14 2016
Interestingly, setting option.textContent = "" doesn't update, while option.firstChild.data = "" does.
,
Jun 15 2016
rune, thank you for the reduction. It seems I should own this.
,
Jun 15 2016
Issue 607096 has been merged into this issue.
,
Jun 16 2016
,
Jun 16 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/717d9d1c80c2925b3781b417f9d9ab44fc04bc29 commit 717d9d1c80c2925b3781b417f9d9ab44fc04bc29 Author: tkent <tkent@chromium.org> Date: Fri Jun 17 08:11:16 2016 Menulist SELECT element should update layout when an OPTION content is changed. r374629 exposed this bug. Before r374629, removing OPTION content triggered style recalc and layout for the SELECT element. Now we need to ask for layout manually. BUG= 619837 Review-Url: https://codereview.chromium.org/2075533002 Cr-Commit-Position: refs/heads/master@{#400395} [add] https://crrev.com/717d9d1c80c2925b3781b417f9d9ab44fc04bc29/third_party/WebKit/LayoutTests/fast/forms/select/menulist-emptify-option-expected.html [add] https://crrev.com/717d9d1c80c2925b3781b417f9d9ab44fc04bc29/third_party/WebKit/LayoutTests/fast/forms/select/menulist-emptify-option.html [modify] https://crrev.com/717d9d1c80c2925b3781b417f9d9ab44fc04bc29/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp [modify] https://crrev.com/717d9d1c80c2925b3781b417f9d9ab44fc04bc29/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp [modify] https://crrev.com/717d9d1c80c2925b3781b417f9d9ab44fc04bc29/third_party/WebKit/Source/core/html/HTMLSelectElement.h
,
Jun 19 2016
,
Jun 19 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 21 2016
verified this issue on Win7, Mac OS X 10.11.5, Ubuntu 14.04 using Chrome canary #53.0.2773.0, working as intended. attached screencast for reference and adding TE-verified labels.
,
Jun 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f3dd4e3ced28e039e71257baea326a2501272be commit 7f3dd4e3ced28e039e71257baea326a2501272be Author: Kent Tamura <tkent@chromium.org> Date: Tue Jun 21 04:06:34 2016 Merge "Menulist SELECT element should update layout when an OPTION content is changed." to M52. r374629 exposed this bug. Before r374629, removing OPTION content triggered style recalc and layout for the SELECT element. Now we need to ask for layout manually. BUG= 619837 Review-Url: https://codereview.chromium.org/2075533002 Cr-Commit-Position: refs/heads/master@{#400395} (cherry picked from commit 717d9d1c80c2925b3781b417f9d9ab44fc04bc29) Review URL: https://codereview.chromium.org/2084833002 . Cr-Commit-Position: refs/branch-heads/2743@{#424} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [add] https://crrev.com/7f3dd4e3ced28e039e71257baea326a2501272be/third_party/WebKit/LayoutTests/fast/forms/select/menulist-emptify-option-expected.html [add] https://crrev.com/7f3dd4e3ced28e039e71257baea326a2501272be/third_party/WebKit/LayoutTests/fast/forms/select/menulist-emptify-option.html [modify] https://crrev.com/7f3dd4e3ced28e039e71257baea326a2501272be/third_party/WebKit/Source/core/html/HTMLOptionElement.cpp [modify] https://crrev.com/7f3dd4e3ced28e039e71257baea326a2501272be/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp [modify] https://crrev.com/7f3dd4e3ced28e039e71257baea326a2501272be/third_party/WebKit/Source/core/html/HTMLSelectElement.h
,
Jun 21 2016
just to update, verified this issue on Win7, Mac OS X 10.11.5, Ubuntu 14.04 using Chrome canary #53.0.2774.2, working as intended. |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by lpa...@etouch.net
, Jun 14 2016