New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619829 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 862701
Owner: ----
Closed: Jul 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , All , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: / or Ctrl/Cmd+f should focus in-page search box

Project Member Reported by tbuck...@chromium.org, Jun 14 2016

Issue description

Typing "/" (while not focused on any input) should focus the search box. This is the behavior in the old settings page.
 

Comment 1 by dbeam@chromium.org, Dec 9 2016

Labels: -Pri-2 Pri-3

Comment 2 by dbeam@chromium.org, May 22 2017

Cc: tsergeant@chromium.org dpa...@chromium.org dbeam@chromium.org est...@chromium.org
Labels: -Pri-3 Pri-2
Summary: MD Settings: / or Ctrl/Cmd+f should focus in-page search box (was: [Search] Use "/" to focus search box)
* downloads always hijacks Ctrl/Cmd+f, ignores /
* history hijacks only the first "/" or Ctrl/Cmd+f, ignores subsequent /
* settings doesn't hijack anything

let's make them work the same way.  I vote always hijack Ctrl/Cmd+f because Ctrl/Cmd+g seems to be a good alternative (thanks for pointing this out, tsergeant@!).  I think "/" focusing search box (if it isn't already) also seems fine on all these pages.

Comment 3 by dbeam@chromium.org, May 24 2017

Owner: tbuck...@chromium.org
Status: Assigned (was: Available)
i'd like to get a product opinion on this
ooh, I hadn't noticed the interesting History behavior dbeam pointed out for Ctrl+F:

* if search bar is focused, open browser Find in Page (ignore Ctrl+F)
* else, focus search bar (capture Ctrl+F)

I think I like that. (filed issue 725853 for minor bug with it)
We're now thinking about implementing this for MD Bookmarks.

Are we happy with making it consistent that both Ctrl-F and / focus the search bar (matching the current behavior of History) across all pages that use cr-toolbar?

Comment 6 by dpa...@chromium.org, Jul 12 2017

@tsergeant: Note that this is related to  issue 731467 .

Focusing the search box when Ctrl-F for Settings is reasonable, except when a more dedicated search box exists (passwords, cookies, or the proposed search engines search box), in which case the more specific search box should be focused?

Comment 7 by dpa...@chromium.org, Jul 19 2017

From latest discussion with bettes and tbuckley, it seems that we want "/" to focus the search box, but hijacking ctrl/cmd+f is not desired.

@tbuckley: Can you confirm?
Cc: tbuck...@chromium.org
Owner: dpa...@chromium.org
For consistency with Gmail and other web apps, let's definitely have "/" focus the search box.

Re: Ctrl+F, given the amount of lazy-loading and iron-lists in WebUI the default find-in-page is unlikely to be very helpful compared to the WebUI search boxes. My preference would be to also have Ctrl+F focus the WebUI search box. Though for Settings, we should focus the most specific search box if one exists on the subpage (eg. search engines, passwords, cookies).

We should also make this consistent across WebUI, see  Issue 784164 .
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: ----
Status: Available (was: Assigned)
FYI dbeam@ already landed a mechanism to focus page specific search boxes when ctrl+f is used at https://chromium-review.googlesource.com/c/chromium/src/+/956901.

Unassigning myself, since it is unlikely I'll get to it before M70.
Mergedinto: 862701
Status: Duplicate (was: Available)

Sign in to add a comment