New issue
Advanced search Search tips

Issue 619827 link

Starred by 1 user
Status: Fixed
Owner:
xhw...@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Call SetMediaClientAndroid() in content for browser process

Project Member Reported by xhw...@chromium.org, Jun 14 2016 
Today this is called from content embedders (chrome/aw/cast) which seems to violate layers. Also this caused a lot of duplicate code.

Since we are exposing GetMediaCientAndroid() in ContentClient interface, we should use it to get the client and just set it in content.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12220eaf680404664a9b18982886f589f8a6b7de

commit 12220eaf680404664a9b18982886f589f8a6b7de
Author: xhwang <xhwang@chromium.org>
Date: Fri Jun 17 00:57:39 2016

media: Call SetMediaClientAndroid() in content for browser process

Previously this is called in content embedders like chrome/cast/aw which
resulted in a lot of duplicate code.

BUG= 619827 
TEST=Manually tested and verified MediaClientAndroid is set.

Review-Url: https://codereview.chromium.org/2063123002
Cr-Commit-Position: refs/heads/master@{#400323}

[modify] https://crrev.com/12220eaf680404664a9b18982886f589f8a6b7de/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/12220eaf680404664a9b18982886f589f8a6b7de/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/12220eaf680404664a9b18982886f589f8a6b7de/chrome/browser/chrome_browser_main_android.h
[modify] https://crrev.com/12220eaf680404664a9b18982886f589f8a6b7de/chromecast/browser/cast_browser_main_parts.cc
[modify] https://crrev.com/12220eaf680404664a9b18982886f589f8a6b7de/content/browser/browser_main_loop.cc

Comment 2 by xhw...@chromium.org, Sep 22 2016

Status: Fixed (was: Started)
►

Sign in to add a comment