New issue
Advanced search Search tips

Issue 619813 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 622701



Sign in to add a comment

Correct iOS build for Xcode 8.

Project Member Reported by justincohen@chromium.org, Jun 14 2016

Issue description

Correct iOS build for Xcode 8.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b955cf69c3389d002e9af66b8a4f4ab2b1f49007

commit b955cf69c3389d002e9af66b8a4f4ab2b1f49007
Author: rohitrao <rohitrao@chromium.org>
Date: Tue Jun 14 18:10:22 2016

Updates WKWebViewSecurityUtil to handle deprecated enum values.

BUG= 619813 
TEST=None

Review-Url: https://codereview.chromium.org/2061103003
Cr-Commit-Position: refs/heads/master@{#399748}

[modify] https://crrev.com/b955cf69c3389d002e9af66b8a4f4ab2b1f49007/ios/web/web_state/wk_web_view_security_util.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e850f851231e6bcefcb2ef94643da2976b10c79e

commit e850f851231e6bcefcb2ef94643da2976b10c79e
Author: rohitrao <rohitrao@chromium.org>
Date: Tue Jun 14 18:38:38 2016

Include CoreBluetooth.h from files that need it.

BUG= 619813 
TEST=None

Review-Url: https://codereview.chromium.org/2068753002
Cr-Commit-Position: refs/heads/master@{#399756}

[modify] https://crrev.com/e850f851231e6bcefcb2ef94643da2976b10c79e/base/mac/sdk_forward_declarations.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24886ea4fc3db98eec7b2ca9e3b79d2d6fb335d7

commit 24886ea4fc3db98eec7b2ca9e3b79d2d6fb335d7
Author: justincohen <justincohen@chromium.org>
Date: Tue Jun 14 21:42:04 2016

Roll GTM from 401878 to 03623a.

BUG= 619813 

Review-Url: https://codereview.chromium.org/2069723002
Cr-Commit-Position: refs/heads/master@{#399784}

[modify] https://crrev.com/24886ea4fc3db98eec7b2ca9e3b79d2d6fb335d7/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/0800d52799bb1519d62a3c001da843cf5b213408

commit 0800d52799bb1519d62a3c001da843cf5b213408
Author: justincohen <justincohen@google.com>
Date: Tue Jun 14 22:15:01 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b955cf69c3389d002e9af66b8a4f4ab2b1f49007

commit b955cf69c3389d002e9af66b8a4f4ab2b1f49007
Author: rohitrao <rohitrao@chromium.org>
Date: Tue Jun 14 18:10:22 2016

Updates WKWebViewSecurityUtil to handle deprecated enum values.

BUG= 619813 
TEST=None

Review-Url: https://codereview.chromium.org/2061103003
Cr-Commit-Position: refs/heads/master@{#399748}

[modify] https://crrev.com/b955cf69c3389d002e9af66b8a4f4ab2b1f49007/ios/web/web_state/wk_web_view_security_util.mm

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e850f851231e6bcefcb2ef94643da2976b10c79e

commit e850f851231e6bcefcb2ef94643da2976b10c79e
Author: rohitrao <rohitrao@chromium.org>
Date: Tue Jun 14 18:38:38 2016

Include CoreBluetooth.h from files that need it.

BUG= 619813 
TEST=None

Review-Url: https://codereview.chromium.org/2068753002
Cr-Commit-Position: refs/heads/master@{#399756}

[modify] https://crrev.com/e850f851231e6bcefcb2ef94643da2976b10c79e/base/mac/sdk_forward_declarations.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24886ea4fc3db98eec7b2ca9e3b79d2d6fb335d7

commit 24886ea4fc3db98eec7b2ca9e3b79d2d6fb335d7
Author: justincohen <justincohen@chromium.org>
Date: Tue Jun 14 21:42:04 2016

Roll GTM from 401878 to 03623a.

BUG= 619813 

Review-Url: https://codereview.chromium.org/2069723002
Cr-Commit-Position: refs/heads/master@{#399784}

[modify] https://crrev.com/24886ea4fc3db98eec7b2ca9e3b79d2d6fb335d7/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dec23efb79d7abad4600767df450f67859a199b7

commit dec23efb79d7abad4600767df450f67859a199b7
Author: justincohen <justincohen@chromium.org>
Date: Wed Jun 15 18:44:23 2016

Add missing include for compilation with latest Xcode.

reading_list_model_storage.h needs an #include <vector>.

BUG= 619813 

Review-Url: https://codereview.chromium.org/2074453002
Cr-Commit-Position: refs/heads/master@{#399974}

[modify] https://crrev.com/dec23efb79d7abad4600767df450f67859a199b7/ios/chrome/browser/reading_list/reading_list_model_storage.h

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46a5f7fe6df57d900d80d37fd975535cc5f1ff48

commit 46a5f7fe6df57d900d80d37fd975535cc5f1ff48
Author: rohitrao <rohitrao@chromium.org>
Date: Wed Jun 15 19:12:35 2016

Updates PhysicalWebScanner to use the new CBManagerState enum.

BUG= 619813 ,619982
TEST=None

Review-Url: https://codereview.chromium.org/2066493007
Cr-Commit-Position: refs/heads/master@{#399985}

[modify] https://crrev.com/46a5f7fe6df57d900d80d37fd975535cc5f1ff48/ios/chrome/common/physical_web/physical_web_scanner.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77d381ad11f8a2ffc920d1c0dc11bb46cfd704e9

commit 77d381ad11f8a2ffc920d1c0dc11bb46cfd704e9
Author: justincohen <justincohen@chromium.org>
Date: Thu Jun 16 15:39:38 2016

Correct SecTrustResultType init for latest Xcode beta.

BUG= 619813 

Review-Url: https://codereview.chromium.org/2073663002
Cr-Commit-Position: refs/heads/master@{#400161}

[modify] https://crrev.com/77d381ad11f8a2ffc920d1c0dc11bb46cfd704e9/ios/web/web_state/wk_web_view_security_util_unittest.mm

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c81dff80fe630802d17adc43a73ebf77e43018b

commit 3c81dff80fe630802d17adc43a73ebf77e43018b
Author: justincohen <justincohen@chromium.org>
Date: Thu Jun 16 16:55:45 2016

Work around iossim compile issues on latest Xcode beta.

iossim is broken with the latest Xcode beta.  At least allow it to compile for
now while we look for a solution.

BUG= 619813 , 619982

Review-Url: https://codereview.chromium.org/2066983004
Cr-Commit-Position: refs/heads/master@{#400177}

[modify] https://crrev.com/3c81dff80fe630802d17adc43a73ebf77e43018b/testing/iossim/iossim.mm
[modify] https://crrev.com/3c81dff80fe630802d17adc43a73ebf77e43018b/third_party/class-dump/BUILD.gn
[modify] https://crrev.com/3c81dff80fe630802d17adc43a73ebf77e43018b/third_party/class-dump/class-dump.gyp

Issue 620166 has been merged into this issue.
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/8ed8252bee8b23dc5da2853cca9639371bc95d3f

commit 8ed8252bee8b23dc5da2853cca9639371bc95d3f
Author: justincohen <justincohen@google.com>
Date: Fri Jun 17 22:47:33 2016

Blocking: 622701
Labels: Proj-iOS10
Status: Fixed (was: Assigned)

Sign in to add a comment