The current history page has support for loading a search query from a URL: chrome://history/#q=blah We should support the same URL structure in MD History.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54c31198705504d87135e00e6ff01cb13c853cdc commit 54c31198705504d87135e00e6ff01cb13c853cdc Author: calamity <calamity@chromium.org> Date: Tue Jul 05 02:25:29 2016 [MD History] Add history-list-container between app and history lists. This CL adds a history-list-container element that contains the history list and the grouped history list in order to pull logic out of the app element and in preparation for implementing routing. It also splits apart some of the data model where appropriate so that concerns about the query state and results are separated appropriately. BUG= 619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2084843002 Cr-Commit-Position: refs/heads/master@{#403732} [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/browser/browser_resources.grd [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/browser/resources/md_history/compiled_resources2.gyp [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/browser/resources/md_history/constants.js [add] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/browser/resources/md_history/list_container.html [add] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/browser/resources/md_history/list_container.js [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/browser/resources/md_history/side_bar.html [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/browser/ui/webui/md_history_ui.cc [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/test/data/webui/md_history/history_grouped_list_test.js [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/test/data/webui/md_history/history_item_test.js [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/test/data/webui/md_history/history_list_test.js [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/test/data/webui/md_history/history_overflow_menu_test.js [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/test/data/webui/md_history/history_supervised_user_test.js [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/test/data/webui/md_history/history_synced_tabs_test.js [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/test/data/webui/md_history/history_toolbar_test.js [modify] https://crrev.com/54c31198705504d87135e00e6ff01cb13c853cdc/chrome/test/data/webui/md_history/md_history_browsertest.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b14871b23eeee6453d823cbb0a282df9a39ced5 commit 9b14871b23eeee6453d823cbb0a282df9a39ced5 Author: calamity <calamity@chromium.org> Date: Tue Jul 05 09:13:02 2016 [MD History] Fix issues caused by refactor. This CL fixes a number of issues that were introduced by https://codereview.chromium.org/2084843002/. - Search was broken because queryingDisabled was initialized with a Boolean instead of false. Closure didn't catch it because having getters/setters in an object causes it to give up. - Synced tabs labels were not showing because the search term was not plumbed through correctly. A test has been added to ensure the text is rendered. - The grouped toolbar had no query begin/end time data. The queryResult has been moved into history-app so that the toolbar can access it. BUG= 619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2122823002 Cr-Commit-Position: refs/heads/master@{#403757} [modify] https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5/chrome/browser/resources/md_history/compiled_resources2.gyp [modify] https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5/chrome/browser/resources/md_history/constants.js [modify] https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5/chrome/browser/resources/md_history/list_container.html [modify] https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5/chrome/browser/resources/md_history/list_container.js [modify] https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5/chrome/test/data/webui/md_history/history_grouped_list_test.js [modify] https://crrev.com/9b14871b23eeee6453d823cbb0a282df9a39ced5/chrome/test/data/webui/md_history/history_synced_tabs_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/279f2470f520e8d7dbdd90066d06eac1a25f647d commit 279f2470f520e8d7dbdd90066d06eac1a25f647d Author: calamity <calamity@chromium.org> Date: Wed Jul 13 07:26:56 2016 [MD History] Add 2-way binding to query state. This CL fixes an issue where the query state was not correctly bound to the list container. This caused the loading spinner and message to break. BUG= 619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2126173002 Cr-Commit-Position: refs/heads/master@{#405068} [modify] https://crrev.com/279f2470f520e8d7dbdd90066d06eac1a25f647d/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/279f2470f520e8d7dbdd90066d06eac1a25f647d/chrome/test/data/webui/md_history/history_toolbar_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98fea99c967cbac5cd3959a3726d0a082c1acc93 commit 98fea99c967cbac5cd3959a3726d0a082c1acc93 Author: calamity <calamity@chromium.org> Date: Wed Jul 20 08:15:50 2016 [MD History] Add URL parameter for search. This CL adds routing from the search term in the history toolbar to the URL query. It also rewrites the old history page's #q=search queries into ?q=search to maintain compatibility. BUG= 619799 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2068613002 Cr-Commit-Position: refs/heads/master@{#406515} [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/browser/resources/md_history/list_container.js [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/browser/resources/md_history/side_bar.html [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/browser/resources/md_history/side_bar.js [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/browser/resources/md_history/synced_device_card.html [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/browser/resources/md_history/synced_device_card.js [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/browser/resources/md_history/synced_device_manager.html [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/browser/resources/md_history/synced_device_manager.js [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/test/data/webui/md_history/history_list_test.js [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/test/data/webui/md_history/history_routing_test.js [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/test/data/webui/md_history/history_synced_tabs_test.js [modify] https://crrev.com/98fea99c967cbac5cd3959a3726d0a082c1acc93/chrome/test/data/webui/md_history/md_history_browsertest.js
Comment 1 by bugdroid1@chromium.org
, Jul 5 2016