Missing table headers in Search Engines list |
||||||||||
Issue description(1) Search engine name can wrap onto next line (see YouTube Search in the list), should use ellipsis instead (2) Columns collide with eachother on small screens. @Bettes define padding please. *Note that 1 and 2 are different* (3) Missing table headers, see mocks [1] [1] https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Search.png%3Fz=half&c=show
,
Dec 9 2016
the wrapping has been fixed (by me) the padding should be a little better now as well. i still think we should drop this columnar layout and go with a bunch of rows and subpages (like contents settings' cookie list). column headers is just a bug, assigning to dpapad@.
,
Dec 9 2016
,
Dec 9 2016
,
Jan 31 2017
The column headers existed, and then they were dropped on purpose see https://codereview.chromium.org/1713283002, to match the mocks. I am guessing the mocks have changed since and the ones linked at comment #1 reflect the latest desired look?
,
Feb 9 2017
@tbuckley, @bettes: Can someone verify that the column headers are desired? See previous comment for more context.
,
Feb 13 2017
My preference is certainly for row headers, but I'll let bettes confirm
,
Feb 13 2017
Assigning to @bettes to confirm.
,
Feb 13 2017
bettes says: use chrome://md-settings/autofill or chrome://md-settings/passwords as your guide only put the header on the first table add a "No other search engines found" message when empty
,
Feb 13 2017
,
Feb 14 2017
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13ff49ec46586eb4aa206226dcf3bef5cf02d5b4 commit 13ff49ec46586eb4aa206226dcf3bef5cf02d5b4 Author: dpapad <dpapad@chromium.org> Date: Wed Feb 15 21:19:43 2017 MD Settings: Restore Search engines table headers. BUG= 619790 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2693253002 Cr-Commit-Position: refs/heads/master@{#450800} [modify] https://crrev.com/13ff49ec46586eb4aa206226dcf3bef5cf02d5b4/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html [modify] https://crrev.com/13ff49ec46586eb4aa206226dcf3bef5cf02d5b4/chrome/browser/resources/settings/search_engines_page/search_engine_entry_css.html [modify] https://crrev.com/13ff49ec46586eb4aa206226dcf3bef5cf02d5b4/chrome/browser/resources/settings/search_engines_page/search_engines_list.html [modify] https://crrev.com/13ff49ec46586eb4aa206226dcf3bef5cf02d5b4/chrome/browser/resources/settings/search_engines_page/search_engines_list.js [modify] https://crrev.com/13ff49ec46586eb4aa206226dcf3bef5cf02d5b4/chrome/browser/resources/settings/search_engines_page/search_engines_page.html [modify] https://crrev.com/13ff49ec46586eb4aa206226dcf3bef5cf02d5b4/chrome/test/data/webui/settings/search_engines_page_test.js
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4f09b9a3acecf253d000ee1eca9c84f8556b284 commit b4f09b9a3acecf253d000ee1eca9c84f8556b284 Author: dpapad <dpapad@chromium.org> Date: Thu Feb 16 19:46:33 2017 MD Settings: Display a message when no other search engines exist. BUG= 619790 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2691033008 Cr-Commit-Position: refs/heads/master@{#451060} [modify] https://crrev.com/b4f09b9a3acecf253d000ee1eca9c84f8556b284/chrome/app/settings_strings.grdp [modify] https://crrev.com/b4f09b9a3acecf253d000ee1eca9c84f8556b284/chrome/browser/resources/settings/search_engines_page/search_engines_page.html [modify] https://crrev.com/b4f09b9a3acecf253d000ee1eca9c84f8556b284/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/b4f09b9a3acecf253d000ee1eca9c84f8556b284/chrome/test/data/webui/settings/search_engines_page_test.js
,
Feb 16 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by sheriffbot@chromium.org
, Jun 14 2016