New issue
Advanced search Search tips

Issue 619781 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 431177



Sign in to add a comment

Macviews, GN compile error (duplicate symbol __ZN5views14ViewsTestSuite16RunTestsSeriallyEv)

Project Member Reported by erikc...@chromium.org, Jun 14 2016

Issue description

erikchen@erikchen-macpro ~/projects/chromium/src  (temp86_backtexture_gpu_memory_buffer)$ ninja -C out/gn -j 200 -k 1000 
ninja: Entering directory `out/gn'
[1/2] LINK ./macviews_interactive_ui_tests
FAILED: macviews_interactive_ui_tests 
../../build/toolchain/mac/linker_driver.py /Users/erikchen/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++  -stdlib=libc++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.7 -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -Wl,-pie -o "./macviews_interactive_ui_tests" -Wl,-filelist,"./macviews_interactive_ui_tests.rsp" ./libviews.dylib ./libbase.dylib ./libskia.dylib ./libcompositor.dylib ./libui_base.dylib ./libevents_base.dylib ./libplatform.dylib ./libgeometry.dylib ./libgfx.dylib ./libicui18n.dylib ./libicuuc.dylib ./librange.dylib ./libui_base_ime.dylib ./libdisplay.dylib ./libevents.dylib ./libbase_i18n.dylib ./libipc.dylib ./libui_data_pack.dylib ./libgesture_detection.dylib ./libdevices.dylib ./libcc.dylib ./libgpu.dylib ./libgles2_utils.dylib ./libgl_wrapper.dylib ./libgl_init.dylib ./liburl.dylib ./libcc_proto.dylib ./libprotobuf_lite.dylib ./libcc_surfaces.dylib ./libgl_in_process_context.dylib ./libgles2_c_lib.dylib ./libgles2_implementation.dylib ./libmedia.dylib ./libshared_memory_support.dylib -framework AppKit
duplicate symbol __ZN5views14ViewsTestSuite16RunTestsSeriallyEv in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
duplicate symbol __ZN5views14ViewsTestSuite8RunTestsEv in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
duplicate symbol __ZN5views14ViewsTestSuite8ShutdownEv in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
duplicate symbol __ZN5views14ViewsTestSuite10InitializeEv in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
duplicate symbol __ZN5views14ViewsTestSuiteD2Ev in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
duplicate symbol __ZN5views14ViewsTestSuiteD1Ev in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
duplicate symbol __ZN5views14ViewsTestSuiteD0Ev in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
duplicate symbol __ZN5views14ViewsTestSuiteC2EiPPc in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
duplicate symbol __ZN5views14ViewsTestSuiteC1EiPPc in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
duplicate symbol __ZTVN5views14ViewsTestSuiteE in:
    obj/ui/views/macviews_interactive_ui_tests/views_test_suite.o
    obj/ui/views/test_support_internal/views_test_suite.o
ld: 10 duplicate symbols for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "../../build/toolchain/mac/linker_driver.py", line 186, in <module>
    Main(sys.argv)
  File "../../build/toolchain/mac/linker_driver.py", line 68, in Main
    subprocess.check_call(compiler_driver_args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/Users/erikchen/goma/gomacc', '../../third_party/llvm-build/Release+Asserts/bin/clang++', '-stdlib=libc++', '-arch', 'x86_64', '-isysroot', '/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk', '-mmacosx-version-min=10.7', '-Wl,-rpath,@loader_path/.', '-Wl,-rpath,@loader_path/../../..', '-Wl,-pie', '-o', './macviews_interactive_ui_tests', '-Wl,-filelist,./macviews_interactive_ui_tests.rsp', './libviews.dylib', './libbase.dylib', './libskia.dylib', './libcompositor.dylib', './libui_base.dylib', './libevents_base.dylib', './libplatform.dylib', './libgeometry.dylib', './libgfx.dylib', './libicui18n.dylib', './libicuuc.dylib', './librange.dylib', './libui_base_ime.dylib', './libdisplay.dylib', './libevents.dylib', './libbase_i18n.dylib', './libipc.dylib', './libui_data_pack.dylib', './libgesture_detection.dylib', './libdevices.dylib', './libcc.dylib', './libgpu.dylib', './libgles2_utils.dylib', './libgl_wrapper.dylib', './libgl_init.dylib', './liburl.dylib', './libcc_proto.dylib', './libprotobuf_lite.dylib', './libcc_surfaces.dylib', './libgl_in_process_context.dylib', './libgles2_c_lib.dylib', './libgles2_implementation.dylib', './libmedia.dylib', './libshared_memory_support.dylib', '-framework', 'AppKit']' returned non-zero exit status 1
ninja: build stopped: cannot make progress due to previous errors.
 

Comment 2 by rsesek@chromium.org, Jun 14 2016

Cc: -rsesek@chromium.org tapted@chromium.org
Components: Build
Labels: -Pri-3 OS-Mac Pri-2
Status: Started (was: Assigned)

Comment 3 by rsesek@chromium.org, Jun 14 2016

Owner: rsesek@chromium.org

Comment 4 by rsesek@chromium.org, Jun 15 2016

Blocking: 431177
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63a7fcd115f12a5f955014ab805cae1a6934c432

commit 63a7fcd115f12a5f955014ab805cae1a6934c432
Author: rsesek <rsesek@chromium.org>
Date: Wed Jun 15 16:03:20 2016

[Mac/GN] Remove views_test_suite.cc from macviews_interactive_ui_tests sources.

It is already part of //ui/views:test_support, which is a dependency.

BUG= 619781 , 611324 
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2056313003
Cr-Commit-Position: refs/heads/master@{#399910}

[modify] https://crrev.com/63a7fcd115f12a5f955014ab805cae1a6934c432/ui/views/BUILD.gn

Comment 6 by rsesek@chromium.org, Jun 15 2016

Status: Fixed (was: Started)

Sign in to add a comment