New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 619780 link

Starred by 2 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Jul 2016
Cc:
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[Passwords] Dropdown doesn't close when clicking outside of subpage

Project Member Reported by tbuck...@chromium.org, Jun 14 2016 
Repro:
1) Open the passwords subpage
2) Click a 3-dot menu.
3) Click outside of the subpage on the gray background

Expected: dropdown closes
Actual: dropdown remains open
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abecb7d8378980d3e1ba504a1434566d0b74c69d

commit abecb7d8378980d3e1ba504a1434566d0b74c69d
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Jul 15 01:26:24 2016

MD Settings: Update passwords section for new cr-shared-menu features

Changes plain divs to buttons, which allow the menus to be interacted
with through tab, enter and escape. Also updates the focus trapping in
cr-shared-menu to support hidden menu items.

BUG= 619780 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2142893005
Cr-Commit-Position: refs/heads/master@{#405666}

[modify] https://crrev.com/abecb7d8378980d3e1ba504a1434566d0b74c69d/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/abecb7d8378980d3e1ba504a1434566d0b74c69d/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/abecb7d8378980d3e1ba504a1434566d0b74c69d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/abecb7d8378980d3e1ba504a1434566d0b74c69d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/abecb7d8378980d3e1ba504a1434566d0b74c69d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html
[modify] https://crrev.com/abecb7d8378980d3e1ba504a1434566d0b74c69d/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js

Comment 2 by tsergeant@chromium.org, Jul 15 2016

Owner: tsergeant@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment