New issue
Advanced search Search tips

Issue 619763 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CJK candidate windows doesn't show up after exiting tablet mode

Project Member Reported by songsuk@chromium.org, Jun 14 2016

Issue description

Chrome Version       : 	52.0.2743.39
Platform             :  8350.28.0  -  Minnie, Cyan


What steps will reproduce the problem?
(1) set IME to Pinyin input method (Simplified Chinese)
(2) enter "tian" on input field, and select "1" from  Chinese candidate window
(3) flip the device into tablet mode 
(4) touch on any input field to bring up Virtual keyboard
(5) touch "ti", and select any Chinese character 
(6) exit tablet mode 
(7) enter "tian" on input field again, and check the Chinese candidate window 

What is the expected result?
The candidate window should appear.

What happens instead?
It doesn't show up. 

Please provide any additional information below. Attach a screenshot if
possible.
The candidate window appears after re-signin the user.

Will check the issue on M51, M53
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 14 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: shuchen@chromium.org satorux@chromium.org
satorux@ any chance someone on your team can investigate this one?
Owner: wuyingbing@chromium.org
Status: Assigned (was: Untriaged)
Yingbing, can you please take a look at this? Thanks.
Owner: shuchen@chromium.org
The root cause is when exit tablet mode. OS will close inputview window immediately.
And inputview window doesn't fire "unload" event or the event is fired but there not enough time to send the message to background. (Background doesn't receive the visibility changed event)
I suggest to add new IME API to when the device mode changed.
Owner: azurewei@chromium.org
hi Lan, can you please help to implement a private API so that the issue can be solved in extension JS?

The API could be an event: chrome.virtualKeyboardPrivate.onKeyboardDestroyed().

Project Member

Comment 6 by sheriffbot@chromium.org, Jul 5 2016

Labels: -M-53 -Pri-1 M-54 MovedFrom-53 Pri-2
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/169fcec510510b51122341c9471730f8a7b1c029

commit 169fcec510510b51122341c9471730f8a7b1c029
Author: azurewei <azurewei@chromium.org>
Date: Wed Sep 14 17:31:13 2016

Add virtualKeyboardPrivate.onKeyboardClosed API

The added API will be fired when the virtual keyboard window has been closed, for example, this can happen when turning off on-screen keyboard or exiting tablet mode.

IME extensions rely on input view's visibility changing event to do some work such as hide candidate window. While, when exiting tablet mode, OS will close input view window immediately but doesn't fire 'unload' event, so the IME extensions won't receive the visibility changed event.

Thus, we add this API to notify the extensions the keyboard closed event.

BUG= 619763 
TEST=KeyboardControllerTest.CloseKeyboard

Review-Url: https://codereview.chromium.org/2122873002
Cr-Commit-Position: refs/heads/master@{#418603}

[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/app_list/app_list_presenter_delegate.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/shelf/shelf_layout_manager.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/wm/dock/docked_window_layout_manager.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/wm/dock/docked_window_layout_manager.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/wm/panels/panel_layout_manager.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/wm/panels/panel_layout_manager.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/wm/system_modal_container_layout_manager.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/wm/workspace/workspace_layout_manager.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/common/wm/workspace/workspace_layout_manager.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/wm/lock_layout_manager.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ash/wm/lock_layout_manager.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/chrome/browser/ui/ash/chrome_keyboard_ui.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/components/arc/ime/arc_ime_service.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/components/arc/ime/arc_ime_service.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/extensions/browser/extension_event_histogram_value.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/extensions/common/api/virtual_keyboard_private.json
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ui/keyboard/keyboard_controller_observer.h
[modify] https://crrev.com/169fcec510510b51122341c9471730f8a7b1c029/ui/keyboard/keyboard_controller_unittest.cc

Cc: -shuchen@chromium.org azurewei@chromium.org
Labels: -M-54 -MovedFrom-52 -MovedFrom-53 M-57
Owner: shuchen@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 1 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified on 58.0.3029.51

Sign in to add a comment