New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619754 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

BuildPackages failing on all internal builders

Project Member Reported by steve...@chromium.org, Jun 13 2016

Issue description

All of the chrome (internal) pfq informational builders started failing Mon, Jun 13 around 9:30 am:

https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-chrome-pfq-informational/builds/20309
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chrome-pfq-informational/builds/19641
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/tricky-tot-chrome-pfq-informational/builds/1102
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/peach_pit-tot-chrome-pfq-informational/builds/1746
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/cyan-cheets-tot-chrome-pfq-cheets-informational/builds/175
https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/veyron_minnie-cheets-tot-chrome-pfq-cheets-informational/builds/168

The compile error looks like:

chromeos-chrome-53.0.2767.0_alpha-r1: [61/18392] CC obj/third_party/khronos_glcts/framework/qphelper/qphelper.qpTestLog.o
chromeos-chrome-53.0.2767.0_alpha-r1: FAILED: armv7a-cros-linux-gnueabi-gcc -B/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabi/binutils-bin/2.25.51-gold -MMD -MF obj/third_party/khronos_glcts/framework/qphelper/qphelper.qpTestLog.o.d -DV8_DEPRECATION_WARNINGS '-DDEQP_TARGET_NAME="chrome-gpu-command-buffer"' -DDEQP_SUPPORT_GLES2=1 -DDEQP_SUPPORT_EGL=1 -DGTF_API=GTF_GLES20 -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DENABLE_RLZ -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CRAS=1 -DUSE_OZONE=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DENABLE_WAYLAND_SERVER=1 -DUSE_UDEV -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -D_XOPEN_SOURCE=500 -DQP_SUPPORT_PNG -DUSE_LIBPCI=1 -DUSE_NSS_CERTS=1 -DOS_CHROMEOS=1 -DNDEBUG -DNO_UNWIND_TABLES -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos_glcts/framework/delibs/debase -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos_glcts/framework/delibs/depool -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos_glcts/framework/delibs/dethread -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos_glcts/framework/delibs/deutil -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libpng -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/zlib -pthread -fno-strict-aliasing -Wno-extra -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -g -Wno-unused-local-typedefs -Wno-maybe-uninitialized -march=armv7-a -mtune=generic-armv7-a -mfpu=neon -mfloat-abi=hard -mthumb --sysroot=/build/veyron_minnie-cheets -O2 -fno-ident -fdata-sections -ffunction-sections -fno-unwind-tables -fno-asynchronous-unwind-tables -gsplit-dwarf -pipe -march=armv7-a -mtune=cortex-a15 -mfpu=neon -mfloat-abi=hard  -c ../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos_glcts/framework/qphelper/qpTestLog.c -o obj/third_party/khronos_glcts/framework/qphelper/qphelper.qpTestLog.o
chromeos-chrome-53.0.2767.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos_glcts/framework/qphelper/qpTestLog.c: In function 'pngWriteData':
chromeos-chrome-53.0.2767.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos_glcts/framework/qphelper/qpTestLog.c:656:34: error: dereferencing pointer to incomplete type
chromeos-chrome-53.0.2767.0_alpha-r1:      Buffer* buffer = (Buffer*)png->io_ptr;

I suspect this change since it appears to be png related:

Update libpng to 1.6.22

BUG= 599917 
BUG= 618061 

Review-Url: https://codereview.chromium.org/2021403002
Cr-Commit-Position: refs/heads/master@{#399464}

We need to either revert the change or quickly fix this.

(Note: unfortunately since this only appears to affect chrome (internal) builds, not external chromium builds, it did not show up on the chromium waterfall or trybots. It's an edge case we don't currently have trybot coverage for except in the PFQ informational builders. We should investigate fixing this at some point).



 

Comment 1 by msar...@google.com, Jun 13 2016

I'm working on confirming a fix:
https://chromereviews.googleplex.com/451717013/

I would have already reverted https://codereview.chromium.org/2021403002, but it appears that the change is too large to revert.

Comment 2 by msar...@google.com, Jun 13 2016

celes just built successfully for me, but it appears that it's not on the list of broken builds..

Trying cyan.
Cc: jdufault@chromium.org
Owner: msarett@chromium.org
msarett@ - thanks. I don't know anything about celes, but it's failing on all of the informational builders we have, which are *supposed* to be representative...

Make sure you have USE=chrome_internal


Do we need to roll libpng to get the fix from https://chromereviews.googleplex.com/451717013/? The pfq is still failing to build :(

Comment 5 by msar...@google.com, Jun 14 2016

Yes, the roll is here.  Trying to get it to land.
https://chromereviews.googleplex.com/446457013/

Comment 6 by msar...@google.com, Jun 14 2016

Is someone able to land for me?
https://chromereviews.googleplex.com/446457013/

It looks like I can't commit to the internal repository until I'm a chromium committer.
https://wiki.corp.google.com/twiki/bin/view/Main/ChromeBuildInstructions#Using_Git_with_the_internal_SVN_

@jdufault
Any luck reproducing this locally?  I still only have working builds.
I didn't manage to get a local repro. I've also had a hard time landing this CL.
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=88814

------------------------------------------------------------------
r88814 | kbr@google.com | 2016-06-14T17:28:45.247940Z

-----------------------------------------------------------------

Comment 9 by msar...@google.com, Jun 14 2016

Thanks kbr@!

Please keep me posted on if this fixes the issues.  I'm still a little concerned as we haven't managed to reproduce the failures.

Comment 10 by ihf@chromium.org, Jun 15 2016

Status: Fixed (was: Assigned)
Continuous waterfalls are green again.
Labels: VerifyIn-53
Labels: VerifyIn-54
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment