GN does not update Java bindings when mojom files change |
|||||
Issue descriptionWhen a mojom file is updated, GN does not regenerate the Java bindings for it. For example, "currency_code" was recently changed to "currency" in: https://codesearch.chromium.org/chromium/src/third_party/WebKit/public/platform/modules/payments/payment_request.mojom A rebuild causes an error like this: out/gn/../../chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java:439: error: cannot find symbol || option.amount == null || TextUtils.isEmpty(option.amount.currency) ^ symbol: variable currency location: variable amount of type CurrencyAmount The workaround is to clean out the output directory completely: $ gn clean out/gn
,
Jun 16 2016
,
Jun 17 2016
,
Jun 20 2016
I don't think we're going to block the GYP->GN migration on this.
,
Jun 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14af73781b9d5372e205b01356004015c2b005ec commit 14af73781b9d5372e205b01356004015c2b005ec Author: sammc <sammc@chromium.org> Date: Wed Jun 22 02:43:34 2016 Fix a regex in javac.py. javac.py uses a regex to strip the parts after the base filename, e.g. Foo.class or Foo$Bar.class should produce Foo. However, it fails to strip .class from file names without a $. This corrects the regex. BUG= 619752 Review-Url: https://codereview.chromium.org/2079673002 Cr-Commit-Position: refs/heads/master@{#401177} [modify] https://crrev.com/14af73781b9d5372e205b01356004015c2b005ec/build/android/gyp/javac.py
,
Jun 22 2016
Thank you so much!
,
Jun 28 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yzshen@chromium.org
, Jun 14 2016