Add stub calls for server communication when creating WebAPK
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20e79c8a0bced8e60021f3ac04fc92391b613c65 commit 20e79c8a0bced8e60021f3ac04fc92391b613c65 Author: pkotwicz <pkotwicz@chromium.org> Date: Tue Jun 21 14:27:27 2016 Fix order of manifest_url & document_url in ParseManifestUrls() BUG= 619739 Review-Url: https://codereview.chromium.org/2064853003 Cr-Commit-Position: refs/heads/master@{#400986} [modify] https://crrev.com/20e79c8a0bced8e60021f3ac04fc92391b613c65/content/renderer/manifest/manifest_parser_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c099a894d1c0569d4bd20374ed8773ebcba6c989 commit c099a894d1c0569d4bd20374ed8773ebcba6c989 Author: pkotwicz <pkotwicz@chromium.org> Date: Thu Jun 23 17:21:42 2016 Implement "scope" Web Manifest parsing The parsing algorithm is defined in https://www.w3.org/TR/appmanifest/#scope-member This CL also sets start_url to the document URL if the start_url cannot be parsed as per the spec BUG= 619739 Review-Url: https://codereview.chromium.org/2063003003 Cr-Commit-Position: refs/heads/master@{#401640} [modify] https://crrev.com/c099a894d1c0569d4bd20374ed8773ebcba6c989/content/public/common/manifest.cc [modify] https://crrev.com/c099a894d1c0569d4bd20374ed8773ebcba6c989/content/public/common/manifest.h [modify] https://crrev.com/c099a894d1c0569d4bd20374ed8773ebcba6c989/content/renderer/manifest/manifest_parser.cc [modify] https://crrev.com/c099a894d1c0569d4bd20374ed8773ebcba6c989/content/renderer/manifest/manifest_parser.h [modify] https://crrev.com/c099a894d1c0569d4bd20374ed8773ebcba6c989/content/renderer/manifest/manifest_parser_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8c25a180344260005e9ecd261dd594b84d9c903 commit b8c25a180344260005e9ecd261dd594b84d9c903 Author: pkotwicz <pkotwicz@chromium.org> Date: Fri Jul 01 20:54:55 2016 Pass in extra parameters to WebApkBuilder#buildWebApkAsync() This CL: - Passes in the same parameters to WebApkBuilder#buildWebApkAsync() as those passed to ShortcutHelper#createWebappShortcutIntent(). This is necessary because WebAPKs and Web apps use the same splash screen rendering logic. - Passes in the Web Manifest URL and the icon URL to WebApkBuilder#buildWebApkAsync(). If the Chrome server has previously generated a WebAPK for a (manifestUrl, iconURL) pair, it is possible to download a WebAPK for the (manifestUrl, iconURL) pair from the Chrome server without uploading the icon bitmap to the server. BUG= 619739 Review-Url: https://codereview.chromium.org/2064943002 Cr-Commit-Position: refs/heads/master@{#403523} [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkBuilder.java [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/android/banners/app_banner_data_fetcher_android.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/android/banners/app_banner_data_fetcher_android.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/android/banners/app_banner_infobar_delegate_android.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/android/shortcut_helper.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/android/shortcut_info.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/android/shortcut_info.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/banners/app_banner_data_fetcher.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/banners/app_banner_data_fetcher.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/banners/app_banner_data_fetcher_desktop.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/banners/app_banner_data_fetcher_desktop.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/extensions/bookmark_app_helper.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/extensions/bookmark_app_helper.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/chrome/browser/extensions/bookmark_app_helper_unittest.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/browser/manifest/manifest_browsertest.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/browser/manifest/manifest_manager_host.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/browser/manifest/manifest_manager_host.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/common/manifest_manager_messages.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/public/browser/web_contents.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/renderer/devtools/devtools_agent.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/renderer/devtools/devtools_agent.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/renderer/manifest/manifest_manager.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/renderer/manifest/manifest_manager.h [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/renderer/push_messaging/push_messaging_dispatcher.cc [modify] https://crrev.com/b8c25a180344260005e9ecd261dd594b84d9c903/content/renderer/push_messaging/push_messaging_dispatcher.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bdfbe1bb993034cdb3d2fc846730e572176fde2 commit 6bdfbe1bb993034cdb3d2fc846730e572176fde2 Author: pkotwicz <pkotwicz@chromium.org> Date: Fri Jul 08 00:26:43 2016 Use scope defined in Web Manifest when adding page to homescreen BUG= 619739 Review-Url: https://codereview.chromium.org/2070433002 Cr-Commit-Position: refs/heads/master@{#404273} [modify] https://crrev.com/6bdfbe1bb993034cdb3d2fc846730e572176fde2/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java [modify] https://crrev.com/6bdfbe1bb993034cdb3d2fc846730e572176fde2/chrome/browser/android/shortcut_helper.cc [modify] https://crrev.com/6bdfbe1bb993034cdb3d2fc846730e572176fde2/chrome/browser/android/shortcut_info.cc [modify] https://crrev.com/6bdfbe1bb993034cdb3d2fc846730e572176fde2/chrome/browser/android/shortcut_info.h [modify] https://crrev.com/6bdfbe1bb993034cdb3d2fc846730e572176fde2/content/common/manifest_manager_messages.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20667314938d2a6972f2c1baaccbc9b9c43f2aa6 commit 20667314938d2a6972f2c1baaccbc9b9c43f2aa6 Author: pkotwicz <pkotwicz@chromium.org> Date: Tue Jul 19 19:13:30 2016 Split ShortcutHelper#addShortcut() into separate functions for each type of shortcut BUG= 619739 Review-Url: https://codereview.chromium.org/2129043002 Cr-Commit-Position: refs/heads/master@{#406334} [modify] https://crrev.com/20667314938d2a6972f2c1baaccbc9b9c43f2aa6/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java [modify] https://crrev.com/20667314938d2a6972f2c1baaccbc9b9c43f2aa6/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc [modify] https://crrev.com/20667314938d2a6972f2c1baaccbc9b9c43f2aa6/chrome/browser/android/shortcut_helper.cc [modify] https://crrev.com/20667314938d2a6972f2c1baaccbc9b9c43f2aa6/chrome/browser/android/shortcut_helper.h [modify] https://crrev.com/20667314938d2a6972f2c1baaccbc9b9c43f2aa6/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2 commit 879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2 Author: pkotwicz <pkotwicz@chromium.org> Date: Sat Aug 06 00:48:22 2016 This CL changes the behavior of ShortcutHelper::InstallWebApkInBackgroundWithSkBitmap() - To talk to WebAPK server (https://webapk.googleapis.com/v1alpha/webApks?alt=proto) to generate WebAPK - To download WebAPK from URL returned by WebAPK server This CL also: - Adds stub for talking to Google Play client to install WebAPK - Introduces manifest_util.h with methods for converting blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string BUG= 619739 TEST=WebApkInstallerTest.* R=dominickn,scottkirkwood,yfriedman,rsesek,hanxi,dfalcantara TBR=brettw (for third_party/smhasher/BUILD.gn) Review-Url: https://codereview.chromium.org/2138973002 Cr-Commit-Position: refs/heads/master@{#410233} [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java [delete] https://crrev.com/009fe04704c6cd15b521ce44026331fa1bd37f11/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkBuilder.java [add] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/android/java_sources.gni [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/BUILD.gn [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/android/shortcut_helper.cc [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/android/shortcut_helper.h [add] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/android/webapk/BUILD.gn [add] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/android/webapk/webapk.proto [add] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/android/webapk/webapk_installer.cc [add] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/android/webapk/webapk_installer.h [add] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/android/webapk/webapk_installer_unittest.cc [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/chrome_browser.gypi [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/chrome_tests_unit.gypi [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/common/chrome_switches.cc [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/chrome/common/chrome_switches.h [modify] https://crrev.com/879b1ed437bd6e1d535d0dfa0c3c16f79e0b55d2/third_party/smhasher/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/780b514674d00c784a3fd690910c79cbe697b015 commit 780b514674d00c784a3fd690910c79cbe697b015 Author: pkotwicz <pkotwicz@chromium.org> Date: Sun Aug 07 21:30:50 2016 Fix WebApkInstaller so that it can talk to the server This CL: - Fixes webapk.proto to match what the server uses - Sends webapk::WebApk proto instead of a webapk::CreateWebApkRequest proto to the server in WebApkInstaller::SendCreateWebApkRequest() - Increases the timeout to get a response from the WebAPK server. Currently the WebAPK server takes > 10 seconds to respond BUG= 619739 TEST=Manual Review-Url: https://codereview.chromium.org/2223443002 Cr-Commit-Position: refs/heads/master@{#410287} [modify] https://crrev.com/780b514674d00c784a3fd690910c79cbe697b015/chrome/browser/android/webapk/webapk.proto [modify] https://crrev.com/780b514674d00c784a3fd690910c79cbe697b015/chrome/browser/android/webapk/webapk_installer.cc [modify] https://crrev.com/780b514674d00c784a3fd690910c79cbe697b015/chrome/browser/android/webapk/webapk_installer.h [modify] https://crrev.com/780b514674d00c784a3fd690910c79cbe697b015/chrome/browser/android/webapk/webapk_installer_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f51f3c280f6f1fd180eb70581720bd1357f99a93 commit f51f3c280f6f1fd180eb70581720bd1357f99a93 Author: pkotwicz <pkotwicz@chromium.org> Date: Tue Aug 09 19:43:52 2016 Send orientation and display mode from Web Manifest to WebAPK server This CL also introduces manifest_util.* with methods for converting blink::WebDisplayMode and blink::WebScreenOrientationLockType to and from string BUG= 619739 R=mlamouri,sievers TBR=yfriedman Review-Url: https://codereview.chromium.org/2221823002 Cr-Commit-Position: refs/heads/master@{#410768} [modify] https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93/chrome/browser/android/webapk/webapk_installer.cc [add] https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93/content/common/manifest_util_unittest.cc [modify] https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93/content/content_common.gypi [modify] https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93/content/content_tests.gypi [add] https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93/content/public/common/manifest_util.cc [add] https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93/content/public/common/manifest_util.h [modify] https://crrev.com/f51f3c280f6f1fd180eb70581720bd1357f99a93/content/renderer/manifest/manifest_parser.cc
Comment 1 by bugdroid1@chromium.org
, Jun 21 2016