New issue
Advanced search Search tips

Issue 619726 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

PDFium missing windows_xfa_clang trybots

Project Member Reported by thestig@chromium.org, Jun 13 2016

Issue description

https://pdfium.googlesource.com/pdfium.git/+/2f307669ded2621f87d0b019e508f6663523f1d7 passed all trybots but broke the tree, because we don't have any windows_xfa_clang try bots. Who remembers how to add try bots off the top of their head?
 

Comment 1 by weili@chromium.org, Jun 13 2016

Owner: weili@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3bb22ab158e5ff15dbfa296d7940a67db83f9c45

commit 3bb22ab158e5ff15dbfa296d7940a67db83f9c45
Author: weili <weili@chromium.org>
Date: Tue Jun 21 17:31:49 2016

Add a windows_xfa_clang trybot and enable clang_use_chrome_plugins

Add a windows_xfa_clang trybot to capture some errors before committing
the code.

After we have removed all warnings generated by clang_use_chrome_plugins,
enable clang_use_chrome_plugins, which by default is enabled when clang
is used.

BUG= chromium:619726 , pdfium:469 

Review-Url: https://codereview.chromium.org/2085733002

[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/masters/master.tryserver.client.pdfium/builders.pyl
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/android.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/linux_skia_gn.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/linux_xfa_debug_gn.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/linux_xfa_rel_gn.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/mac_skia_gn.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/mac_xfa_debug_gn.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/mac_xfa_rel_gn.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/win_skia_gn.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/win_xfa_64_debug_gn.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.expected/win_xfa_64_rel_gn.json
[modify] https://crrev.com/3bb22ab158e5ff15dbfa296d7940a67db83f9c45/scripts/slave/recipes/pdfium.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium.git/+/6028b3ca5ba537fb1d61b86b424804390276b6f5

commit 6028b3ca5ba537fb1d61b86b424804390276b6f5
Author: weili <weili@chromium.org>
Date: Tue Jun 21 19:07:01 2016

Add win_xfa_clang trybot

Also clean up the file by ordering the trybots by names.

BUG= chromium:619726 

Review-Url: https://codereview.chromium.org/2088533004

[modify] https://crrev.com/6028b3ca5ba537fb1d61b86b424804390276b6f5/infra/config/cq.cfg

Comment 5 by weili@chromium.org, Jun 21 2016

Status: Fixed (was: Assigned)
Components: Infra>Client
Components: -Infra>Client>Pdfium

Sign in to add a comment