New issue
Advanced search Search tips

Issue 619716 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2016
Cc:
kkinnu...@nvidia.com
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

smoothness.tough_path_rendering_cases and smoothness.gpu_rasterization.tough_path_rendering_cases failure on Android Nexus5 Perf and Android Nexus7v2 Perf

Project Member Reported by zh...@chromium.org, Jun 13 2016 
First seen at:
Android Nexus5 Perf (1): https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus5%20Perf%20%281%29/builds/3320
Android Nexus7v2 Perf (1): https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus7v2%20Perf%20%281%29/builds/2815

Traceback (most recent call last):
  File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 84, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 306, in RunStory
    self._current_page.Run(self)
  File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 99, in Run
    self.RunPageInteractions(action_runner)
  File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/tools/perf/page_sets/tough_path_rendering_cases.py", line 23, in RunPageInteractions
    'document.getElementById("FinalTime").innerText != ""')
  File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 186, in WaitForJavaScriptCondition
    self._tab.WaitForJavaScriptExpression(condition, timeout_in_seconds)
  File "/b/build/slave/Android_Nexus5_Perf__1_/build/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 136, in WaitForJavaScriptExpression
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 60s for IsJavaScriptExpressionTrue.


Seems clear that https://codereview.chromium.org/1994653004 causes it. Will revert it directly.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b51973cd26598a234c7bd97a9909bdcc30a81003

commit b51973cd26598a234c7bd97a9909bdcc30a81003
Author: zhenw <zhenw@chromium.org>
Date: Mon Jun 13 21:56:17 2016

Revert of telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops (patchset #2 id:20001 of https://codereview.chromium.org/1994653004/ )

Reason for revert:
smoothness.tough_path_rendering_cases fails on Android Nexus5 Perf (1) and Android Nexus7v2 Perf (1) bots.

Seems clear that this CL causes it.

BUG= 619716 

Original issue's description:
> telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops
>
> Stop measuring tough_path_rendering_cases chalkboard test-case after the
> page stops its "benchmark" and presents the results.
>
> The page used to wait 20s. On my desktop it runs <10s and on my
> particular Android device, ~17s.
>
> This avoids measuring the page after it stops updating.
>
> Committed: https://crrev.com/6a26af29d26f974d63d78f2a29757f0f8f6162f4
> Cr-Commit-Position: refs/heads/master@{#399432}

TBR=nednguyen@google.com,senorblanco@google.com,senorblanco@chromium.org,kkinnunen@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2063013002
Cr-Commit-Position: refs/heads/master@{#399562}

[modify] https://crrev.com/b51973cd26598a234c7bd97a9909bdcc30a81003/tools/perf/page_sets/tough_path_rendering_cases.py

Comment 3 by zh...@chromium.org, Jun 13 2016

Summary: smoothness.tough_path_rendering_cases and smoothness.gpu_rasterization.tough_path_rendering_cases failure on Android Nexus5 Perf and Android Nexus7v2 Perf (was: smoothness.tough_path_rendering_cases failure on Android Nexus5 Perf (1) and Android Nexus7v2 Perf (1))
smoothness.gpu_rasterization.tough_path_rendering_cases also fails. Should be the same cause.

Comment 4 by zh...@chromium.org, Jun 14 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b51973cd26598a234c7bd97a9909bdcc30a81003

commit b51973cd26598a234c7bd97a9909bdcc30a81003
Author: zhenw <zhenw@chromium.org>
Date: Mon Jun 13 21:56:17 2016

Revert of telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops (patchset #2 id:20001 of https://codereview.chromium.org/1994653004/ )

Reason for revert:
smoothness.tough_path_rendering_cases fails on Android Nexus5 Perf (1) and Android Nexus7v2 Perf (1) bots.

Seems clear that this CL causes it.

BUG= 619716 

Original issue's description:
> telemetry: Stop measuring tough_path_rendering_cases chalkboard test after it stops
>
> Stop measuring tough_path_rendering_cases chalkboard test-case after the
> page stops its "benchmark" and presents the results.
>
> The page used to wait 20s. On my desktop it runs <10s and on my
> particular Android device, ~17s.
>
> This avoids measuring the page after it stops updating.
>
> Committed: https://crrev.com/6a26af29d26f974d63d78f2a29757f0f8f6162f4
> Cr-Commit-Position: refs/heads/master@{#399432}

TBR=nednguyen@google.com,senorblanco@google.com,senorblanco@chromium.org,kkinnunen@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2063013002
Cr-Commit-Position: refs/heads/master@{#399562}

[modify] https://crrev.com/b51973cd26598a234c7bd97a9909bdcc30a81003/tools/perf/page_sets/tough_path_rendering_cases.py
►

Sign in to add a comment