New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619715 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[General] Escape hatch to old settings

Project Member Reported by tbuck...@chromium.org, Jun 13 2016

Issue description

For the canary launch, we should offer users a way to get back to old settings just in case.
 

Comment 1 by dbeam@chromium.org, Jun 14 2016

Cc: -dbeam@chromium.org
Owner: dbeam@chromium.org
Status: Assigned (was: Available)
need a mock or i'm gonna make it REAL ugly

Comment 2 by dbeam@chromium.org, Jun 14 2016

Cc: bettes@chromium.org
see comment #1

Comment 3 by groby@chromium.org, Jun 14 2016

Just make it a picture of Alan & Tom.

Comment 4 by dbeam@chromium.org, Jun 14 2016

I foresee a "A personal appeal from Alan, Tom, and Dan" header in our future

Comment 5 by groby@chromium.org, Jun 14 2016

DO EEEET!
I approve (of using Alan's picture)!

Comment 7 by dbeam@chromium.org, Jun 17 2016

ehhh, I don't think we should add Alan's picture (for a number of reasons), though it'd be fairly awesome.

proposed UI attached
2016-06-17-155411_977x68_scrot.png
16.1 KB View Download
Since it's not going to many users, I think it's good to go. Some small changes if you have the time:
* I think white text would work better on the red background
* I'd prefer to use a string similar to "Please help improve the new Settings page by [filing bugs]. If you need to, [click here] to return to the old settings."
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27ab53523514b2371ca2343dd0b3f2b1ac0533fc

commit 27ab53523514b2371ca2343dd0b3f2b1ac0533fc
Author: dbeam <dbeam@chromium.org>
Date: Sat Jun 18 01:09:36 2016

MD Settings: add escape hatch

This is in the form of an [annoying, closeable] banner that helps users:

1) file bugs about the new, MD settings UI (bit.ly/md-settings-bug)
2) escape back to old settings (chrome://settings-frame)

R=groby@chromium.org
BUG= 619715 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2075323002
Cr-Commit-Position: refs/heads/master@{#400560}

[modify] https://crrev.com/27ab53523514b2371ca2343dd0b3f2b1ac0533fc/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/27ab53523514b2371ca2343dd0b3f2b1ac0533fc/chrome/browser/resources/settings/settings.js

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcc1f5a233a13955bf5cc72c72a1d7313a802f5

commit cbcc1f5a233a13955bf5cc72c72a1d7313a802f5
Author: dbeam <dbeam@chromium.org>
Date: Mon Jun 20 20:28:12 2016

MD Settings: make ugly appeal banner less ugly

R=dpapad@chromium.org
BUG= 619715 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2082763002
Cr-Commit-Position: refs/heads/master@{#400765}

[modify] https://crrev.com/cbcc1f5a233a13955bf5cc72c72a1d7313a802f5/chrome/browser/resources/settings/settings.html

Comment 11 by dbeam@chromium.org, Jun 20 2016

Status: Fixed (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed8355d03cdb5536c6d05f21b3e405b7793fabe6

commit ed8355d03cdb5536c6d05f21b3e405b7793fabe6
Author: Dan Beam <dbeam@chromium.org>
Date: Wed Jun 22 03:01:25 2016

MD Settings: more spam-proof bug URL

TBR=rouslan@chromium.org
BUG= 619715 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review URL: https://codereview.chromium.org/2089853004 .

Cr-Commit-Position: refs/heads/master@{#401183}

[modify] https://crrev.com/ed8355d03cdb5536c6d05f21b3e405b7793fabe6/chrome/browser/resources/settings/settings.html

Labels: Needs-Feedback
dbeam@, could you please provide clear repro steps to verify this change? I am seeing it on Canary by-default however wanna to make sure how it works on non-canary builds.

Thank you!

Comment 15 by groby@chromium.org, Jul 12 2016

Labels: -Needs-Feedback
As the very first comment says: *For the canary launch*

This feature is not available on beta/stable yet. 
Labels: Needs-Feedback
@groby Is this still available only on canary? I am unable to see this option in md-settings on ChromeOS 8872.18.0, 55.0.2883.20

Comment 17 by groby@chromium.org, Oct 21 2016

Labels: -Needs-Feedback
This feature has always been canary only, and is by now removed: https://codereview.chromium.org/2235793002

Can we flag this bug as 'no QA needed'?
Status: WontFix (was: Fixed)
Closing bug as per comment #17. Marking obsolete

Sign in to add a comment