New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 619681 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Jun 2016
Cc:
█ raikiri@google.com
dpranke@chromium.org
█ dcampb@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

When running layout tests, default to using GN build directory if one is present.

Project Member Reported by qyears...@chromium.org, Jun 13 2016 
Currently, when running layout tests, if no --target is given, the default behavior is to use the build in out/Release; to use the build in out/Default (or another directory), -t|--target must be given.

Now, as more Blink developers (most, I assume) use GN, it may be convenient if the default behavior was changed to check for out/Default and use that if present.

Relevant parts of the code:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py?l=155
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py?l=211

Dirk, would that make sense?

Comment 1 by dpranke@chromium.org, Jun 13 2016 

I don't actually know how common out/Default is. I suspect most devs still use either Debug or Release, and I don't know that there'd be any real point in changing things unless we had a wide majority using something else.

Comment 2 by qyears...@chromium.org, Jun 13 2016

Status: WontFix (was: Unconfirmed)
Makes sense; won't make any change here, though I added a note about this in https://sites.google.com/a/chromium.org/dev/developers/testing/webkit-layout-tests?pli=1#TOC-Running-the-Tests.
►

Sign in to add a comment