Update TrackDefault "kinds" to conform to MSE spec change |
|||
Issue descriptionThough "TrackDefault" may become at-risk or even dropped from MSE v1 spec (https://lists.w3.org/Archives/Public/public-html-media/2016Jun/0019.html), the spec for TrackDefault.kinds has changed: It's no longer a [], but a sequence; and it's no longer an attribute, but instead is renamed to a "getKinds()" accessor. This bug tracks making the changes to impl and test to conform to the spec, even though the feature might become at-risk or even dropped from MSE v1.
,
Oct 4 2016
Spec issue was https://github.com/w3c/media-source/issues/91
,
May 29 2017
TrackDefault was removed altogether in https://github.com/w3c/media-source/pull/138 Are there any plans to update the code in Blink? I'm looking at this from a bindings perspective (I'd like to drop support for WebIDL arrays from our bindings code).
,
Jul 11 2017
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eba0c2b7b83918cf52cceec66dbbfbed1e914963 commit eba0c2b7b83918cf52cceec66dbbfbed1e914963 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Fri Aug 11 17:55:16 2017 MSE: Stop using a WebIDL array in TrackDefault#kinds. Arrays were removed from the WebIDL spec in 2015. TrackDefault itself is no longer part of the MSE spec since https://github.com/w3c/media-source/pull/138; while it is not removed from Blink, go for the safest approach and just replace the DOMString array from the IDL with an `object' and move the array -> V8 object conversion to the C++ side. This avoids any user-visible changes. Bug: 619665 Change-Id: Idfa232feb780034bdd9ff6d631cd026189d6f1a6 Reviewed-on: https://chromium-review.googlesource.com/612250 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#493799} [modify] https://crrev.com/eba0c2b7b83918cf52cceec66dbbfbed1e914963/third_party/WebKit/Source/modules/mediasource/TrackDefault.cpp [modify] https://crrev.com/eba0c2b7b83918cf52cceec66dbbfbed1e914963/third_party/WebKit/Source/modules/mediasource/TrackDefault.h [modify] https://crrev.com/eba0c2b7b83918cf52cceec66dbbfbed1e914963/third_party/WebKit/Source/modules/mediasource/TrackDefault.idl
,
Aug 11 2017
,
Aug 16 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sheriffbot@chromium.org
, Jul 5 2016