New issue
Advanced search Search tips

Issue 619662 link

Starred by 1 user
Status: Fixed
Owner:
japhet@chromium.org
Closed: Dec 3
Cc:
alex...@chromium.org
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 477150



Sign in to add a comment

Console output differences trigger layout test failures with --site-per-process

Project Member Reported by lukasza@chromium.org, Jun 13 2016 
Repro:
$ ninja -C out/gn ... blink_tests
$ third_party/WebKit/Tools/Scripts/run-webkit-tests -t gn -v --no-retry-failures --additional-drt-flag=--no-sandbox --additional-drt-flag=--site-per-process http/tests/navigation/cross-origin-fragment-navigation-is-async.html

The differences in console output are understood and expected.  In theory, we could unify test output across modes by always silencing console messages (i.e. this is what we've done in https://crrev.com/2042043002 and https://crrev.com/2015713002), but this is undesirable for the test from repro steps, because this would limit test verification/coverage (some discussion about this happened in https://crrev.com/2057833002).
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c224308eb9edb880244751255280498c49b8219

commit 8c224308eb9edb880244751255280498c49b8219
Author: lukasza <lukasza@chromium.org>
Date: Tue Jun 14 16:45:58 2016

Assigning specific bugs to layout test failures in --site-per-process mode.

BUG= 616905 ,  619662 

Review-Url: https://codereview.chromium.org/2065693002
Cr-Commit-Position: refs/heads/master@{#399727}

[modify] https://crrev.com/8c224308eb9edb880244751255280498c49b8219/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c224308eb9edb880244751255280498c49b8219

commit 8c224308eb9edb880244751255280498c49b8219
Author: lukasza <lukasza@chromium.org>
Date: Tue Jun 14 16:45:58 2016

Assigning specific bugs to layout test failures in --site-per-process mode.

BUG= 616905 ,  619662 

Review-Url: https://codereview.chromium.org/2065693002
Cr-Commit-Position: refs/heads/master@{#399727}

[modify] https://crrev.com/8c224308eb9edb880244751255280498c49b8219/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a75af1cd30519bd7205f0d9129eb8db8f29c48d

commit 8a75af1cd30519bd7205f0d9129eb8db8f29c48d
Author: tyoshino <tyoshino@chromium.org>
Date: Thu Feb 23 05:39:20 2017

Move tests for sendBeacon to a separate dedicated directory for clearer ownership

Not only because of the ownership clarification, but it's just good to
have a better home for them since they're closer to XHR and Fetch API.
It's not so reasonable to place them in navigation/ just because they
belongs to window.navigator.

The virtual test virtual/stable/http/tests/navigation/ is kept for a
different reason.

Moved redirection-respond.php to http/tests/resources as it's not
specific to the tests under http/tests/navigation/

BUG= 682571 , 619662 , 490015 , 694958 

Review-Url: https://codereview.chromium.org/2702113003
Cr-Commit-Position: refs/heads/master@{#452408}

[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/645ad78c4d429cda9591f9be1486b911d7076f59/third_party/WebKit/LayoutTests/http/tests/navigation/beacon-cross-origin-redirect-expected.txt
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-301-response.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-302-response.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-303-response.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/navigation/post-307-response.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/resources/redirection-response.php
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked-expected.txt
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-beacon-redirect-to-blocked.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-allowance.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-blob-with-non-simple-type.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cookie-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cookie.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-blob.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-credentials.html
[add] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin-redirect.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.https-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-cross-origin.https.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-detached-no-crash-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-detached-no-crash.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-same-origin-expected.txt
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/beacon-same-origin.html
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/check-beacon.php
[rename] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/http/tests/sendbeacon/resources/save-beacon.php
[modify] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/navigation/README.txt
[delete] https://crrev.com/645ad78c4d429cda9591f9be1486b911d7076f59/third_party/WebKit/LayoutTests/virtual/stable/http/tests/navigation/beacon-cross-origin-redirect-blob-expected.txt
[add] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/sendbeacon/README.txt
[add] https://crrev.com/8a75af1cd30519bd7205f0d9129eb8db8f29c48d/third_party/WebKit/LayoutTests/virtual/stable/http/tests/sendbeacon/beacon-cross-origin-redirect-blob-expected.txt

Comment 4 by lukasza@chromium.org, Mar 9 2018

Labels: Test-Layout
We are trying to ship Strict Site Isolation (aka site-per-process) "soon" (aiming for M67 at the moment).  I assume that there is nothing here that would block this launch (i.e. it is okay it console messages in OOPIFs include only the origin and not the full URL).

If the above sounds okay, then the only decision to be made here is to either
1. Forever skip this test in the (soon-to-be-default) site-per-process mode
or
2. Update console message emitted by the product code, so that it only includes the origin (even if site-per-process is not enabled)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46

commit 32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46
Author: Nate Chapin <japhet@chromium.org>
Date: Mon Dec 03 19:15:08 2018

Make cross origin fragment navigation timing attack defenses testable via internals API

This removes the need for dumpFrameLoadCallbacks(), which is difficult to make
consistent with and without site isolation

Bug:  619662 
Change-Id: I94a553707c306eae4a755a2b2d3ddf45fa145bf7
Reviewed-on: https://chromium-review.googlesource.com/c/1354574
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613184}
[modify] https://crrev.com/32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46/third_party/blink/renderer/core/testing/internals.h
[modify] https://crrev.com/32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46/third_party/blink/renderer/core/testing/internals.idl
[modify] https://crrev.com/32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46/third_party/blink/web_tests/http/tests/navigation/cross-origin-fragment-navigation-is-async-expected.txt
[modify] https://crrev.com/32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46/third_party/blink/web_tests/http/tests/navigation/cross-origin-fragment-navigation-is-async.html
[modify] https://crrev.com/32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46/third_party/blink/web_tests/http/tests/navigation/same-origin-fragment-navigation-is-sync-expected.txt
[modify] https://crrev.com/32ba6d4609c0de506e8de97dcd9b5d29cfbf2e46/third_party/blink/web_tests/http/tests/navigation/same-origin-fragment-navigation-is-sync.html

Comment 6 by japhet@chromium.org, Dec 3

Owner: japhet@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04396e8039bbb1fc6bd049beaaf47a4d3e886568

commit 04396e8039bbb1fc6bd049beaaf47a4d3e886568
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Mon Dec 03 20:59:42 2018

Remove cross-origin-fragment-navigation-is-async.html from not-spp.

The test has been fixed in r613184 and therefore doesn't need separate
expectations for site-per-process and not-site-per-process.  Therefore
this CL removes this test from virtual/not-site-per-process suite.

Bug:  619662 
Change-Id: Idf80b42401df5aa0c78c5b76654a9915e111bfe2
Reviewed-on: https://chromium-review.googlesource.com/c/1359090
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613240}
[modify] https://crrev.com/04396e8039bbb1fc6bd049beaaf47a4d3e886568/third_party/blink/web_tests/VirtualTestSuites
►

Sign in to add a comment