New issue
Advanced search Search tips

Issue 619636 link

Starred by 1 user
Status: Verified
Owner:
jamescook@chromium.org
Closed: Jul 2016
Cc:
msw@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 620955



Sign in to add a comment

mash: Convert status tray to use WmWindow types

Project Member Reported by jamescook@chromium.org, Jun 13 2016 
This is a tracking bug for making the code in //ash/system/tray use ash::wm::WmWindow instead of aura::Window directly.

For mash, we're starting to collapse the window manager (desktop_wm) and system UI (ash_sysui) into a single process/service. The window manager bits manipulate mus windows, via a wrapper class ash::wm::WmWindow.

In order to make the status tray work in this environment it will need to avoid direct access to aura::Window and use the wrappers instead.

As things are converted they will move into //ash/common/system/tray
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63936fe7c958796f7ab0c56102e4de4ffed61d1e

commit 63936fe7c958796f7ab0c56102e4de4ffed61d1e
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 13 19:11:25 2016

mash: Move SystemTrayImage and TrayImageItem to //ash/common

These are dependencies of TrayUpdate, which I am moving to //ash/common

I'm allowing //ash/system/tray/system_tray.h in DEPS because it's mostly a bag
of pointers to individual tray items. We'll be able to move it over once most
of the individual items move and it doesn't seem worth the code churn to add a
WmSystemTray.

move_source_file.py ash/system/tray/tray_utils.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_utils.cc ash/common/system/tray/
move_source_file.py ash/system/tray/system_tray_item.h ash/common/system/tray/
move_source_file.py ash/system/tray/system_tray_item.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_image_item.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_image_item.cc ash/common/system/tray/

BUG=619636
TEST=compiles, ash_unittests

Review-Url: https://codereview.chromium.org/2063813002
Cr-Commit-Position: refs/heads/master@{#399503}

[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/ash.gyp
[add] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/DEPS
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/system_tray_item.cc
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/system_tray_item.h
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_image_item.cc
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_image_item.h
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_item_view.cc
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_item_view.h
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_utils.cc
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_utils.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/audio/tray_audio.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/audio/volume_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/cast/tray_cast.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/bluetooth/tray_bluetooth.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/brightness/tray_brightness.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/brightness/tray_brightness_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/enterprise/tray_enterprise.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_network.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_sms.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_vpn.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/power/tray_power.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/rotation/tray_rotation_lock.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/screen_security/screen_tray_item.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/screen_security/screen_tray_item_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/session/tray_session_length_limit.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/settings/tray_settings.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/supervised/tray_supervised_user.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/tray_caps_lock.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/tray_display.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/tray_tracing.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/date/date_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/date/tray_date.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/date/tray_date.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/media_security/multi_profile_media_tray_item.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/media_security/multi_profile_media_tray_item.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/system_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_empty.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_item_more.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_notification_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray_accessibility.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray_update.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/button_from_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/tray_user.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/tray_user.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/tray_user_separator.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/user_card_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e044e1cf503b7635d746d6b34594195eeac10dba

commit e044e1cf503b7635d746d6b34594195eeac10dba
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 13 20:56:18 2016

mash: Move ash constants and layout constants files to //ash/common

These are dependencies of some of the system tray code that I'm moving to
//ash/common.

* Removed some unneeded includes
* move_source_file.py ash/ash_constants.h ash/common/
* move_source_file.py ash/ash_constants.cc ash/common/
* move_source_file.py ash/ash_layout_constants.h ash/common/
* move_source_file.py ash/ash_layout_constants.cc ash/common/

BUG=619636
TEST=compiles, ash_unittests
TBR=stevenjb@chromium.org for mechanical change to chrome/browser/chromeos

Review-Url: https://codereview.chromium.org/2061823002
Cr-Commit-Position: refs/heads/master@{#399531}

[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/ash.gyp
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/aura/wm_window_aura.cc
[rename] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/common/ash_constants.cc
[rename] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/common/ash_constants.h
[rename] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/common/ash_layout_constants.cc
[rename] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/common/ash_layout_constants.h
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/default_header_painter.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/frame_border_hit_test_controller.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/root_window_controller.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shelf/app_list_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shelf/overflow_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shelf/shelf_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shelf/shelf_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shell.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/audio/volume_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/tray/actionable_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/tray/tray_popup_header_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/tray/tray_popup_label_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/user/button_from_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/immersive_fullscreen_controller.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/resize_handle_window_targeter.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/resize_shadow_and_cursor_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/window_util.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/workspace/multi_window_resize_controller_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.h
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/ui/views/frame/browser_header_painter_ash.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21281076a0aa41af8a0489964f51f8e952a15a16

commit 21281076a0aa41af8a0489964f51f8e952a15a16
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 13 23:54:21 2016

mash: Move TrayUpdate to //ash/common

It no longer has aura or ash::Shell dependencies.

Allow +ash/test in ash/common/system/DEPS because it's important for tests to
sit next to their implementation code, even if ash/test hasn't been converted
away from aura yet.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2059383002
Cr-Commit-Position: refs/heads/master@{#399606}

[modify] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/ash.gyp
[rename] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/common/system/DEPS
[rename] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/common/system/update/tray_update.cc
[rename] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/common/system/update/tray_update.h
[rename] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/common/system/update/tray_update_unittest.cc
[modify] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/system/tray/system_tray.cc
[modify] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/test/ash_test_base.cc
[modify] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/test/ash_test_base.h
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40501777b01f7ee5d746a5a82cd0eec8c4e4edac

commit 40501777b01f7ee5d746a5a82cd0eec8c4e4edac
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 14 01:03:48 2016

mash: Move most files in //ash/system/tray to //ash/common/system/tray

None of these files have aura or ash::Shell dependencies, but many of them are
dependencies of other files I'm trying to move.

This is a mechanical change:
move_source_file.py ash/system/tray/actionable_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/actionable_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/fixed_sized_scroll_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/fixed_sized_scroll_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/hover_highlight_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/hover_highlight_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/special_popup_row.h ash/common/system/tray/
move_source_file.py ash/system/tray/special_popup_row.cc ash/common/system/tray/
move_source_file.py ash/system/tray/throbber_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/throbber_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_bar_button_with_title.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_bar_button_with_title.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_empty.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_empty.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_more.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_more.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_notification_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_notification_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_header_button.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_header_button.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_item_container.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_item_container.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button_border.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button_border.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button.cc ash/common/system/tray/
move_source_file.py ash/system/tray/view_click_listener.h ash/common/system/tray/

I also removed a few unnecessary includes of base/compiler_specific.h.

BUG=619636
TEST=compiles
TBR=stevenjb@chromium.org for mechanical changes to //chrome/browser/chromeos

Review-Url: https://codereview.chromium.org/2066583004
Cr-Commit-Position: refs/heads/master@{#399628}

[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/ash.gyp
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/actionable_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/actionable_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/fixed_sized_scroll_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/fixed_sized_scroll_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/hover_highlight_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/hover_highlight_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/special_popup_row.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/special_popup_row.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/throbber_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/throbber_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_bar_button_with_title.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_bar_button_with_title.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_empty.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_empty.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_item_more.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_item_more.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_notification_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_notification_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_header_button.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_header_button.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_item_container.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_item_container.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_label_button.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_label_button.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_label_button_border.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_label_button_border.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/view_click_listener.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/audio/volume_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/audio/volume_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/audio/audio_detailed_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/audio/audio_detailed_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/enterprise/tray_enterprise.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/label_tray_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/network_state_list_detailed_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/vpn_list_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/screen_security/screen_tray_item.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/supervised/tray_supervised_user.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/date/date_default_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/date/date_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/tray_details_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray_accessibility.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray_accessibility.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/user/user_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/chrome/browser/chromeos/ui/focus_ring_controller.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8df13c9ccb506af4f6108be3b882d65f06a912

commit 8a8df13c9ccb506af4f6108be3b882d65f06a912
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 14 18:08:34 2016

mash: Migrate tray date view to //ash/common types

This eliminates ash::Shell dependencies.

* Move clock observers to WmSystemTrayNotifier
* Move metrics to WmUserMetricsAction
* Add RequestShutdown() to SystemTrayDelegate to avoid dependency on
LockStateController

BUG=619636
TEST=existing ash_unittests

Review-Url: https://codereview.chromium.org/2064953002
Cr-Commit-Position: refs/heads/master@{#399747}

[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/ash.gyp
[rename] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/date/clock_observer.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/tray/wm_system_tray_notifier.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/wm/wm_user_metrics_action.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/metrics/user_metrics_recorder.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/chromeos/power/power_event_observer.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/chromeos/system_clock_observer.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/date_default_view.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/date_default_view.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/date_view.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/date_view.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/tray_date.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/tray_date.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63936fe7c958796f7ab0c56102e4de4ffed61d1e

commit 63936fe7c958796f7ab0c56102e4de4ffed61d1e
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 13 19:11:25 2016

mash: Move SystemTrayImage and TrayImageItem to //ash/common

These are dependencies of TrayUpdate, which I am moving to //ash/common

I'm allowing //ash/system/tray/system_tray.h in DEPS because it's mostly a bag
of pointers to individual tray items. We'll be able to move it over once most
of the individual items move and it doesn't seem worth the code churn to add a
WmSystemTray.

move_source_file.py ash/system/tray/tray_utils.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_utils.cc ash/common/system/tray/
move_source_file.py ash/system/tray/system_tray_item.h ash/common/system/tray/
move_source_file.py ash/system/tray/system_tray_item.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_image_item.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_image_item.cc ash/common/system/tray/

BUG=619636
TEST=compiles, ash_unittests

Review-Url: https://codereview.chromium.org/2063813002
Cr-Commit-Position: refs/heads/master@{#399503}

[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/ash.gyp
[add] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/DEPS
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/system_tray_item.cc
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/system_tray_item.h
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_image_item.cc
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_image_item.h
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_item_view.cc
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_item_view.h
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_utils.cc
[rename] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/common/system/tray/tray_utils.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/audio/tray_audio.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/audio/volume_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/cast/tray_cast.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/bluetooth/tray_bluetooth.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/brightness/tray_brightness.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/brightness/tray_brightness_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/enterprise/tray_enterprise.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_network.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_sms.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/network/tray_vpn.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/power/tray_power.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/rotation/tray_rotation_lock.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/screen_security/screen_tray_item.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/screen_security/screen_tray_item_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/session/tray_session_length_limit.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/settings/tray_settings.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/supervised/tray_supervised_user.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/tray_caps_lock.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/tray_display.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/tray_tracing.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/date/date_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/date/tray_date.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/date/tray_date.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/media_security/multi_profile_media_tray_item.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/media_security/multi_profile_media_tray_item.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/system_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_empty.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_item_more.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray/tray_notification_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray_accessibility.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/tray_update.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/button_from_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/tray_user.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/tray_user.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/tray_user_separator.h
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/user/user_card_view.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
[modify] https://crrev.com/63936fe7c958796f7ab0c56102e4de4ffed61d1e/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e044e1cf503b7635d746d6b34594195eeac10dba

commit e044e1cf503b7635d746d6b34594195eeac10dba
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 13 20:56:18 2016

mash: Move ash constants and layout constants files to //ash/common

These are dependencies of some of the system tray code that I'm moving to
//ash/common.

* Removed some unneeded includes
* move_source_file.py ash/ash_constants.h ash/common/
* move_source_file.py ash/ash_constants.cc ash/common/
* move_source_file.py ash/ash_layout_constants.h ash/common/
* move_source_file.py ash/ash_layout_constants.cc ash/common/

BUG=619636
TEST=compiles, ash_unittests
TBR=stevenjb@chromium.org for mechanical change to chrome/browser/chromeos

Review-Url: https://codereview.chromium.org/2061823002
Cr-Commit-Position: refs/heads/master@{#399531}

[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/ash.gyp
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/aura/wm_window_aura.cc
[rename] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/common/ash_constants.cc
[rename] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/common/ash_constants.h
[rename] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/common/ash_layout_constants.cc
[rename] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/common/ash_layout_constants.h
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/default_header_painter.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/frame/frame_border_hit_test_controller.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/root_window_controller.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shelf/app_list_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shelf/overflow_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shelf/shelf_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shelf/shelf_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/shell.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/audio/volume_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/tray/actionable_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/tray/tray_popup_header_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/tray/tray_popup_label_button.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/system/user/button_from_view.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/immersive_fullscreen_controller.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/resize_handle_window_targeter.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/resize_shadow_and_cursor_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/window_util.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/ash/wm/workspace/multi_window_resize_controller_unittest.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.h
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/ui/views/frame/browser_header_painter_ash.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e044e1cf503b7635d746d6b34594195eeac10dba/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21281076a0aa41af8a0489964f51f8e952a15a16

commit 21281076a0aa41af8a0489964f51f8e952a15a16
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 13 23:54:21 2016

mash: Move TrayUpdate to //ash/common

It no longer has aura or ash::Shell dependencies.

Allow +ash/test in ash/common/system/DEPS because it's important for tests to
sit next to their implementation code, even if ash/test hasn't been converted
away from aura yet.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2059383002
Cr-Commit-Position: refs/heads/master@{#399606}

[modify] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/ash.gyp
[rename] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/common/system/DEPS
[rename] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/common/system/update/tray_update.cc
[rename] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/common/system/update/tray_update.h
[rename] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/common/system/update/tray_update_unittest.cc
[modify] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/system/tray/system_tray.cc
[modify] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/test/ash_test_base.cc
[modify] https://crrev.com/21281076a0aa41af8a0489964f51f8e952a15a16/ash/test/ash_test_base.h
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40501777b01f7ee5d746a5a82cd0eec8c4e4edac

commit 40501777b01f7ee5d746a5a82cd0eec8c4e4edac
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 14 01:03:48 2016

mash: Move most files in //ash/system/tray to //ash/common/system/tray

None of these files have aura or ash::Shell dependencies, but many of them are
dependencies of other files I'm trying to move.

This is a mechanical change:
move_source_file.py ash/system/tray/actionable_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/actionable_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/fixed_sized_scroll_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/fixed_sized_scroll_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/hover_highlight_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/hover_highlight_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/special_popup_row.h ash/common/system/tray/
move_source_file.py ash/system/tray/special_popup_row.cc ash/common/system/tray/
move_source_file.py ash/system/tray/throbber_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/throbber_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_bar_button_with_title.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_bar_button_with_title.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_empty.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_empty.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_more.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_item_more.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_notification_view.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_notification_view.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_header_button.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_header_button.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_item_container.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_item_container.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button_border.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button_border.cc ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button.h ash/common/system/tray/
move_source_file.py ash/system/tray/tray_popup_label_button.cc ash/common/system/tray/
move_source_file.py ash/system/tray/view_click_listener.h ash/common/system/tray/

I also removed a few unnecessary includes of base/compiler_specific.h.

BUG=619636
TEST=compiles
TBR=stevenjb@chromium.org for mechanical changes to //chrome/browser/chromeos

Review-Url: https://codereview.chromium.org/2066583004
Cr-Commit-Position: refs/heads/master@{#399628}

[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/ash.gyp
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/actionable_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/actionable_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/fixed_sized_scroll_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/fixed_sized_scroll_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/hover_highlight_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/hover_highlight_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/special_popup_row.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/special_popup_row.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/throbber_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/throbber_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_bar_button_with_title.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_bar_button_with_title.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_empty.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_empty.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_item_more.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_item_more.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_notification_view.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_notification_view.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_header_button.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_header_button.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_item_container.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_item_container.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_label_button.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_label_button.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_label_button_border.cc
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/tray_popup_label_button_border.h
[rename] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/common/system/tray/view_click_listener.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/audio/tray_audio.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/audio/volume_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/audio/volume_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/audio/audio_detailed_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/audio/audio_detailed_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/enterprise/tray_enterprise.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/label_tray_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/network_state_list_detailed_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/network/vpn_list_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/screen_security/screen_tray_item.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/settings/tray_settings.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/supervised/tray_supervised_user.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/date/date_default_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/date/date_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/tray_details_view.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray_accessibility.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/tray_accessibility.h
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/ash/system/user/user_view.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/40501777b01f7ee5d746a5a82cd0eec8c4e4edac/chrome/browser/chromeos/ui/focus_ring_controller.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a8df13c9ccb506af4f6108be3b882d65f06a912

commit 8a8df13c9ccb506af4f6108be3b882d65f06a912
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 14 18:08:34 2016

mash: Migrate tray date view to //ash/common types

This eliminates ash::Shell dependencies.

* Move clock observers to WmSystemTrayNotifier
* Move metrics to WmUserMetricsAction
* Add RequestShutdown() to SystemTrayDelegate to avoid dependency on
LockStateController

BUG=619636
TEST=existing ash_unittests

Review-Url: https://codereview.chromium.org/2064953002
Cr-Commit-Position: refs/heads/master@{#399747}

[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/ash.gyp
[rename] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/date/clock_observer.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/tray/wm_system_tray_notifier.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/common/wm/wm_user_metrics_action.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/metrics/user_metrics_recorder.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/chromeos/power/power_event_observer.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/chromeos/system_clock_observer.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/date_default_view.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/date_default_view.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/date_view.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/date_view.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/tray_date.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/date/tray_date.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/8a8df13c9ccb506af4f6108be3b882d65f06a912/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a96777c4353060e81cbe657ca6c1e2490d776ed5

commit a96777c4353060e81cbe657ca6c1e2490d776ed5
Author: jamescook <jamescook@chromium.org>
Date: Wed Jun 15 02:15:33 2016

mash: Move all ash UMA metrics to //ash/common/metrics

Now that the window manager and sysui are the same binary we don't need to
maintain separate UserMetricsAction and WmUserMetricsAction enums.

Also remove some unnecessary ash:: namespace qualifiers.

BUG=619636
TEST=compiles, ash_unittests

Review-Url: https://codereview.chromium.org/2063333002
Cr-Commit-Position: refs/heads/master@{#399820}

[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/ash.gyp
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/aura/wm_shell_aura.h
[add] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/common/metrics/user_metrics_action.h
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/common/shelf/shelf_alignment_menu.cc
[delete] https://crrev.com/9e43284c6c6948793e9e38aa30ad0d59b37a748a/ash/common/wm/wm_user_metrics_action.h
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/common/wm/workspace/workspace_window_resizer.cc
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/common/wm_shell.h
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/metrics/user_metrics_recorder.cc
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/metrics/user_metrics_recorder.h
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/system/date/date_default_view.cc
[modify] https://crrev.com/a96777c4353060e81cbe657ca6c1e2490d776ed5/ash/wm/overview/window_selector.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/090562764026b47fe5abb09fd89670123b63e0cb

commit 090562764026b47fe5abb09fd89670123b63e0cb
Author: jamescook <jamescook@chromium.org>
Date: Thu Jun 16 00:28:42 2016

mash: Move //ash/system/date to //ash/common

It no longer has aura or ash::Shell dependencies.

Moved chromeos-specific dependencies to //ash/common/system/chromeos and
copied //ash/system/chromeos/DEPS there.

BUG=619636
TEST=compiles, ash_unittests

Review-Url: https://codereview.chromium.org/2061123004
Cr-Commit-Position: refs/heads/master@{#400059}

[modify] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/ash.gyp
[add] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/chromeos/DEPS
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/chromeos/shutdown_policy_observer.h
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/chromeos/system_clock_observer.cc
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/chromeos/system_clock_observer.h
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/date/date_default_view.cc
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/date/date_default_view.h
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/date/date_view.cc
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/date/date_view.h
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/date/date_view_unittest.cc
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/date/tray_date.cc
[rename] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/common/system/date/tray_date.h
[modify] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/ash/system/tray/system_tray.cc
[modify] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/090562764026b47fe5abb09fd89670123b63e0cb/chrome/browser/ui/ash/system_tray_delegate_chromeos_browsertest_chromeos.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3228109cfdac49a405bbd039a4b4456097be9dd7

commit 3228109cfdac49a405bbd039a4b4456097be9dd7
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 17 00:21:36 2016

mash: Convert AshPopupAlignmentDelegate to wm common types

This is a dependency of WebNotificationTray, which is a dependency of
StatusAreaWidget, which I am trying to migrate to wm common types.

* Add auto-hide and work area methods to WmShelf.
* Access shelf_widget() via shelf_layout_manager() in WmShelfAura, as we need
to access it before the |Shelf| is created during external monitor init.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2029323002
Cr-Commit-Position: refs/heads/master@{#400312}

[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/common/shelf/wm_shelf_observer.h
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/shelf/shelf.cc
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/shelf/shelf.h
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/system/web_notification/ash_popup_alignment_delegate.h
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/test/ash_test_base.cc
[modify] https://crrev.com/3228109cfdac49a405bbd039a4b4456097be9dd7/ash/test/ash_test_base.h

Comment 15 by jamescook@chromium.org, Jun 17 2016

Blocking: 620955
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26f32092680910d571ea398888263cb4f01f1e10

commit 26f32092680910d571ea398888263cb4f01f1e10
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 17 04:26:52 2016

mash: Convert FocusCycler to wm common types and move to //ash/common

FocusCycler is a dependency of the status area widget code I'm trying to move.

* Introduce WmWindow::GetWidget().
* Move FocusCycler ownership from ash::Shell to WmShell.
* Eliminate extraneous Shell::RotateFocus() method in favor of calling
FocusCycler directly.

I'm intentionally leaving the unit test in place, as it has dependencies that
haven't migrated yet.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2075923002
Cr-Commit-Position: refs/heads/master@{#400354}

[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/ash.gyp
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/aura/wm_window_aura.h
[rename] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/common/focus_cycler.cc
[rename] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/common/focus_cycler.h
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/common/wm_shell.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/common/wm_shell.h
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/common/wm_window.h
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/mus/bridge/wm_window_mus.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/mus/bridge/wm_window_mus.h
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/root_window_controller.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/shelf/shelf.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/shell.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/shell.h
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/26f32092680910d571ea398888263cb4f01f1e10/chrome/browser/chromeos/login/ui/webui_login_view.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a94e04900ffd0dc33ee1214fc917d9ec535d992

commit 6a94e04900ffd0dc33ee1214fc917d9ec535d992
Author: msw <msw@chromium.org>
Date: Fri Jun 17 17:21:38 2016

mash: Move tray settings and deps to common.

tools/git/move_source_file.py ash/system/chromeos/devicetype_utils* ash/common/system/chromeos/
tools/git/move_source_file.py ash/system/chromeos/power/battery_notification* ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/dual_role_notification* ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/power_status* ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/power/tray_power* ash/common/system/chromeos/power/
tools/git/move_source_file.py ash/system/chromeos/settings/tray_settings* ash/common/system/chromeos/settings/
tools/git/move_source_file.py ash/system/system_notifier* ash/common/system/

Add ash_switches.h to allowed ash/common/DEPS; run "git cl format".
Convert tray_settings.cc ash::Shell uses to ash::WmShell.
Remove some unused shell[_delegate].h includes.

BUG=619636
TEST=compiles, ash_unittests
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2072013002
Cr-Commit-Position: refs/heads/master@{#400448}

[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/ash.gyp
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/DEPS
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/devicetype_utils.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/devicetype_utils.h
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/battery_notification.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/battery_notification.h
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/dual_role_notification.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/dual_role_notification.h
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/power_status.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/power_status.h
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/power_status_unittest.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/power_status_view.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/power_status_view.h
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/power_status_view_unittest.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/tray_power.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/tray_power.h
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/power/tray_power_unittest.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/settings/tray_settings.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/chromeos/settings/tray_settings.h
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/system_notifier.cc
[rename] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/common/system/system_notifier.h
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/display/display_util.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/display/resolution_notification_controller.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/shell.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/system/chromeos/bluetooth/bluetooth_notification_controller.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/system/chromeos/screen_security/screen_capture_tray_item.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/system/chromeos/screen_security/screen_share_tray_item.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/system/chromeos/session/tray_session_length_limit.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/system/chromeos/tray_display_unittest.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/system/locale/locale_notification_controller.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/ash/system/tray/system_tray.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/chrome_webusb_browser_client.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/chromeos/arc/arc_auth_notification.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/chromeos/arc/arc_support_host.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/chromeos/net/network_portal_notification_controller.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/chromeos/status/data_promo_notification.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/extensions/component_loader.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/notifications/fullscreen_notification_blocker.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/notifications/login_state_notification_blocker_chromeos.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/notifications/login_state_notification_blocker_chromeos_browsertest.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/notifications/login_state_notification_blocker_chromeos_unittest.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/notifications/message_center_settings_controller.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/notifications/message_center_settings_controller_unittest.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/signin/easy_unlock_screenlock_state_handler.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/signin/signin_error_notifier_ash.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/webui/help/help_handler.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/webui/options/chromeos/consumer_management_handler.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/webui/options/chromeos/power_handler.h
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/6a94e04900ffd0dc33ee1214fc917d9ec535d992/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9b1b341d89d7bd0025b1268ecb772f4c3eac425

commit d9b1b341d89d7bd0025b1268ecb772f4c3eac425
Author: msw <msw@chromium.org>
Date: Fri Jun 17 20:19:57 2016

mash: Move ash_switches.* to ash/common; cleanup DEPS.

tools/git/move_source_file.py ash/ash_switches* ash/common/
Fix include in ash/virtual_keyboard_controller_unittest.cc.
Remove explicit ash_switches.h entry from ash/common/DEPS.

BUG=619636
TEST=Compiles, no changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2074213002
Cr-Commit-Position: refs/heads/master@{#400485}

[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/accelerators/magnifier_key_scroller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/ash.gyp
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/audio/sounds.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/common/DEPS
[rename] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/common/ash_switches.cc
[rename] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/common/ash_switches.h
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/common/material_design/material_design_controller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/common/material_design/material_design_controller_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/common/system/chromeos/power/tray_power.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/common/system/chromeos/power/tray_power_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/desktop_background/desktop_background_controller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/desktop_background/desktop_background_controller_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/dip_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/display/display_change_observer_chromeos.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/display/display_layout_store.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/display/display_manager.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/display/mirror_window_controller_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/display/root_window_transformers.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/frame/custom_frame_view_ash.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/root_window_controller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shelf/overflow_button.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shelf/shelf_button.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shelf/shelf_navigator_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shelf/shelf_view.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shell.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/shell_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/system/status_area_widget_delegate.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/system/tray/system_tray.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/system/user/tray_user.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/test/ash_test_base.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/test/ash_test_helper.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/test/display_manager_test_api.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/test/test_suite.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/touch/touch_observer_hud_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/virtual_keyboard_controller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/virtual_keyboard_controller_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/maximize_mode/maximize_mode_controller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/maximize_mode/maximize_mode_window_manager.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/power_button_controller.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/ash/wm/system_gesture_event_filter.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/about_flags.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/prefs/command_line_pref_store.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/accelerator_commands_browsertest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/ash/volume_controller_chromeos.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/browser.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/common/chrome_switches.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/d9b1b341d89d7bd0025b1268ecb772f4c3eac425/chrome/test/base/view_event_test_platform_part_chromeos.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aada0db95278da7d4d74bae5d6dfb4480d5b3bee

commit aada0db95278da7d4d74bae5d6dfb4480d5b3bee
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 17 22:10:02 2016

mash: Break ash system tray dependencies on ash::ShelfWidget

This is a step towards converting the system tray to wm common types, as well
as a step toward hiding the internal details of the shelf implementation from
external users. Long term, all access to shelf state should go via WmShelf.

* Plumb WmShelf into StatusAreaWidget.
* Remove ShelfWidget usage from //ash/system.
* Remove unnecessary includes.

BUG=615502,619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2072023003
Cr-Commit-Position: refs/heads/master@{#400520}

[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/root_window_controller.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/shelf/shelf_widget.h
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/DEPS
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/status_area_widget.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/status_area_widget.h
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/tray/system_tray.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/test/ash_test_base.cc
[modify] https://crrev.com/aada0db95278da7d4d74bae5d6dfb4480d5b3bee/ash/test/ash_test_base.h
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21c95c56e86bda6f8f056551ca9ee043317ed1d6

commit 21c95c56e86bda6f8f056551ca9ee043317ed1d6
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 20 18:47:13 2016

mash: Convert WebNotificationTray to wm common types

This is a dependency of the status area widget which I'm trying to convert to
wm common types.

Introduce a method to the message center's delegate that allows it to
compute the parent container for a popup. This cannot be a NativeView, since
on mus a NativeView is an aura::Window, but the parent container is a mus
window.

This can't move to //ash/common yet because of system tray dependencies.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2075953003
Cr-Commit-Position: refs/heads/master@{#400738}

[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ash/system/web_notification/ash_popup_alignment_delegate.cc
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ash/system/web_notification/ash_popup_alignment_delegate.h
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/chrome/browser/ui/views/message_center/web_notification_tray.cc
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ui/message_center/views/desktop_popup_alignment_delegate.cc
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ui/message_center/views/desktop_popup_alignment_delegate.h
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ui/message_center/views/message_popup_collection.cc
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ui/message_center/views/message_popup_collection.h
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ui/message_center/views/message_popup_collection_unittest.cc
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ui/message_center/views/popup_alignment_delegate.h
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ui/message_center/views/toast_contents_view.cc
[modify] https://crrev.com/21c95c56e86bda6f8f056551ca9ee043317ed1d6/ui/message_center/views/toast_contents_view.h
Project Member

Comment 21 by bugdroid1@chromium.org, Jun 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2741744f732caf973d062a4bf3d5b53e6d621a25

commit 2741744f732caf973d062a4bf3d5b53e6d621a25
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 20 21:37:05 2016

Convert TrayAccessibility to wm common types

* Move //ui/chromeos/accessibility_types.h into //ash/common because it is
used in non-chromeos code, but only in //ash.
* Migrate AccessibilityObserver to WmSystemTrayNotifier
* Move AccessibilityObserver to its own file to reduce the #include burden of
wm_system_tray_notifier.h
* Fix include-what-you-use violations

I will move tray_accessibility.* into //ash/common in a separate CL because it
will involve moving tray_details_view.h, which is widely used.

BUG=619636,621574
TEST=ash_unittests
TBR=atwilson@chromium.org for mechanical change to //chrome/browser/policy

Review-Url: https://codereview.chromium.org/2074913005
Cr-Commit-Position: refs/heads/master@{#400791}

[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/ash.gyp
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/ash_touch_exploration_manager_chromeos.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/accessibility_delegate.h
[rename] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/accessibility_types.h
[add] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/system/accessibility_observer.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/system/tray/wm_system_tray_notifier.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/keyboard/keyboard_ui.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/magnifier/magnification_controller_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/shell.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/ime/tray_ime_chromeos.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray_accessibility.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ash/system/tray_accessibility.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/accessibility/accessibility_manager.h
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/accessibility/chromevox_panel.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/accessibility/magnification_manager_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ui/chromeos/BUILD.gn
[modify] https://crrev.com/2741744f732caf973d062a4bf3d5b53e6d621a25/ui/chromeos/ui_chromeos.gyp
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1

commit 8cd6bf7724bffef12c62d8868e70b3afdb24f3c1
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 21 16:31:12 2016

mash: Move tray accessibility and keyboard to //ash/common

These are dependencies of tray IME and status area widget, both of which I'm
trying to move.

This is a purely mechanical change:
* Move //ash/keyboard to //ash/common/keyboard
* Move //ash/system/tray_accessibility.* to //ash/common/system/
* Move //ash/system/tray/tray_details_view.* to //ash/common/system/tray

BUG=619636
TEST=compiles, ash_unittests
TBR=msw@chromium.org for purely mechanical move

Review-Url: https://codereview.chromium.org/2084733002
Cr-Commit-Position: refs/heads/master@{#401009}

[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/ash.gyp
[rename] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/common/keyboard/keyboard_ui.cc
[rename] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/common/keyboard/keyboard_ui.h
[rename] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/common/keyboard/keyboard_ui_observer.h
[rename] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/common/system/tray/tray_details_view.cc
[rename] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/common/system/tray/tray_details_view.h
[rename] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/common/system/tray/tray_details_view_unittest.cc
[rename] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/common/system/tray_accessibility.cc
[rename] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/common/system/tray_accessibility.h
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/shell.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/chromeos/audio/audio_detailed_view.h
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/chromeos/network/network_detailed_view.h
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/system/tray/system_tray.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/sysui/keyboard_ui_mus.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/ash/sysui/keyboard_ui_mus.h
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/8cd6bf7724bffef12c62d8868e70b3afdb24f3c1/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcfe3d6f46ad4c35849ef40812cc499fc557cca8

commit dcfe3d6f46ad4c35849ef40812cc499fc557cca8
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 21 18:58:42 2016

mash: Migrate tray IME view to wm common types, move to //ash/common

* Move IMEObserver and VirtualKeyboardObserver to WmSystemTrayNotifier.
* Fix the tray IME unit test so it doesn't need StatusAreaWidget.

The rest of VirtualKeyboardController will have to wait until
MaximizeModeController can be migrated.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2086503003
Cr-Commit-Position: refs/heads/master@{#401060}

[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/ash.gyp
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/aura/wm_shell_aura.h
[add] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_observer.h
[rename] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/common/system/ime/ime_observer.h
[rename] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/common/system/ime/tray_ime_chromeos.cc
[rename] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/common/system/ime/tray_ime_chromeos.h
[rename] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/common/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/common/system/tray/wm_system_tray_notifier.cc
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/common/wm_shell.h
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/mus/bridge/wm_shell_mus.h
[delete] https://crrev.com/6bce64fd587463426ba7f0290056f7f781187557/ash/system/chromeos/virtual_keyboard/virtual_keyboard_observer.h
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/system/tray/system_tray.cc
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/virtual_keyboard_controller.cc
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/ash/virtual_keyboard_controller_unittest.cc
[modify] https://crrev.com/dcfe3d6f46ad4c35849ef40812cc499fc557cca8/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
Project Member

Comment 24 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5071557339d01da7d2d39f9040cf7e79e89c1adc

commit 5071557339d01da7d2d39f9040cf7e79e89c1adc
Author: jamescook <jamescook@chromium.org>
Date: Wed Jun 22 03:11:03 2016

Convert TrayEventFilter to wm common types

* Use WmShell for PointerWatcher access
* Remove unused includes of ash/root_window_controller.h
* Disallow ash/root_window_controller.h usage in ash/system/tray via DEPS
* Remove ContainerDelegate, which is now unused

This cannot move to //ash/common yet because it has dependencies on
TrayBackgroundView.

BUG=619636
TEST=ash_unittests, manual tests that the system tray bubble closes when you
click outside it, but does not close if you click on a notification

Review-Url: https://codereview.chromium.org/2086143002
Cr-Commit-Position: refs/heads/master@{#401188}

[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/ash.gyp
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/common/wm_shell.h
[delete] https://crrev.com/0a4ac9cffe2faed28f965edd21b89a5e69e74170/ash/container_delegate.h
[delete] https://crrev.com/0a4ac9cffe2faed28f965edd21b89a5e69e74170/ash/container_delegate_aura.cc
[delete] https://crrev.com/0a4ac9cffe2faed28f965edd21b89a5e69e74170/ash/container_delegate_aura.h
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/shell.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/shell.h
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/shell_delegate.h
[add] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/system/tray/DEPS
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/system/tray/tray_event_filter.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/sysui/BUILD.gn
[delete] https://crrev.com/0a4ac9cffe2faed28f965edd21b89a5e69e74170/ash/sysui/container_delegate_mus.cc
[delete] https://crrev.com/0a4ac9cffe2faed28f965edd21b89a5e69e74170/ash/sysui/container_delegate_mus.h
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/ash/test/test_shell_delegate.h
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/5071557339d01da7d2d39f9040cf7e79e89c1adc/chrome/browser/ui/ash/chrome_shell_delegate.h
Project Member

Comment 25 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6784963ea28707482c8e5bd12966ddad2857fe41

commit 6784963ea28707482c8e5bd12966ddad2857fe41
Author: msw <msw@chromium.org>
Date: Wed Jun 22 03:16:25 2016

mash: Migrate locale observer and notification to common.

tools/git/move_source_file.py ash/system/locale/* ash/common/system/locale
Move LocaleObserver and Notify functions to WmSystemTrayNotifier.
Add locale_observer.h to the build config. Fix some IWYU issues.

BUG=619636
TEST=compiles, no regressions (had to hack for manual testing...)
R=jamescook@chromium.org,stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2082193002
Cr-Commit-Position: refs/heads/master@{#401191}

[modify] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/ash/ash.gyp
[rename] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/ash/common/system/locale/locale_notification_controller.cc
[rename] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/ash/common/system/locale/locale_notification_controller.h
[rename] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/ash/common/system/locale/locale_observer.h
[modify] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/ash/common/system/tray/wm_system_tray_notifier.cc
[modify] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/ash/shell.cc
[modify] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/chrome/browser/chromeos/locale_change_guard.cc
[modify] https://crrev.com/6784963ea28707482c8e5bd12966ddad2857fe41/chrome/browser/chromeos/locale_change_guard.h
Project Member

Comment 26 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/143c7930eae1a0984232e8e306798e20fda4e3c4

commit 143c7930eae1a0984232e8e306798e20fda4e3c4
Author: jamescook <jamescook@chromium.org>
Date: Wed Jun 22 17:05:22 2016

Convert TrayBubbleWrapper to wm common types

This can't move to //ash/common yet because of dependencies on
TrayBackgroundView.

BUG=619636
TEST=manual, see crbug.com/177075

Review-Url: https://codereview.chromium.org/2085133002
Cr-Commit-Position: refs/heads/master@{#401314}

[modify] https://crrev.com/143c7930eae1a0984232e8e306798e20fda4e3c4/ash/system/tray/tray_bubble_wrapper.cc
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72

commit 7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72
Author: msw <msw@chromium.org>
Date: Wed Jun 22 23:58:56 2016

mash: Migrate tray audio and deps to common.

tools/git/move_source_file.py ash/display/display_info* ash/common/display/
tools/git/move_source_file.py ash/system/audio/* ash/common/system/audio

Add WmShell::GetDisplayInfo helper (punts moving DisplayManager).
Move audio observer add/remove/notify to WmSystemTrayNotifier.
Fix IWYU issues.

BUG=619636
TEST=Compile; no tray audio changes.
R=jamescook@chromium.org
TBR=reveman@chromium.org,yusukes@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2084533008
Cr-Commit-Position: refs/heads/master@{#401470}

[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/ash.gyp
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/aura/wm_shell_aura.h
[rename] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/display/display_info.cc
[rename] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/display/display_info.h
[rename] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/display/display_info_unittest.cc
[rename] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/system/audio/audio_observer.h
[rename] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/system/audio/tray_audio.cc
[rename] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/system/audio/tray_audio.h
[rename] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/system/audio/tray_audio_delegate.h
[rename] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/system/audio/volume_view.cc
[rename] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/system/audio/volume_view.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/system/tray/wm_system_tray_notifier.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/common/wm_shell.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/content/display/screen_orientation_controller_chromeos_unittest.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/desktop_background/desktop_background_controller.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/display_change_observer_chromeos.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/display_change_observer_chromeos_unittest.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/display_manager.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/display_util.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/event_transformation_handler.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/resolution_notification_controller.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/root_window_transformers.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/rotator/screen_rotation_animator.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/system/chromeos/audio/tray_audio_chromeos.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/system/chromeos/audio/tray_audio_chromeos.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/system/chromeos/audio/tray_audio_delegate_chromeos.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/system/chromeos/tray_display.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/system/tray/system_tray.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/test/ash_test_helper.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/test/display_manager_test_api.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/touch/touchscreen_util.h
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/touch/touchscreen_util_unittest.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/wm/ash_native_cursor_manager_interactive_uitest.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/ash/wm/ash_native_cursor_manager_unittest.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/chrome/browser/chromeos/display/overscan_calibrator.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/components/arc/audio/arc_audio_bridge.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/components/exo/pointer.cc
[modify] https://crrev.com/7f1ec9231fb3c62fefd0e89ff09456ed9d42fc72/components/exo/wayland/server.cc
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e

commit ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e
Author: jamescook <jamescook@chromium.org>
Date: Wed Jun 22 23:56:56 2016

mash: Optionally set bubble widget parent container via delegate

Use the delegate mechanism on ash to support both aura and mus.

This eliminates aura::Window usage in SystemTrayBubble and WebNotificationTray,
which is step toward converting TrayBubbleView to wm common types.

I didn't eliminate BubbleDialogDelegateView::parent_window_ because that
mechanism is used in ~30 places inside //chrome.

BUG=619636
TEST=ash_unittests, views_unittests, manually check that system tray bubbles
still open/close propertly

Review-Url: https://codereview.chromium.org/2092473002
Cr-Commit-Position: refs/heads/master@{#401469}

[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ash/system/tray/system_tray.cc
[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ash/system/tray/system_tray.h
[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ui/views/bubble/bubble_dialog_delegate.h
[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/ca6fa1d5d9954bf3f7815b3477acd50a29e9a02e/ui/views/bubble/tray_bubble_view.h
Project Member

Comment 29 by bugdroid1@chromium.org, Jun 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76014a371acaa910a826d268cf739d722763c96b

commit 76014a371acaa910a826d268cf739d722763c96b
Author: msw <msw@chromium.org>
Date: Thu Jun 23 23:14:57 2016

Migrate simple ash Shell metrics users.

Use WmShell::RecordUserMetricsAction where possible.
(nix most ash::Shell uses for UserMetricsRecorder access)
Update SessionStateDelegate accessors in touched files.

BUG=619636
TEST=Compiles; unit tests; no behavioral changes.
R=jamescook@chromium.org,sky@chromium.org

Review-Url: https://codereview.chromium.org/2099443002
Cr-Commit-Position: refs/heads/master@{#401750}

[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/accelerators/exit_warning_handler.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/frame/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/frame/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/metrics/desktop_task_switch_metric_recorder.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/shelf/shelf_button_pressed_metric_tracker.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/shelf/shelf_view.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/chromeos/audio/tray_audio_chromeos.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/chromeos/keyboard_brightness_controller.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/tray/system_tray.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/system/user/user_view.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/touch/touch_uma.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/wm/maximize_mode/maximize_mode_controller.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/wm/panels/panel_window_event_handler.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/wm/window_cycle_controller.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/ash/wm/workspace/workspace_event_handler.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/76014a371acaa910a826d268cf739d722763c96b/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
Project Member

Comment 30 by bugdroid1@chromium.org, Jun 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6f6340048f0ec9535c310d16dd515133fb04c50

commit f6f6340048f0ec9535c310d16dd515133fb04c50
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 24 01:17:55 2016

mash: Convert TrayBackgroundView to wm common types

Also convert StatusAreaWidget usage to WmShelf. This is closer to the long-
term pattern we want, where StatusAreaWidget is accessed via wm types.

* Eliminate the TrayBackgroundView::status_area_widget() accessors
* Cache a copy of StatusAreaWidget* in subclasses where needed

Move the following interdependent files:
move_source_file.py ash/system/tray/tray_background_view.* ash/common/system/tray/
move_source_file.py ash/system/tray/tray_bubble_wrapper.* ash/common/system/tray/
move_source_file.py ash/system/tray/tray_event_filter.* ash/common/system/tray/
move_source_file.py ash/system/tray/system_tray_bubble.* ash/common/system/tray/

BUG=619636
TEST=ash_unittests
TBR=stevenjb@chromium.org for 1 line rename in c/b/ui/chromeos/

Review-Url: https://codereview.chromium.org/2091933002
Cr-Commit-Position: refs/heads/master@{#401769}

[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/ash.gyp
[rename] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/common/system/tray/system_tray_bubble.cc
[rename] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/common/system/tray/system_tray_bubble.h
[rename] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/common/system/tray/tray_background_view.cc
[rename] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/common/system/tray/tray_background_view.h
[rename] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/common/system/tray/tray_bubble_wrapper.cc
[rename] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/common/system/tray/tray_bubble_wrapper.h
[rename] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/common/system/tray/tray_event_filter.cc
[rename] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/common/system/tray/tray_event_filter.h
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/shelf/overflow_bubble.cc
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/chromeos/session/logout_button_tray.h
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/tray/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/tray/system_tray.cc
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/tray/system_tray.h
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50/chrome/browser/chromeos/ui/focus_ring_controller.cc
Project Member

Comment 31 by bugdroid1@chromium.org, Jun 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c51f5db7293b1e6100d44e71497428cde6d520a

commit 3c51f5db7293b1e6100d44e71497428cde6d520a
Author: piman <piman@chromium.org>
Date: Fri Jun 24 02:33:44 2016

Revert of mash: Convert TrayBackgroundView to wm common types (patchset #4 id:60001 of https://codereview.chromium.org/2091933002/ )

Reason for revert:
Causing compile errors
- https://build.chromium.org/p/chromium/builders/Win/builds/44650

FAILED: obj/ash/ash/web_notification_tray.obj
ninja -t msvc -e environment.x86 -- C:\b\build\slave\cache\cipd\goma/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/ash/ash/web_notification_tray.obj.rsp /c ../../ash/system/web_notification/web_notification_tray.cc /Foobj/ash/ash/web_notification_tray.obj /Fd"obj/ash/ash_cc.pdb"
c:\b\build\slave\win\build\src\ash\system\web_notification\web_notification_tray.cc(510): error C3861: 'status_area_widget': identifier not found
c:\b\build\slave\win\build\src\ash\system\web_notification\web_notification_tray.cc(510): error C2227: left of '->system_tray' must point to class/struct/union/generic type
c:\b\build\slave\win\build\src\ash\system\web_notification\web_notification_tray.cc(510): note: type is 'unknown-type'
c:\b\build\slave\win\build\src\ash\system\web_notification\web_notification_tray.cc(510): error C2227: left of '->SetNextFocusableView' must point to class/struct/union/generic type

Original issue's description:
> mash: Convert TrayBackgroundView to wm common types
>
> Also convert StatusAreaWidget usage to WmShelf. This is closer to the long-
> term pattern we want, where StatusAreaWidget is accessed via wm types.
>
> * Eliminate the TrayBackgroundView::status_area_widget() accessors
> * Cache a copy of StatusAreaWidget* in subclasses where needed
>
> Move the following interdependent files:
> move_source_file.py ash/system/tray/tray_background_view.* ash/common/system/tray/
> move_source_file.py ash/system/tray/tray_bubble_wrapper.* ash/common/system/tray/
> move_source_file.py ash/system/tray/tray_event_filter.* ash/common/system/tray/
> move_source_file.py ash/system/tray/system_tray_bubble.* ash/common/system/tray/
>
> BUG=619636
> TEST=ash_unittests
> TBR=stevenjb@chromium.org for 1 line rename in c/b/ui/chromeos/
>
> Committed: https://crrev.com/f6f6340048f0ec9535c310d16dd515133fb04c50
> Cr-Commit-Position: refs/heads/master@{#401769}

TBR=msw@chromium.org,stevenjb@chromium.org,jamescook@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619636

Review-Url: https://codereview.chromium.org/2097733002
Cr-Commit-Position: refs/heads/master@{#401792}

[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/ash.gyp
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/shelf/overflow_bubble.cc
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/chromeos/session/logout_button_tray.h
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/system_tray.cc
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/system_tray.h
[rename] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/system_tray_bubble.cc
[rename] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/system_tray_bubble.h
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/system_tray_unittest.cc
[rename] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/tray_background_view.cc
[rename] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/tray_background_view.h
[rename] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/tray_bubble_wrapper.cc
[rename] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/tray_bubble_wrapper.h
[rename] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/tray_event_filter.cc
[rename] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/tray/tray_event_filter.h
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/3c51f5db7293b1e6100d44e71497428cde6d520a/chrome/browser/chromeos/ui/focus_ring_controller.cc
Project Member

Comment 32 by bugdroid1@chromium.org, Jun 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/380fac77139a702a0108cded2c5444e1bdce0375

commit 380fac77139a702a0108cded2c5444e1bdce0375
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 24 05:32:37 2016

Reland: mash: Convert TrayBackgroundView to wm common types

The previous version of this patch, https://codereview.chromium.org/2091933002
collided during commit with https://codereview.chromium.org/2087703002. This
is just a rebase.

Also convert StatusAreaWidget usage to WmShelf. This is closer to the long-
term pattern we want, where StatusAreaWidget is accessed via wm types.

* Eliminate the TrayBackgroundView::status_area_widget() accessors
* Cache a copy of StatusAreaWidget* in subclasses where needed

Move the following interdependent files:
move_source_file.py ash/system/tray/tray_background_view.* ash/common/system/tray/
move_source_file.py ash/system/tray/tray_bubble_wrapper.* ash/common/system/tray/
move_source_file.py ash/system/tray/tray_event_filter.* ash/common/system/tray/
move_source_file.py ash/system/tray/system_tray_bubble.* ash/common/system/tray/

BUG=619636
TEST=ash_unittests
TBR=msw@chromium.org

Review-Url: https://codereview.chromium.org/2099603002
Cr-Commit-Position: refs/heads/master@{#401820}

[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/ash.gyp
[rename] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/common/system/tray/system_tray_bubble.cc
[rename] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/common/system/tray/system_tray_bubble.h
[rename] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/common/system/tray/tray_background_view.cc
[rename] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/common/system/tray/tray_background_view.h
[rename] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/common/system/tray/tray_bubble_wrapper.cc
[rename] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/common/system/tray/tray_bubble_wrapper.h
[rename] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/common/system/tray/tray_event_filter.cc
[rename] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/common/system/tray/tray_event_filter.h
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/shelf/overflow_bubble.cc
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/chromeos/session/logout_button_tray.h
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/tray/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/tray/system_tray.cc
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/tray/system_tray.h
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/ash/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/380fac77139a702a0108cded2c5444e1bdce0375/chrome/browser/chromeos/ui/focus_ring_controller.cc
Project Member

Comment 33 by bugdroid1@chromium.org, Jun 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2

commit 6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2
Author: jamescook <jamescook@chromium.org>
Date: Fri Jun 24 17:36:28 2016

mash: Move TrayTracing to //ash/common/system/chromeos

* Convert to WmShell and WmSystemTrayNotifier
* Wrap the WmSystemTrayNotifier bits in OS_CHROMEOS guards because this
  feature only exists on Chrome OS.

BUG=619636
TEST=manual, go to chrome://slow and turn it on and off, see status area icon

Review-Url: https://codereview.chromium.org/2091953002
Cr-Commit-Position: refs/heads/master@{#401893}

[modify] https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2/ash/ash.gyp
[rename] https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2/ash/common/system/chromeos/tray_tracing.cc
[rename] https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2/ash/common/system/chromeos/tray_tracing.h
[modify] https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2/ash/common/system/tray/wm_system_tray_notifier.cc
[modify] https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2/ash/system/tray/system_tray.cc
[modify] https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2/ash/system/tray/system_tray_notifier.cc
[modify] https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/6631e5c3fc4b3af4b77abddacd0312f1e0aa8ab2/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
Project Member

Comment 34 by bugdroid1@chromium.org, Jun 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b241605e36b22bdfc76448ad1577e6b110a5d6e5

commit b241605e36b22bdfc76448ad1577e6b110a5d6e5
Author: msw <msw@chromium.org>
Date: Fri Jun 24 21:23:45 2016

mash: Migrate some system user files to common.

Move some (not all) of ash/system/user to common:
tools/git/move_source_file.py ash/system/user/button_from_view.* ash/common/system/user/
tools/git/move_source_file.py ash/system/user/login_status.* ash/common/system/user/
tools/git/move_source_file.py ash/system/user/rounded_image_view.* ash/common/system/user/
tools/git/move_source_file.py ash/system/user/user_observer.h ash/common/system/user/
tools/git/move_source_file.py ash/system/user/tray_user_separator.* ash/common/system/user/
The remaining files will require more complex changes.

Forward declare enum class LoginStatus where possible.
Otherwise include ash/common/login_status.h where possible.
Otherwise include ash/common/system/user/login_status.h.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2099793002
Cr-Commit-Position: refs/heads/master@{#401975}

[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/ash.gyp
[rename] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/common/system/user/button_from_view.cc
[rename] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/common/system/user/button_from_view.h
[rename] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/common/system/user/login_status.cc
[rename] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/common/system/user/login_status.h
[rename] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/common/system/user/rounded_image_view.cc
[rename] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/common/system/user/rounded_image_view.h
[rename] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/common/system/user/tray_user_separator.cc
[rename] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/common/system/user/tray_user_separator.h
[rename] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/common/system/user/user_observer.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/metrics/user_metrics_recorder_unittest.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/root_window_controller.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/root_window_controller.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/shell.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/shell.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/chromeos/enterprise/tray_enterprise.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/chromeos/network/network_state_list_detailed_view.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/chromeos/session/last_window_closed_logout_reminder.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/chromeos/session/logout_button_tray.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/chromeos/supervised/tray_supervised_user_unittest.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/tray/system_tray.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/tray/system_tray.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/user/tray_user.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/user/tray_user.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/user/user_card_view.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/user/user_card_view.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/user/user_view.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/system/user/user_view.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/test/status_area_widget_test_helper.h
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/test/test_session_state_delegate.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/chrome/browser/chromeos/power/power_button_observer.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/b241605e36b22bdfc76448ad1577e6b110a5d6e5/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
Project Member

Comment 35 by bugdroid1@chromium.org, Jun 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c804fb217d79733cbab0be093bdbe69ed9098d2

commit 5c804fb217d79733cbab0be093bdbe69ed9098d2
Author: msw <msw@chromium.org>
Date: Sat Jun 25 00:09:15 2016

mash: Migrate remaining tray observers and notify functions.

Move observers to common (but not their implementations):
tools/git/move_source_file.py ash/system/chromeos/bluetooth/bluetooth_observer.h ash/common/system/chromeos/bluetooth/
tools/git/move_source_file.py ash/system/chromeos/enterprise/enterprise_domain_observer.h ash/common/system/chromeos/enterprise/
tools/git/move_source_file.py ash/system/chromeos/network/network_observer.h ash/common/system/chromeos/network/
tools/git/move_source_file.py ash/system/chromeos/network/network_portal_detector_observer.h ash/common/system/chromeos/network/
tools/git/move_source_file.py ash/system/chromeos/screen_security/screen_capture_observer.h ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py ash/system/chromeos/screen_security/screen_share_observer.h ash/common/system/chromeos/screen_security/
tools/git/move_source_file.py ash/system/chromeos/session/last_window_closed_observer.h ash/common/system/chromeos/session/
tools/git/move_source_file.py ash/system/chromeos/session/logout_button_observer.h ash/common/system/chromeos/session/
tools/git/move_source_file.py ash/system/chromeos/session/session_length_limit_observer.h ash/common/system/chromeos/session/
tools/git/move_source_file.py ash/system/tray/media_security/media_capture_observer.h ash/common/system/chromeos/media_security/
tools/git/move_source_file.py ash/system/user/user_observer.h ash/common/system/user/

Move the ash/system/tray/media_security to ash/system/chromeos/:
tools/git/move_source_file.py ash/system/tray/media_security/* ash/system/chromeos/media_security/
(this fits the pattern of other cros system tray features)
Also remove the (now unnecessary) non-chromeos media_security build rules.

Merge and reorder remaining SystemTrayNotifier functions.
Rename WmSystemTrayNotifier to SystemTrayNotifier:
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.h ash/common/system/tray/system_tray_notifier.h
tools/git/move_source_file.py ash/common/system/tray/wm_system_tray_notifier.cc ash/common/system/tray/system_tray_notifier.cc

Use WmShell::Get()->GetSessionStateDelegate() more; minor cleanup and IWYU.
Use AshTestBase::GetPrimarySystemTray in screen_tray_item_unittest.cc

BUG=619636
TEST=Compiles; automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,yusukes@chromium.org,wez@chromium.org

Review-Url: https://codereview.chromium.org/2098023002
Cr-Commit-Position: refs/heads/master@{#402022}

[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/BUILD.gn
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/ash.gyp
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/keyboard/keyboard_ui.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/audio/tray_audio.cc
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/bluetooth/bluetooth_observer.h
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/enterprise/enterprise_domain_observer.h
[add] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/media_security/media_capture_observer.h
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/network/network_observer.h
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/network/network_portal_detector_observer.h
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/screen_security/screen_capture_observer.h
[add] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/screen_security/screen_share_observer.h
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/session/last_window_closed_observer.h
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/session/logout_button_observer.h
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/session/session_length_limit_observer.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/system_clock_observer.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/date/tray_date.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/locale/locale_notification_controller.cc
[add] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/tray/system_tray_notifier.cc
[add] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/tray/system_tray_notifier.h
[delete] https://crrev.com/dfdd18491df338a32c630c1425bd866cab524e1f/ash/common/system/tray/wm_system_tray_notifier.cc
[delete] https://crrev.com/dfdd18491df338a32c630c1425bd866cab524e1f/ash/common/system/tray/wm_system_tray_notifier.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/update/tray_update.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/system/update/tray_update_unittest.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/wm_shell.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/common/wm_shell.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/root_window_controller.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/shell.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/shell.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/bluetooth/tray_bluetooth.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/brightness/tray_brightness.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/enterprise/tray_enterprise.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/enterprise/tray_enterprise.h
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/media_security/multi_profile_media_tray_item.cc
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/media_security/multi_profile_media_tray_item.h
[rename] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/network/tray_network.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/power/power_event_observer.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/screen_security/screen_capture_tray_item.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/screen_security/screen_capture_tray_item.h
[delete] https://crrev.com/dfdd18491df338a32c630c1425bd866cab524e1f/ash/system/chromeos/screen_security/screen_share_observer.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/screen_security/screen_share_tray_item.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/screen_security/screen_share_tray_item.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/screen_security/screen_tray_item.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/screen_security/screen_tray_item_unittest.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/session/last_window_closed_logout_reminder.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/session/last_window_closed_logout_reminder.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/session/logout_button_tray.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/session/tray_session_length_limit.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/session/tray_session_length_limit.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/tray_caps_lock.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[delete] https://crrev.com/dfdd18491df338a32c630c1425bd866cab524e1f/ash/system/tray/media_security/media_capture_observer.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/tray/system_tray.cc
[delete] https://crrev.com/dfdd18491df338a32c630c1425bd866cab524e1f/ash/system/tray/system_tray_notifier.cc
[delete] https://crrev.com/dfdd18491df338a32c630c1425bd866cab524e1f/ash/system/tray/system_tray_notifier.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/user/tray_user.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/system/user/user_card_view.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/virtual_keyboard_controller.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/virtual_keyboard_controller.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/ash/virtual_keyboard_controller_unittest.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/chrome/browser/chromeos/accessibility/magnification_manager.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/chrome/browser/chromeos/locale_change_guard.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/chrome/browser/chromeos/net/network_portal_notification_controller.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/chrome/browser/chromeos/ui/screen_capture_notification_ui_chromeos.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/chrome/browser/ui/ash/media_delegate_chromeos.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/components/arc/audio/arc_audio_bridge.cc
[modify] https://crrev.com/5c804fb217d79733cbab0be093bdbe69ed9098d2/remoting/host/disconnect_window_chromeos.cc
Project Member

Comment 36 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54a4d47fa4f8602431aa7b646fd7a77d34e96818

commit 54a4d47fa4f8602431aa7b646fd7a77d34e96818
Author: jamescook <jamescook@chromium.org>
Date: Mon Jun 27 19:37:26 2016

mash: Convert all of //ash/system to use WmShelf

This breaks dependencies on //ash/shelf in favor of one on //ash/common.

* Add WmShelf::ForPrimaryDisplay().
* Remove AshTestBase::GetPrimaryShelf() in favor of above.
* Skip unnecessary setting of shelf visibility state and auto-hide state in tests.
* Remove unnecessary includes.

BUG=615502,619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2093283002
Cr-Commit-Position: refs/heads/master@{#402257}

[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/ash.gyp
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/aura/wm_shelf_aura.h
[add] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/common/shelf/wm_shelf.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/common/shelf/wm_shelf.h
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/DEPS
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/chromeos/screen_security/screen_tray_item.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/toast/toast_overlay.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/user/tray_user.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/54a4d47fa4f8602431aa7b646fd7a77d34e96818/ash/system/web_notification/web_notification_tray_unittest.cc
Project Member

Comment 37 by bugdroid1@chromium.org, Jun 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ee304e39c514d2486b7e240d4c3af227e22bbc2

commit 4ee304e39c514d2486b7e240d4c3af227e22bbc2
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 28 03:44:07 2016

mash: Remove StatusAreaWidget references from system tray classes

Breaking this dependency will allow individual system tray pieces (e.g. the web
notification tray) to be created without a StatusAreaWidget. This provides a
path for ash/mus to instantiate its own status area widget and to add pieces
one by one.

Rename WebNotificationTray::SetSystemTrayHeight() to SetTrayBubbleHeight() so
it is more clear what the SystemTray / WebNotificationTray dependency really
is.

Move //ash/system/web_notifications to //ash/common as this is its last
non-common dependency.

BUG=619636
TEST=ash_unittests
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2103603002
Cr-Commit-Position: refs/heads/master@{#402395}

[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/ash.gyp
[rename] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/common/system/web_notification/ash_popup_alignment_delegate.cc
[rename] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/common/system/web_notification/ash_popup_alignment_delegate.h
[rename] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/common/system/web_notification/web_notification_tray.cc
[rename] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/common/system/web_notification/web_notification_tray.h
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/chromeos/session/logout_button_tray.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/chromeos/session/logout_button_tray.h
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/chromeos/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/status_area_widget.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/status_area_widget.h
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/tray/system_tray.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/tray/system_tray.h
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/4ee304e39c514d2486b7e240d4c3af227e22bbc2/chrome/browser/notifications/message_center_notification_manager.cc
Project Member

Comment 38 by bugdroid1@chromium.org, Jun 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b73810563987686c2e4f22ba98a10fa0275372b0

commit b73810563987686c2e4f22ba98a10fa0275372b0
Author: jamescook <jamescook@chromium.org>
Date: Tue Jun 28 23:43:43 2016

mash: Convert system tray logout button to wm common types

* Fold LastWindowClosedLogoutReminder into LogoutConfirmationController
* Move LogoutConfirmationController ownership from Shell to WmShell
* Place the logout confirmation dialog in the system modal container, not
in the root (dialogs should not live directly in the root)
* Move LabelTrayView to //ash/common/system/tray since it is not chromeos-
specific

BUG=619636
TEST=ash_unittests, manual testing after forcing the button to show

Review-Url: https://codereview.chromium.org/2108793002
Cr-Commit-Position: refs/heads/master@{#402595}

[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/ash.gyp
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/last_window_closed_observer.h
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/logout_button_tray.cc
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/logout_button_tray.h
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/logout_confirmation_controller.cc
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/logout_confirmation_controller.h
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/logout_confirmation_controller_unittest.cc
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/logout_confirmation_dialog.cc
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/logout_confirmation_dialog.h
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/tray_session_length_limit.cc
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/tray_session_length_limit.h
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/chromeos/session/tray_session_length_limit_unittest.cc
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/tray/label_tray_view.cc
[rename] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/tray/label_tray_view.h
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/wm_shell.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/common/wm_shell.h
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/shell.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/shell.h
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/system/chromeos/enterprise/tray_enterprise.cc
[delete] https://crrev.com/d3c4d3e2ab9589b80f64279534dabf85460dc181/ash/system/chromeos/session/last_window_closed_logout_reminder.cc
[delete] https://crrev.com/d3c4d3e2ab9589b80f64279534dabf85460dc181/ash/system/chromeos/session/last_window_closed_logout_reminder.h
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/system/chromeos/supervised/tray_supervised_user.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/system/status_area_widget.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ash/system/tray/system_tray.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/chrome/browser/ui/views/profiles/user_manager_view.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ui/views/window/dialog_delegate.cc
[modify] https://crrev.com/b73810563987686c2e4f22ba98a10fa0275372b0/ui/views/window/dialog_delegate.h
Project Member

Comment 39 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ce3e0e1345547763af637926e0ef8ce289568b4

commit 3ce3e0e1345547763af637926e0ef8ce289568b4
Author: msw <msw@chromium.org>
Date: Wed Jun 29 01:54:47 2016

mash: Migrate AccessibilityDelegate access to WmShell.

Also fix include/namespace use and session state delegate access.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2101263004
Cr-Commit-Position: refs/heads/master@{#402645}

[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/accelerators/spoken_feedback_toggler.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/accelerators/spoken_feedback_toggler_unittest.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/audio/sounds.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/system/tray/system_tray.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/3ce3e0e1345547763af637926e0ef8ce289568b4/chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc
Project Member

Comment 41 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba93d044cec883e554ec76c7d463d3ba915eab26

commit ba93d044cec883e554ec76c7d463d3ba915eab26
Author: jamescook <jamescook@chromium.org>
Date: Wed Jun 29 21:39:54 2016

mash: Convert StatusAreaWidgetDelegate to wm common types

This is a dependency of StatusAreaWidget.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2109193002
Cr-Commit-Position: refs/heads/master@{#402941}

[modify] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/ash.gyp
[modify] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/aura/wm_shelf_aura.cc
[modify] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/aura/wm_shelf_aura.h
[modify] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/common/shelf/wm_shelf.h
[rename] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/common/system/status_area_widget_delegate.cc
[rename] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/common/system/status_area_widget_delegate.h
[modify] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/mus/bridge/wm_shelf_mus.cc
[modify] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/mus/bridge/wm_shelf_mus.h
[modify] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/system/status_area_widget.cc
[modify] https://crrev.com/ba93d044cec883e554ec76c7d463d3ba915eab26/ash/wm/gestures/shelf_gesture_handler.h
Project Member

Comment 42 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e54edf1041043ed207af181f0b234adcba64f4

commit 05e54edf1041043ed207af181f0b234adcba64f4
Author: jamescook <jamescook@chromium.org>
Date: Wed Jun 29 22:11:26 2016

mash: Move system tray cast code into //ash/common

This is a dependency of SystemTray.

* Move //ash/system/chromeos/screen_security to //ash/common
* Move cast_config_delegate.* to //ash/common
* Move //ash/system/cast to //ash/common
* Fix include guards
* Fix some IWYU

BUG=619636
TEST=ash_unittests
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2109613005
Cr-Commit-Position: refs/heads/master@{#402944}

[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/ash.gyp
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/cast_config_delegate.cc
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/cast_config_delegate.h
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/system/cast/tray_cast.cc
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/system/cast/tray_cast.h
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/system/chromeos/screen_security/screen_capture_tray_item.cc
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/system/chromeos/screen_security/screen_capture_tray_item.h
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/system/chromeos/screen_security/screen_share_tray_item.cc
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/system/chromeos/screen_security/screen_share_tray_item.h
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/system/chromeos/screen_security/screen_tray_item.cc
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/system/chromeos/screen_security/screen_tray_item.h
[rename] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/common/system/chromeos/screen_security/screen_tray_item_unittest.cc
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/system/chromeos/multi_user/user_switch_util.cc
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/system/chromeos/multi_user/user_switch_util_unittest.cc
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/system/tray/system_tray.cc
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/system/tray/system_tray.h
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/test/tray_cast_test_api.cc
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/ash/test/tray_cast_test_api.h
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.h
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/chrome/browser/ui/ash/cast_config_delegate_chromeos.h
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/chrome/browser/ui/ash/cast_config_delegate_media_router.h
[modify] https://crrev.com/05e54edf1041043ed207af181f0b234adcba64f4/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
Project Member

Comment 43 by bugdroid1@chromium.org, Jun 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc0a8b48733b8b39adfddecfc207a11110f59e0f

commit bc0a8b48733b8b39adfddecfc207a11110f59e0f
Author: msw <msw@chromium.org>
Date: Thu Jun 30 02:21:14 2016

mash: Migrate SessionStateDelegate access to WmShell.

Use AshTestHelper::GetTestSessionStateDelegate as needed.
Also fix include/namespace use.

BUG=619636
TEST=Compiles; no behavior changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2111443002
Cr-Commit-Position: refs/heads/master@{#403070}

[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/desktop_background/desktop_background_view.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/frame/custom_frame_view_ash_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/mus/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/root_window_controller.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/shelf/shelf_locking_manager.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/shell/app_list.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/shell/lock_view.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/shell_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/system/chromeos/power/power_event_observer.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/test/ash_test_base.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/test/ash_test_helper.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/wm/event_client_impl.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/wm/gestures/shelf_gesture_handler.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/wm/power_button_controller.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/wm/system_modal_container_layout_manager.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/wm/window_cycle_controller_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/chromeos/login/session_login_browsertest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/memory/tab_manager.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/ash/chrome_shell_content_state_chromeos.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/ash/network_connect_delegate_chromeos.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/ash/session_util.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/views/frame/browser_frame.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/views/frame/system_menu_model_builder.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/bc0a8b48733b8b39adfddecfc207a11110f59e0f/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
Project Member

Comment 44 by bugdroid1@chromium.org, Jun 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e51cdd0bd22b6309c63a515d667086cec5342c2

commit 2e51cdd0bd22b6309c63a515d667086cec5342c2
Author: msw <msw@chromium.org>
Date: Thu Jun 30 22:18:32 2016

mash: Migrate MediaDelegate ownership and access to WmShell.

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2113023002
Cr-Commit-Position: refs/heads/master@{#403313}

[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/accelerators/accelerator_controller.cc
[rename] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/common/media_delegate.h
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/common/wm_shell.cc
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/common/wm_shell.h
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/shell.cc
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/shell.h
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/system/chromeos/media_security/multi_profile_media_tray_item.cc
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/system/user/user_card_view.cc
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/ash/test/test_shell_delegate.h
[modify] https://crrev.com/2e51cdd0bd22b6309c63a515d667086cec5342c2/chrome/browser/ui/ash/media_delegate_chromeos.h
Project Member

Comment 45 by bugdroid1@chromium.org, Jun 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5708647fa2c9ebaa6d819856acb098b4f95d604

commit c5708647fa2c9ebaa6d819856acb098b4f95d604
Author: jamescook <jamescook@chromium.org>
Date: Thu Jun 30 23:48:31 2016

mash: Move chromeos audio system tray files to //ash/common

It is a dependency of SystemTray.

* Move files to //ash/common/system/chromeos/audio
* Fix include guards
* Fix IWYU

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2113113002
Cr-Commit-Position: refs/heads/master@{#403348}

[modify] https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604/ash/ash.gyp
[rename] https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604/ash/common/system/chromeos/audio/audio_detailed_view.cc
[rename] https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604/ash/common/system/chromeos/audio/audio_detailed_view.h
[rename] https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604/ash/common/system/chromeos/audio/tray_audio_chromeos.cc
[rename] https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604/ash/common/system/chromeos/audio/tray_audio_chromeos.h
[rename] https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604/ash/common/system/chromeos/audio/tray_audio_delegate_chromeos.cc
[rename] https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604/ash/common/system/chromeos/audio/tray_audio_delegate_chromeos.h
[modify] https://crrev.com/c5708647fa2c9ebaa6d819856acb098b4f95d604/ash/system/tray/system_tray.cc
Project Member

Comment 46 by bugdroid1@chromium.org, Jul 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c9ef267e3e015d62e5dc955863a89b974894a03

commit 2c9ef267e3e015d62e5dc955863a89b974894a03
Author: jamescook <jamescook@chromium.org>
Date: Fri Jul 01 01:54:19 2016

mash: Move several chromeos system tray items to //ash/common

* //ash/system/chromeos/bluetooth
* //ash/system/chromeos/enterprise
* //ash/system/chromeos/supervised
* //ash/system/chromeos/tray_caps_lock.*

Purely mechanical, no functional changes.

BUG=619636
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2108403004
Cr-Commit-Position: refs/heads/master@{#403388}

[modify] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/ash.gyp
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/bluetooth/bluetooth_notification_controller.cc
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/bluetooth/bluetooth_notification_controller.h
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/bluetooth/tray_bluetooth.h
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/enterprise/tray_enterprise.cc
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/enterprise/tray_enterprise.h
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/supervised/custodian_info_tray_observer.h
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/supervised/tray_supervised_user.cc
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/supervised/tray_supervised_user.h
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/supervised/tray_supervised_user_unittest.cc
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/tray_caps_lock.cc
[rename] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/common/system/chromeos/tray_caps_lock.h
[modify] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/shell.cc
[modify] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/ash/system/tray/system_tray.cc
[modify] https://crrev.com/2c9ef267e3e015d62e5dc955863a89b974894a03/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
Project Member

Comment 48 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0414d41295a36b35a9fca54a993b0b56a60ddacf

commit 0414d41295a36b35a9fca54a993b0b56a60ddacf
Author: msw <msw@chromium.org>
Date: Wed Jul 06 22:58:48 2016

mash: Migrate ShellDelegate ownership and access to WmShell.

Move ownership of ShellDelegate to WMShell (was in Shell).
(pass via WmShell[Aura|Mus] constructors, create earlier)

TODO: Port and use ShellDelegateMus in ash::mus::WindowManager::Init?
TODO: Move VirtualKeyboardStateObserver out of shell_delegate.h

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org,yusukes@chromium.org

Review-Url: https://codereview.chromium.org/2118593002
Cr-Commit-Position: refs/heads/master@{#403964}

[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/accelerators/exit_warning_handler.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/ash.gyp
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/aura/wm_shell_aura.h
[rename] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/common/shell_delegate.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/common/wm_shell.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/common/wm_shell.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/mus/window_manager.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/root_window_controller.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/shelf/shelf.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/shelf/shelf_view.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/shell.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/shell.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/shell/app_list.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/shell_init_params.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/shell_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/system/user/user_view.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/sysui/keyboard_ui_mus.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/test/shell_test_api.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/test/test_keyboard_ui.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/test/test_shell_delegate.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/wm/lock_layout_manager.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/wm/lock_layout_manager.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/ash/wm/window_positioner_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/accessibility/magnification_manager.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/display/display_configuration_observer.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/display/output_protection_delegate.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/login/signin/merge_session_load_page.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/chromeos/ui/idle_app_name_notification_view.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/signin/signin_error_notifier_ash.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/ui/ash/window_positioner_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
[modify] https://crrev.com/0414d41295a36b35a9fca54a993b0b56a60ddacf/components/arc/intent_helper/arc_intent_helper_bridge.cc
Project Member

Comment 49 by bugdroid1@chromium.org, Jul 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d64c3cc606bdb71f78f4cac62280c72deca37787

commit d64c3cc606bdb71f78f4cac62280c72deca37787
Author: msw <msw@chromium.org>
Date: Thu Jul 07 00:01:02 2016

mash: Move multi_profile_uma.* to ash/common.

tools/git/move_source_file.py ash/multi_profile_uma* ash/common/
These files are used by ash/system/user.

BUG=619636
TEST=compiles; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2126963002
Cr-Commit-Position: refs/heads/master@{#403993}

[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/ash/ash.gyp
[rename] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/ash/common/multi_profile_uma.cc
[rename] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/ash/common/multi_profile_uma.h
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/ash/system/user/user_view.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/chrome/browser/memory/tab_manager.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/chrome/browser/ui/ash/session_state_delegate_chromeos.cc
[modify] https://crrev.com/d64c3cc606bdb71f78f4cac62280c72deca37787/chrome/browser/ui/browser_command_controller.cc
Project Member

Comment 51 by bugdroid1@chromium.org, Jul 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe4f2d4c3357489dc4077ef433305e2d939de109

commit fe4f2d4c3357489dc4077ef433305e2d939de109
Author: msw <msw@chromium.org>
Date: Thu Jul 07 22:06:26 2016

mash: Migrate ash/system/user to ash/common.

"git rm ash/common/system/user/DEPS" (no longer needed)
tools/git/move_source_file.py ash/system/user/* ash/common/system/user
tools/git/move_source_file.py ash/ash_view_ids.h ash/common/
Also, update tray_user_unittest.cc to only use ash/common code.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2125373002
Cr-Commit-Position: refs/heads/master@{#404240}

[modify] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/ash.gyp
[rename] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/common/ash_view_ids.h
[rename] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/common/system/user/tray_user.cc
[rename] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/common/system/user/tray_user.h
[rename] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/common/system/user/tray_user_unittest.cc
[rename] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/common/system/user/user_card_view.cc
[rename] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/common/system/user/user_card_view.h
[rename] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/common/system/user/user_view.cc
[rename] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/common/system/user/user_view.h
[modify] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/system/chromeos/media_security/multi_profile_media_tray_item.cc
[modify] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/fe4f2d4c3357489dc4077ef433305e2d939de109/ash/system/tray/system_tray.cc
[delete] https://crrev.com/76f636098ccda9f283614545352b4964e7ec2b5c/ash/system/user/DEPS
Project Member

Comment 52 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11

commit 308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11
Author: msw <msw@chromium.org>
Date: Fri Jul 08 18:11:15 2016

mash: Migrate [Keyboard]Brightness code to ash/common.

Move BrightnessControlDelegate ownership to WmShell.
(it is not closely related to AcceleratorController)

tools/git/move_source_file.py ash/system/brightness_control_delegate.h ash/common/system
tools/git/move_source_file.py ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h ash/common/system
tools/git/move_source_file.py ash/system/chromeos/keyboard_brightness_controller* ash/common/system/chromeos
tools/git/move_source_file.py ash/system/chromeos/brightness/* ash/common/system/chromeos/brightness

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2131733002
Cr-Commit-Position: refs/heads/master@{#404439}

[modify] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/accelerators/accelerator_controller.h
[modify] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/ash.gyp
[rename] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/system/brightness_control_delegate.h
[rename] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/system/chromeos/brightness/brightness_controller_chromeos.cc
[rename] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/system/chromeos/brightness/brightness_controller_chromeos.h
[rename] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/system/chromeos/brightness/tray_brightness.cc
[rename] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/system/chromeos/brightness/tray_brightness.h
[rename] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/system/chromeos/brightness/tray_brightness_unittest.cc
[rename] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/system/chromeos/keyboard_brightness_controller.cc
[rename] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/system/chromeos/keyboard_brightness_controller.h
[rename] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/system/keyboard_brightness_control_delegate.h
[modify] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/wm_shell.cc
[modify] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/common/wm_shell.h
[modify] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/shell.cc
[modify] https://crrev.com/308af3930bd5a7f2d85ce76fb76b1c1a8eec9e11/ash/system/tray/system_tray.cc
Project Member

Comment 53 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6528d2fcc2c9ef8a4bd8ac33c05ba88e298abcc4

commit 6528d2fcc2c9ef8a4bd8ac33c05ba88e298abcc4
Author: msw <msw@chromium.org>
Date: Fri Jul 08 22:40:04 2016

mash: Minor ash/common fixes for tray_display.

Just fixes some low hanging fruit here.
(other big deps on DisplayManager; ScreenOrientationController)

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2131823003
Cr-Commit-Position: refs/heads/master@{#404516}

[modify] https://crrev.com/6528d2fcc2c9ef8a4bd8ac33c05ba88e298abcc4/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/6528d2fcc2c9ef8a4bd8ac33c05ba88e298abcc4/ash/system/chromeos/tray_display.h
[modify] https://crrev.com/6528d2fcc2c9ef8a4bd8ac33c05ba88e298abcc4/ash/system/chromeos/tray_display_unittest.cc
Project Member

Comment 54 by bugdroid1@chromium.org, Jul 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66f69e4e0491ea56612c86342b7dccefcb8fe20d

commit 66f69e4e0491ea56612c86342b7dccefcb8fe20d
Author: jamescook <jamescook@chromium.org>
Date: Sat Jul 09 01:32:19 2016

ash: Move VirtualKeyboardStateObserver functionality to ShellObserver

It doesn't need to exist as a separate observer with a single function. This
simplifies ShellDelegate.

Addresses a TODO from https://codereview.chromium.org/2118593002/

BUG=619636
TEST=ash_unittests and chrome unit_tests

Review-Url: https://codereview.chromium.org/2134833002
Cr-Commit-Position: refs/heads/master@{#404559}

[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/common/shell_delegate.h
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/common/shell_observer.h
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/common/wm_shell.cc
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/common/wm_shell.h
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/root_window_controller.cc
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/test/test_shell_delegate.h
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/wm/lock_layout_manager.cc
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/ash/wm/lock_layout_manager.h
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/66f69e4e0491ea56612c86342b7dccefcb8fe20d/chrome/browser/ui/ash/chrome_shell_delegate.h
Project Member

Comment 55 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb

commit a8c8a5545454b85d358c2345e0d41edf3e9dd2eb
Author: msw <msw@chromium.org>
Date: Wed Jul 13 02:22:20 2016

mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2134753004
Cr-Commit-Position: refs/heads/master@{#404906}

[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/aura/wm_window_aura.h
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/common/wm_window_observer.h
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/content/screen_orientation_delegate_chromeos.cc
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/display/screen_orientation_controller_chromeos.h
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc
Project Member

Comment 57 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6870ff8aa26f9a335aa84e54141429110035230

commit b6870ff8aa26f9a335aa84e54141429110035230
Author: jamescook <jamescook@chromium.org>
Date: Wed Jul 13 16:25:53 2016

mash: Migrate //ash/system/toast to WM common types

"Toasts" are ARC++ notifications coming from the Android side. These need
to migrate to WmWindow/WmShell so we can use them in mus.

Also make sure the toast bounds are computed based on the "target" root window
where they will appear. The existing code placed the toasts on the target root
window (which could be the secondary display), but used the primary display's
bounds for positioning.

TODO - Convert the unit test, which relies on DisplayManager for unified
desktop mode.

BUG=619636
TEST=ash_unittests, manually spawn toasts with Ctrl-Alt-Shift-O

Review-Url: https://codereview.chromium.org/2139183003
Cr-Commit-Position: refs/heads/master@{#405181}

[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/ash.gyp
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/OWNERS
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_data.cc
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_data.h
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_manager.cc
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_manager.h
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_overlay.cc
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_overlay.h
[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/shell.cc
[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ui/arc/notification/arc_notification_manager.cc
Project Member

Comment 58 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb

commit a8c8a5545454b85d358c2345e0d41edf3e9dd2eb
Author: msw <msw@chromium.org>
Date: Wed Jul 13 02:22:20 2016

mash: Partially migrate ScreenOrientationController to ash/common.

Use ash/common types for observers and windows.
Use WmShell::GetDisplayInfo instead of DisplayManager.
Add WmWindowObserver::OnWindowVisibilityChanged.

TODO: Fix remaining DisplayManager uses.
TODO: Fix display_configuration_controller uses.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2134753004
Cr-Commit-Position: refs/heads/master@{#404906}

[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/aura/wm_window_aura.cc
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/aura/wm_window_aura.h
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/common/wm_window_observer.h
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/content/screen_orientation_delegate_chromeos.cc
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/display/screen_orientation_controller_chromeos.cc
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/ash/display/screen_orientation_controller_chromeos.h
[modify] https://crrev.com/a8c8a5545454b85d358c2345e0d41edf3e9dd2eb/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc

Comment 60 by msw@chromium.org, Jul 13 2016

Labels: -merge-merged-2795
I don't know why comment 58 added a merge label...
Project Member

Comment 61 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6870ff8aa26f9a335aa84e54141429110035230

commit b6870ff8aa26f9a335aa84e54141429110035230
Author: jamescook <jamescook@chromium.org>
Date: Wed Jul 13 16:25:53 2016

mash: Migrate //ash/system/toast to WM common types

"Toasts" are ARC++ notifications coming from the Android side. These need
to migrate to WmWindow/WmShell so we can use them in mus.

Also make sure the toast bounds are computed based on the "target" root window
where they will appear. The existing code placed the toasts on the target root
window (which could be the secondary display), but used the primary display's
bounds for positioning.

TODO - Convert the unit test, which relies on DisplayManager for unified
desktop mode.

BUG=619636
TEST=ash_unittests, manually spawn toasts with Ctrl-Alt-Shift-O

Review-Url: https://codereview.chromium.org/2139183003
Cr-Commit-Position: refs/heads/master@{#405181}

[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/ash.gyp
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/OWNERS
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_data.cc
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_data.h
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_manager.cc
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_manager.h
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_overlay.cc
[rename] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/common/system/toast/toast_overlay.h
[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/shell.cc
[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230/ui/arc/notification/arc_notification_manager.cc
Project Member

Comment 62 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47b22eb9317cfd04c39dc20aaa94418aa4749b37

commit 47b22eb9317cfd04c39dc20aaa94418aa4749b37
Author: msw <msw@chromium.org>
Date: Wed Jul 13 21:26:51 2016

mash: Move user_switch_util to chrome.

Move nearer use in session_state_delegate_chromeos.cc.

A temporary/punt measure to avoid some minor issues.
It'll need to communicate w/ash for share/capture stuff.
Avoids SystemTray access and dialog conversion tasks.

BUG=619636
TEST=compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2144083002
Cr-Commit-Position: refs/heads/master@{#405288}

[modify] https://crrev.com/47b22eb9317cfd04c39dc20aaa94418aa4749b37/ash/ash.gyp
[delete] https://crrev.com/e8a038c24159f7938949c5c82fdd35c4c0be039e/ash/system/chromeos/multi_user/user_switch_util.h
[rename] https://crrev.com/47b22eb9317cfd04c39dc20aaa94418aa4749b37/chrome/browser/ui/ash/multi_user/user_switch_util.cc
[add] https://crrev.com/47b22eb9317cfd04c39dc20aaa94418aa4749b37/chrome/browser/ui/ash/multi_user/user_switch_util.h
[rename] https://crrev.com/47b22eb9317cfd04c39dc20aaa94418aa4749b37/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc
[modify] https://crrev.com/47b22eb9317cfd04c39dc20aaa94418aa4749b37/chrome/browser/ui/ash/session_state_delegate_chromeos.cc
[modify] https://crrev.com/47b22eb9317cfd04c39dc20aaa94418aa4749b37/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/47b22eb9317cfd04c39dc20aaa94418aa4749b37/chrome/chrome_tests_unit.gypi
Project Member

Comment 63 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5

commit 399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5
Author: jamescook <jamescook@chromium.org>
Date: Wed Jul 13 23:08:07 2016

mash: Create system tray display and rotation lock items via delegate

This will allow SystemTray to be moved to //ash/common, and will allow mus
to have its own implementations. (Display management under mus will be quite
different compared to classic ash.)

BUG=619636,548429
TEST=ash_unittests, run chrome and rotate screen and verify tray item appears

Review-Url: https://codereview.chromium.org/2148943002
Cr-Commit-Position: refs/heads/master@{#405340}

[modify] https://crrev.com/399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5/ash/common/system/tray/system_tray_delegate.h
[modify] https://crrev.com/399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5/ash/system/tray/system_tray.cc
[modify] https://crrev.com/399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5/ash/system/tray/system_tray.h
[modify] https://crrev.com/399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5/ash/test/test_system_tray_delegate.cc
[modify] https://crrev.com/399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5/ash/test/test_system_tray_delegate.h
[modify] https://crrev.com/399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/399a6f9bb3fd934d8fd97d4d805ef576ce83c4c5/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
Project Member

Comment 64 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/625f7915702eac0c2aa90a7445100be2f67deffc

commit 625f7915702eac0c2aa90a7445100be2f67deffc
Author: jamescook <jamescook@chromium.org>
Date: Thu Jul 14 01:00:52 2016

mash: Move StatusTray and StatusAreaWidget to //ash/common

This will make it possible to create a StatusAreaWidget under mojo::ash.

* Convert SystemTrayTest to use wm common types
* Remove unnecessary DEPS files

No functional changes.

BUG=619636
TEST=ash_unittests
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2148593004
Cr-Commit-Position: refs/heads/master@{#405376}

[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/ash.gyp
[delete] https://crrev.com/83798bf39b35f224425c86340330abb686aca30e/ash/common/system/DEPS
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/cast/tray_cast.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/bluetooth/tray_bluetooth.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/network/tray_network_state_observer.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/network/tray_sms.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/screen_security/screen_tray_item.h
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/session/tray_session_length_limit.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/session/tray_session_length_limit_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/chromeos/tray_tracing.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/date/tray_date.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/ime/tray_ime_chromeos.cc
[rename] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/status_area_widget.cc
[rename] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/status_area_widget.h
[rename] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/system_tray.cc
[rename] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/system_tray.h
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/system_tray_item.cc
[rename] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/tray_details_view.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/tray_details_view_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/tray_image_item.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray/tray_item_view.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/update/tray_update.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/update/tray_update_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/user/tray_user.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/user/tray_user_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/user/user_view.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/common/system/web_notification/web_notification_tray.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/extended_desktop_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/first_run/first_run_helper_impl.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/root_window_controller.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/shell.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/shell/window_type_launcher.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/system/chromeos/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/system/chromeos/rotation/tray_rotation_lock.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/system/chromeos/tray_display.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/system/chromeos/tray_display_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/system/overview/overview_button_tray_unittest.cc
[delete] https://crrev.com/83798bf39b35f224425c86340330abb686aca30e/ash/system/tray/DEPS
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/test/status_area_widget_test_helper.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/test/tray_cast_test_api.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/wm/gestures/shelf_gesture_handler.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/wm/status_area_layout_manager.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/ash/wm/workspace_controller_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/chromeos/first_run/chromeos_first_run_browsertest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/chromeos/login/ui/keyboard_driven_oobe_key_handler.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/chromeos/login/ui/user_adding_screen.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/ui/ash/multi_user/user_switch_util.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/ui/ash/multi_user/user_switch_util_unittest.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/625f7915702eac0c2aa90a7445100be2f67deffc/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
Project Member

Comment 65 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/333757306609d5ae15085538c025b2d38782a2ae

commit 333757306609d5ae15085538c025b2d38782a2ae
Author: jamescook <jamescook@chromium.org>
Date: Thu Jul 14 22:09:28 2016

Add ShellDelegate, MediaDelegate and KeyboardUI stubs to mus ash

These will be necessary to get the StatusAreaWidget to display in mojo:ash.

* Fork ash::sysui::ShellDelegateMus into //ash/mus
* Convert WmShell constructors to take ShellDelegate via unique_ptr
* Use ash::KeyboardUI for now, rather than KeyboardUIMus
* Move GPUSupport and PointerWatcherDelegate to //ash/common
* Fix some IWYU

No functional changes for regular non-mash chrome.

BUG=619636
TEST=ash_unittests, run chrome --mash manually and no crashes

Review-Url: https://codereview.chromium.org/2150023002
Cr-Commit-Position: refs/heads/master@{#405594}

[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/ash.gyp
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/aura/wm_shell_aura.h
[rename] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/common/gpu_support.h
[rename] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/common/gpu_support_stub.cc
[rename] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/common/gpu_support_stub.h
[rename] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/common/pointer_watcher_delegate.h
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/common/wm_shell.cc
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/common/wm_shell.h
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/content/gpu_support_impl.h
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/mus/BUILD.gn
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/mus/root_window_controller.cc
[add] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/mus/shell_delegate_mus.cc
[add] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/mus/window_manager.cc
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/pointer_watcher_delegate_aura.h
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/shell.cc
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/sysui/pointer_watcher_delegate_mus.h
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae/ash/test/test_shell_delegate.cc
Project Member

Comment 66 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/428f986f6e49f55a148d399cf4f1cca310fe4434

commit 428f986f6e49f55a148d399cf4f1cca310fe4434
Author: jamescook <jamescook@chromium.org>
Date: Fri Jul 15 19:13:25 2016

Move AccessibilityDelegate ownership to ash::WmShell

All access is via WmShell, so it should live there.

* Move AccessibilityDelegateMus to its own file
* Introduce a WmShell::Shutdown() phase
* Rename WmShell::GetAccessibilityDelegate() to accessibility_delegate()

No functional changes.

BUG=619636
TEST=ash_unittests, chrome unit_tests
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2154523002
Cr-Commit-Position: refs/heads/master@{#405810}

[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/accelerators/spoken_feedback_toggler.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/accelerators/spoken_feedback_toggler_unittest.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/ash_touch_exploration_manager_chromeos.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/aura/wm_shell_aura.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/aura/wm_shell_aura.h
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/common/keyboard/keyboard_ui.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/common/system/ime/tray_ime_chromeos.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/common/system/ime/tray_ime_chromeos_unittest.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/common/system/tray/system_tray.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/common/system/tray/system_tray_unittest.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/common/system/tray_accessibility.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/common/wm/overview/window_selector.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/common/wm_shell.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/common/wm_shell.h
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/magnifier/magnification_controller.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/mus/BUILD.gn
[add] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/mus/accessibility_delegate_mus.cc
[add] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/mus/accessibility_delegate_mus.h
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/mus/bridge/wm_shell_mus.h
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/mus/window_manager.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/shell.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/shell.h
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/428f986f6e49f55a148d399cf4f1cca310fe4434/chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc

Comment 67 by jamescook@chromium.org, Jul 18 2016

Cc: msw@chromium.org
Status: Fixed (was: Started)
Done! There are a few additional tasks around display management, video detection and tests, but I'll file separate issues for those.
Project Member

Comment 68 by bugdroid1@chromium.org, Jul 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d37f2228b46a8f0155e4130e33a7f3615e3192a

commit 4d37f2228b46a8f0155e4130e33a7f3615e3192a
Author: jamescook <jamescook@chromium.org>
Date: Mon Jul 18 22:41:57 2016

mash: Initialize chromeos components and strings

This is required to show the status area widget in mojo:ash.

* Initialize various service singletons in WindowManagerApplication
* Add ash strings to the window manager pak file

BUG=619636
TEST=ash_unittests, mash_unittests

Review-Url: https://codereview.chromium.org/2155743003
Cr-Commit-Position: refs/heads/master@{#406126}

[modify] https://crrev.com/4d37f2228b46a8f0155e4130e33a7f3615e3192a/ash/mus/BUILD.gn
[modify] https://crrev.com/4d37f2228b46a8f0155e4130e33a7f3615e3192a/ash/mus/window_manager_application.cc

Comment 69 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 70 by patricia@chromium.org, Aug 29 2016

Status: Verified (was: Fixed)
bulk verified

Comment 71 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment