Issue metadata
Sign in to add a comment
|
Favicon of error page in incognito is black on black |
||||||||||||||||||||||||
Issue descriptionVersion: M52beta OS: Windows - open incognito page - go to "http://asdfadfa.asdfasdf.asdf.com/" or any other page that results in an error expected: - favicon should be visible on the black background of the tab actual: - favicon almost impossible to see
,
Jun 16 2016
Unduping because this issue was duped into a bug tracking a platform-specific quick fix. The real fix applies to Mac and Linux/Windows. The issue is that IDR_DEFAULT_FAVICON points to an image asset but in some cases (e.g. in tabs) we need a vector version so that we can easily change its color. We should change all places in the code that refer to IDR_DEFAULT_FAVICON to use the vector version, which they should get from some bit of code that vends the default favicon. The first step is getting a vector icon for the default favicon - sgabriel@, can you attach an SVG for that? Specifically, we need a "document" icon that can appear as the favicon in a tabstrip tab (see attached).
,
Jun 16 2016
.svg attached
,
Jun 22 2016
,
Jun 22 2016
,
Jul 5 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 1 2016
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63d027126b56e97d2d1d8f955af5d65547a11eb1 commit 63d027126b56e97d2d1d8f955af5d65547a11eb1 Author: spqchan <spqchan@chromium.org> Date: Fri Sep 02 23:29:10 2016 [Material][Mac] Replace hard-coded default favicon with .icon file BUG= 619627 Review-Url: https://codereview.chromium.org/2299423002 Cr-Commit-Position: refs/heads/master@{#416385} [modify] https://crrev.com/63d027126b56e97d2d1d8f955af5d65547a11eb1/chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm [modify] https://crrev.com/63d027126b56e97d2d1d8f955af5d65547a11eb1/ui/gfx/vector_icons/BUILD.gn [add] https://crrev.com/63d027126b56e97d2d1d8f955af5d65547a11eb1/ui/gfx/vector_icons/default_favicon.icon
,
Sep 3 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, Jun 13 2016Status: Duplicate (was: Untriaged)