New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 619627 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 618742
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Favicon of error page in incognito is black on black

Project Member Reported by spqc...@chromium.org, Jun 13 2016

Issue description

Version: M52beta
OS: Windows

- open incognito page
- go to "http://asdfadfa.asdfasdf.asdf.com/" or any other page that results in an error

expected:
- favicon should be visible on the black background of the tab

actual:
- favicon almost impossible to see

 
Mergedinto: 618742
Status: Duplicate (was: Untriaged)

Comment 2 by shrike@chromium.org, Jun 16 2016

Cc: spqc...@chromium.org shrike@chromium.org
Labels: -OS-Windows OS-All
Owner: sgabr...@chromium.org
Status: Assigned (was: Duplicate)
Unduping because this issue was duped into a bug tracking a platform-specific quick fix. The real fix applies to Mac and Linux/Windows.

The issue is that IDR_DEFAULT_FAVICON points to an image asset but in some cases (e.g. in tabs) we need a vector version so that we can easily change its color. We should change all places in the code that refer to IDR_DEFAULT_FAVICON to use the vector version, which they should get from some bit of code that vends the default favicon.

The first step is getting a vector icon for the default favicon - sgabriel@, can you attach an SVG for that? Specifically, we need a "document" icon that can appear as the favicon in a tabstrip tab (see attached).

default_favicon.png
107 bytes View Download
default_favicon_2x.png
127 bytes View Download
.svg attached
default_favicon-2x.svg
885 bytes Download
Owner: spqc...@chromium.org
Labels: -Pri-2 M-53 Pri-3
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Started (was: Assigned)
Status: Fixed (was: Started)

Sign in to add a comment